Skip to contentSkip to conversation

fs/ocfs2/dlm/dlmmaster.c:697:6: sparse: symbol 'dlm_lockres_grab_inflight_worker' was not declared. Should it be static?

PATCH New Fengguang Wu 1 participant 1 message Jun 20, 2014 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 53a3b963.q9GAR9fXkW3Cu2/w%[email protected]

#1 lore raw

PATCH 69/230 fs/ocfs2/dlm/dlmmaster.c:697:6: sparse: symbol 'dlm_lockres_grab_inflight_worker' was not declared. Should it be static?

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   df25ba7db0775d87018e2cd92f26b9b087093840
commit: 1d26b017b74447dcc978ecb358fdc3a71887fc1c [69/230] ocfs2/dlm: do not purge lockres that is queued for assert master
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
Quoted 3 lines
Quoted 3 lines

fs/ocfs2/dlm/dlmmaster.c:697:6: sparse: symbol 'dlm_lockres_grab_inflight_worker' was not declared. Should it be static? fs/ocfs2/dlm/dlmmaster.c:705:6: sparse: symbol '__dlm_lockres_drop_inflight_worker' was not declared. Should it be static? fs/ocfs2/dlm/dlmmaster.c:716:6: sparse: symbol 'dlm_lockres_drop_inflight_worker' was not declared. Should it be static?

fs/ocfs2/dlm/dlmmaster.c:2690:20: sparse: context imbalance in 'dlm_empty_lockres' - unexpected unlock fs/ocfs2/dlm/dlmcommon.h:1137:9: sparse: context imbalance in 'dlm_reset_mleres_owner' - unexpected unlock fs/ocfs2/dlm/dlmmaster.c:3243:9: sparse: context imbalance in 'dlm_clean_master_list' - different lock contexts for basic block

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation

From: Fengguang Wu <[email protected]>
Subject: [PATCH mmotm] ocfs2/dlm: dlm_lockres_grab_inflight_worker() can be static
TO: Xue jiufei <[email protected]>
CC: Johannes Weiner <[email protected]>
CC: [email protected]
CC: [email protected]

CC Xue jiufei <[email protected]>
CC Johannes Weiner <[email protected]>
---
 dlmmaster.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/ocfs2/dlm/dlmmaster.c +3 -3
index a302816..82abf0c 100644
@@ -694,7 +694,7 @@ void __dlm_lockres_grab_inflight_worker(struct dlm_ctxt *dlm,
 			res->inflight_assert_workers);
 }
 
-void dlm_lockres_grab_inflight_worker(struct dlm_ctxt *dlm,
+static void dlm_lockres_grab_inflight_worker(struct dlm_ctxt *dlm,
 		struct dlm_lock_resource *res)
 {
 	spin_lock(&res->spinlock);
@@ -702,7 +702,7 @@ void dlm_lockres_grab_inflight_worker(struct dlm_ctxt *dlm,
 	spin_unlock(&res->spinlock);
 }
 
-void __dlm_lockres_drop_inflight_worker(struct dlm_ctxt *dlm,
+static void __dlm_lockres_drop_inflight_worker(struct dlm_ctxt *dlm,
 		struct dlm_lock_resource *res)
 {
 	assert_spin_locked(&res->spinlock);
@@ -713,7 +713,7 @@ void __dlm_lockres_drop_inflight_worker(struct dlm_ctxt *dlm,
 			res->inflight_assert_workers);
 }
 
-void dlm_lockres_drop_inflight_worker(struct dlm_ctxt *dlm,
+static void dlm_lockres_drop_inflight_worker(struct dlm_ctxt *dlm,
 		struct dlm_lock_resource *res)
 {
 	spin_lock(&res->spinlock);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>