arm: Add basic support for Mediatek Cortex-A7 SoCs

drivers/of/address.c +14 -0

+/*
+ * of_io_request_and_map - Requests a resource and maps the memory mapped IO
+ *			   for a given device_node
+ * @device:	the device whose io range will be mapped
+ * @index:	index of the io range
+ * @name:	name of the resource
+ *
+ * Returns a pointer to the requested and mapped memory
+ */
+void __iomem *of_io_request_and_map(struct device_node *np, int index,
+					char *name)
+{
+	struct resource res;
+	void __iomem *mem;

Add binding documentation for the General Porpose Timer driver of the Mediatek SoCs.

Signed-off-by Matthias Brugger <[email protected]>

Acked-by S?ren Brinkmann <[email protected]>

Acked-by Rob Herring <[email protected]>

---
 .../bindings/timer/mediatek,mtk-timer.txt          |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +7 -0

new file mode 100644
index 0000000..10b7e09
@@ -0,0 +1,18 @@
+Mediatek MT6577, MT6572 and MT6589 Timers
+---------------------------------------
+
+Required properties:
+- compatible: Should be "mediatek,mt6577-timer"
+- reg: Should contain location and length for timers register.
+- clocks: Clocks driving the timer hardware. This list should include two

Quoted 28 lines

Add binding documentation for the General Porpose Timer driver of the Mediatek SoCs.

Signed-off-by Matthias Brugger <[email protected]>

Acked-by S?ren Brinkmann <[email protected]>

Acked-by Rob Herring <[email protected]>

---
 .../bindings/timer/mediatek,mtk-timer.txt          |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +11 -0

new file mode 100644
index 0000000..10b7e09
@@ -0,0 +1,18 @@
+Mediatek MT6577, MT6572 and MT6589 Timers
+---------------------------------------
+
+Required properties:
+- compatible: Should be "mediatek,mt6577-timer"
+- reg: Should contain location and length for timers register.
+- clocks: Clocks driving the timer hardware. This list should include two
+     clocks. The order is system clock and as second clock the RTC clock.
+
+Examples:
+

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt line 17

Quoted 6 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +6 -0

+     timer at 10008000 {
+             compatible = "mediatek,mt6577-timer";
+             reg = <0x10008000 0x80>;
+             interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>;
+             clocks = <&system_clk>, <&rtc_clk>;
+             clock-names = "system-clk", "rtc-clk";

These names should be mentioned above, or removed.

This looks fine otherwise.

Mark.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2014-06-20 14:36 GMT+02:00 Mark Rutland <[email protected]>:

Quoted 29 lines · Matthias Brugger

Quoted 28 lines

Add binding documentation for the General Porpose Timer driver of the Mediatek SoCs.

Signed-off-by Matthias Brugger <[email protected]>

Acked-by S?ren Brinkmann <[email protected]>

Acked-by Rob Herring <[email protected]>

---
 .../bindings/timer/mediatek,mtk-timer.txt          |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +11 -0

new file mode 100644
index 0000000..10b7e09
@@ -0,0 +1,18 @@
+Mediatek MT6577, MT6572 and MT6589 Timers
+---------------------------------------
+
+Required properties:
+- compatible: Should be "mediatek,mt6577-timer"
+- reg: Should contain location and length for timers register.
+- clocks: Clocks driving the timer hardware. This list should include two
+     clocks. The order is system clock and as second clock the RTC clock.
+
+Examples:
+

Quoted 8 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt line 17

Quoted 6 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +6 -0

+     timer at 10008000 {
+             compatible = "mediatek,mt6577-timer";
+             reg = <0x10008000 0x80>;
+             interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>;
+             clocks = <&system_clk>, <&rtc_clk>;
+             clock-names = "system-clk", "rtc-clk";

These names should be mentioned above, or removed.

I added the clock-names to make it the clock order clearer, as it is done in the arm sp,804 [1].
But I think it is clear enough through the phandle names and the description of the clocks property.
So I will delete the clock-names in the v10 round.

Quoted 39 lines

2014-06-20 14:36 GMT+02:00 Mark Rutland <[email protected]>:

Quoted 29 lines · Matthias Brugger

Quoted 28 lines

Add binding documentation for the General Porpose Timer driver of the Mediatek SoCs.

Signed-off-by Matthias Brugger <[email protected]>

Acked-by S?ren Brinkmann <[email protected]>

Acked-by Rob Herring <[email protected]>

---
 .../bindings/timer/mediatek,mtk-timer.txt          |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +11 -0

new file mode 100644
index 0000000..10b7e09
@@ -0,0 +1,18 @@
+Mediatek MT6577, MT6572 and MT6589 Timers
+---------------------------------------
+
+Required properties:
+- compatible: Should be "mediatek,mt6577-timer"
+- reg: Should contain location and length for timers register.
+- clocks: Clocks driving the timer hardware. This list should include two
+     clocks. The order is system clock and as second clock the RTC clock.
+
+Examples:
+

Quoted 8 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt line 17

Quoted 6 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +6 -0

+     timer at 10008000 {
+             compatible = "mediatek,mt6577-timer";
+             reg = <0x10008000 0x80>;
+             interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>;
+             clocks = <&system_clk>, <&rtc_clk>;
+             clock-names = "system-clk", "rtc-clk";

These names should be mentioned above, or removed.

Quoted 5 lines

I added the clock-names to make it the clock order clearer, as it is done in the arm sp,804 [1].
But I think it is clear enough through the phandle names and the description of the clocks property.
So I will delete the clock-names in the v10 round.

I think I originally advocated for adding those names. And my argument was that the names in the dts are probably not clearly identifying the timer IP's clock inputs since they refer to SOC names for the clocks. We had this argument for a while now and it doesn't seem to get better than this. But to explain why I try to get IP vs. SOC clock names in here is, that I had such a case with Zynq's Ethernet core. That IP has quite a few clock inputs and luckily the mainline driver for that IP used the proper names from the IP data sheet for the clocks instead of the SOC names. That made it relatively easy to match things with the Zynq integration of that IP. Had that driver used SOC clock names, things would have been more difficult.

S?ren

2014-07-01 20:00 GMT+02:00 S?ren Brinkmann <[email protected]>:

Quoted 46 lines · Matthias Brugger

Quoted 39 lines

2014-06-20 14:36 GMT+02:00 Mark Rutland <[email protected]>:

Quoted 29 lines · Matthias Brugger

Quoted 28 lines

Add binding documentation for the General Porpose Timer driver of the Mediatek SoCs.

Signed-off-by Matthias Brugger <[email protected]>

Acked-by S?ren Brinkmann <[email protected]>

Acked-by Rob Herring <[email protected]>

---
 .../bindings/timer/mediatek,mtk-timer.txt          |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +11 -0

new file mode 100644
index 0000000..10b7e09
@@ -0,0 +1,18 @@
+Mediatek MT6577, MT6572 and MT6589 Timers
+---------------------------------------
+
+Required properties:
+- compatible: Should be "mediatek,mt6577-timer"
+- reg: Should contain location and length for timers register.
+- clocks: Clocks driving the timer hardware. This list should include two
+     clocks. The order is system clock and as second clock the RTC clock.
+
+Examples:
+

Quoted 8 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt line 17

Quoted 6 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt new file +6 -0

+     timer at 10008000 {
+             compatible = "mediatek,mt6577-timer";
+             reg = <0x10008000 0x80>;
+             interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>;
+             clocks = <&system_clk>, <&rtc_clk>;
+             clock-names = "system-clk", "rtc-clk";

These names should be mentioned above, or removed.

Quoted 5 lines

I added the clock-names to make it the clock order clearer, as it is done in the arm sp,804 [1].
But I think it is clear enough through the phandle names and the description of the clocks property.
So I will delete the clock-names in the v10 round.

Quoted 11 lines

I think I originally advocated for adding those names. And my argument was that the names in the dts are probably not clearly identifying the timer IP's clock inputs since they refer to SOC names for the clocks. We had this argument for a while now and it doesn't seem to get better than this. But to explain why I try to get IP vs. SOC clock names in here is, that I had such a case with Zynq's Ethernet core. That IP has quite a few clock inputs and luckily the mainline driver for that IP used the proper names from the IP data sheet for the clocks instead of the SOC names. That made it relatively easy to match things with the Zynq integration of that IP. Had that driver used SOC clock names, things would have been more difficult.

S?ren, I get the point. The problem is, that we don't have any documentation other then the SoC datasheet for the timer. Anyway the clock-names property does not help us in this at all. As I already mentioned, the clock-names property was to illustrate the clock order, but as I think, with the comment for the clocks property, the order is clear enough.

Shall I delete your ack, when I resend the patch without the clock-names property?