Skip to contentSkip to conversation

ARM: dts: mx5: Fix IPU port node placement

PATCH New Marek Vasut 3 participants 4 messages Jun 13, 2014 – Jun 21, 2014

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/2 ARM: dts: mx5: Fix IPU port node placement

The "port" node was misplaced in the original patch, therefore making the LCD dysfunctional on this board. Fix this by moving the "port" DT node into the "display {}" node.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Philipp Zabel <[email protected]>
---
 arch/arm/boot/dts/imx53-m53evk.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx53-m53evk.dts +4 -4
index d5d146a..3a04b9e 100644
@@ -43,11 +43,11 @@
 					vsync-active = <1>;
 				};
 			};
-		};
 
-		port {
-			display1_in: endpoint {
-				remote-endpoint = <&ipu_di1_disp1>;
+			port {
+				display1_in: endpoint {
+					remote-endpoint = <&ipu_di1_disp1>;
+				};
 			};
 		};
 	};
Signature · 1 line
2.0.0.rc2
author
#1 lore raw

PATCH 2/2 ARM: dts: mx5: Move the display out of soc {} node

Move the display {} node out of the soc {} node . This just aligns the DT with other boards, there is no functional change.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>
---
 arch/arm/boot/dts/imx53-m53evk.dts | 48 ++++++++++++++++++--------------------
 1 file changed, 23 insertions(+), 25 deletions(-)
arch/arm/boot/dts/imx53-m53evk.dts +23 -25
index 3a04b9e..c4956b0 100644
@@ -21,33 +21,31 @@
 		      <0xb0000000 0x20000000>;
 	};
 
-	soc {
-		display1: display at di1 {
-			compatible = "fsl,imx-parallel-display";
-			interface-pix-fmt = "bgr666";
-			pinctrl-names = "default";
-			pinctrl-0 = <&pinctrl_ipu_disp1>;
-
-			display-timings {
-				800x480p60 {
-					native-mode;
-					clock-frequency = <31500000>;
-					hactive = <800>;
-					vactive = <480>;
-					hfront-porch = <40>;
-					hback-porch = <88>;
-					hsync-len = <128>;
-					vback-porch = <33>;
-					vfront-porch = <9>;
-					vsync-len = <3>;
-					vsync-active = <1>;
-				};
+	display1: display at di1 {
+		compatible = "fsl,imx-parallel-display";
+		interface-pix-fmt = "bgr666";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_ipu_disp1>;
+
+		display-timings {
+			800x480p60 {
+				native-mode;
+				clock-frequency = <31500000>;
+				hactive = <800>;
+				vactive = <480>;
+				hfront-porch = <40>;
+				hback-porch = <88>;
+				hsync-len = <128>;
+				vback-porch = <33>;
+				vfront-porch = <9>;
+				vsync-len = <3>;
+				vsync-active = <1>;
 			};
+		};
 
-			port {
-				display1_in: endpoint {
-					remote-endpoint = <&ipu_di1_disp1>;
-				};
+		port {
+			display1_in: endpoint {
+				remote-endpoint = <&ipu_di1_disp1>;
 			};
 		};
 	};
Signature · 1 line
2.0.0.rc2
#2 lore raw

PATCH 1/2 ARM: dts: mx5: Fix IPU port node placement

In reply to Marek Vasut

Am Freitag, den 13.06.2014, 02:22 +0200 schrieb Marek Vasut:

Quoted 7 lines

The "port" node was misplaced in the original patch, therefore making the LCD dysfunctional on this board. Fix this by moving the "port" DT node into the "display {}" node.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Philipp Zabel <[email protected]>
Acked-by Philipp Zabel <[email protected]>

thanks
Philipp

Applied
#3 lore raw

PATCH 1/2 ARM: dts: mx5: Fix IPU port node placement

In reply to Marek Vasut
Quoted 5 lines · Marek Vasut

The "port" node was misplaced in the original patch, therefore making the LCD dysfunctional on this board. Fix this by moving the "port" DT node into the "display {}" node.

Signed-off-by Marek Vasut <[email protected]>

Applied both, thanks.