Staging: rtl8192e: adjust error handling
PATCH 1/1 Staging: rtl8192e: adjust error handling
This patch removes a test in error handling code by adding a return path.
The Coccinelle semantic match that found the problem is:
// <smpl>
@@
expression E,E1,E2;
@@
E = alloc_etherdev(...)
... when != E = E1
if (...) { ... free_netdev(E); ... return ...; }
... when != E = E2
(
if (...)
{
... when != free_netdev(E);
return dev; }
|
* if (...)
{
... when != free_netdev(E);
return ...; }
|register_netdev(E)
)
// </smpl>
Signed-off-by Himangi Saraogi <[email protected]>
Acked-by Julia Lawall <[email protected]>
--- drivers/staging/rtl8192e/rtllib_module.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/rtl8192e/rtllib_module.c +2 -3
@@ -111,7 +111,7 @@ struct net_device *alloc_rtllib(int sizeof_priv) dev =alloc_etherdev (sizeof (struct rtllib_device ) + sizeof_priv);if (!dev) {RTLLIB_ERROR ("Unable to network device.\n" ); - goto failed; +return NULL ; } ieee = (struct rtllib_device *)netdev_priv_rsl (dev);memset (ieee,0 ,sizeof (struct rtllib_device )+sizeof_priv);
@@ -180,8 +180,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)return dev; failed: -if (dev) -free_netdev (dev); +free_netdev (dev);return NULL ; }EXPORT_SYMBOL (alloc_rtllib);
Signature · 1 line
1.9.1