Skip to contentSkip to conversation

staging: rtl8172u: Make ieee80211_crypto_init static

PATCH In review L. Alberto Giménez 2 participants 4 messages Jun 12, 2014 – Jun 21, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8172u: Make ieee80211_crypto_init static

Fix sparse warning.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +1 -1
index 5533221..3be690d 100644
@@ -200,7 +200,7 @@ static struct ieee80211_crypto_ops ieee80211_crypt_null = {
 	.owner			= THIS_MODULE,
 };
 
-int __init ieee80211_crypto_init(void)
+static int __init ieee80211_crypto_init(void)
 {
 	int ret = -ENOMEM;
 
Signature · 1 line
2.0.0.rc0
#1 lore raw
Quoted 12 lines · L. Alberto Giménez

Fix sparse warning.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +0 -0
index 5533221..3be690d 100644

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c static struct ieee80211_crypto_ops ieee80211_crypt_null = { · line 205

Quoted 7 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +1 -1
@@ -200,7 +200,7 @@ static struct ieee80211_crypto_ops ieee80211_crypt_null = {
 	.owner			= THIS_MODULE,
 };
 
-int __init ieee80211_crypto_init(void)
+static int __init ieee80211_crypto_init(void)
 {
 	int ret = -ENOMEM;

You obviously did not compile this change :(

greg k-h

#2 lore raw
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · L. Alberto Giménez

Fix sparse warning.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +0 -0
index 5533221..3be690d 100644
@@ -200,7 +200,7 @@ static struct ieee80211_crypto_ops ieee80211_crypt_null = {
 	.owner			= THIS_MODULE,
 };
 
Quoted 8 lines

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c static struct ieee80211_crypto_ops ieee80211_crypt_null = { · line 205

Quoted 4 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +1 -1
-int __init ieee80211_crypto_init(void)
+static int __init ieee80211_crypto_init(void)
 {
 	int ret = -ENOMEM;

You obviously did not compile this change :(

greg k-h

Hi Greg,

I'm very sorry for that, I swear I compiled it, but clearly I'm missing something here.

My patch compiles with a warning, but tag v3.15 (tag where my branch is based) does not issue this warning:

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:19: warning:
‘ieee80211_crypto_init’ defined but not used [-Wunused-function]
static int __init ieee80211_crypto_init(void)

                   ^

I thought that __init functions could be static, is there any problem with that? Care to shed some light here?

Thank you very much

Signature · 2 lines
L. Alberto Giménez
GnuPG key ID 0xDD4E27AB
#3 lore raw
Quoted 34 lines · L. Alberto Giménez
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · L. Alberto Giménez

Fix sparse warning.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +0 -0
index 5533221..3be690d 100644
@@ -200,7 +200,7 @@ static struct ieee80211_crypto_ops ieee80211_crypt_null = {
 	.owner			= THIS_MODULE,
 };
 
Quoted 8 lines

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c static struct ieee80211_crypto_ops ieee80211_crypt_null = { · line 205

Quoted 4 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +1 -1
-int __init ieee80211_crypto_init(void)
+static int __init ieee80211_crypto_init(void)
 {
 	int ret = -ENOMEM;

You obviously did not compile this change :(

greg k-h

Hi Greg,

I'm very sorry for that, I swear I compiled it, but clearly I'm missing something here.

My patch compiles with a warning, but tag v3.15 (tag where my branch is based) does not issue this warning:

Quoted 7 lines

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:19: warning:
‘ieee80211_crypto_init’ defined but not used [-Wunused-function]
static int __init ieee80211_crypto_init(void)

                   ^

I thought that __init functions could be static, is there any problem with that? Care to shed some light here?

That function is called by a different file, it can not be static, I don't know how you were able to successfully build the driver with your change...