thor: cosmetic: Update the cmd_thordown help message to present example usage
PATCH 1/1 thor: cosmetic: Update the cmd_thordown help message to present example usage
--- common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_thordown.c +1 -1
@@ -64,7 +64,7 @@ done:U_BOOT_CMD (thordown,CONFIG_SYS_MAXARGS ,1 , do_thor_down,"TIZEN \"THOR\" downloader" , -"<USB_controller> <interface> <dev>\n" +"<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
Signature · 1 line
2.0.0.rc2
PATCH 1/1 thor: cosmetic: Update the cmd_thordown help message to present example usage
common/cmd_thordown.c done: · line 70
Quoted 9 lines · Lukasz Majewski
common/cmd_thordown.c +1
-1U_BOOT_CMD (thordown,CONFIG_SYS_MAXARGS ,1 , do_thor_down,"TIZEN \"THOR\" downloader" , -"<USB_controller> <interface> <dev>\n" +"<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
I couldn't find any examples of other commands which do this. Rathe than add the "e.g." text, perhaps just add the word "thor" at the start of the command parameter list. That's much more common in existing commands:
- "<USB_controller> <interface> <dev>\n"
+ "thor <USB_controller> <interface> <dev>\n"
PATCH 1/1 thor: cosmetic: Update the cmd_thordown help message to present example usage
Hi Stephen,
Quoted 18 lines · Lukasz Majewski
common/cmd_thordown.c done: · line 70
Quoted 10 lines
common/cmd_thordown.c +1
-1U_BOOT_CMD (thordown,CONFIG_SYS_MAXARGS ,1 , do_thor_down,"TIZEN \"THOR\" downloader" , -"<USB_controller> <interface> <dev>\n" +"<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"I couldn't find any examples of other commands which do this. Rathe than add the "e.g." text, perhaps just add the word "thor" at the start of the command parameter list. That's much more common in existing commands:
Review
Quoted 2 lines
(quoted diff) +1
-1- "<USB_controller> <interface> <dev>\n" + "thor <USB_controller> <interface> <dev>\n"
Ok. Thanks.
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
PATCH v2 1/1 thor: cosmetic: Update the cmd_thordown help message to present example usage
In reply to Lukasz Majewski--- common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_thordown.c +1 -1
@@ -64,7 +64,7 @@ exit:U_BOOT_CMD (thordown,CONFIG_SYS_MAXARGS ,1 , do_thor_down,"TIZEN \"THOR\" downloader" , -"<USB_controller> <interface> <dev>\n" +"thor <USB_controller> <interface> <dev>\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
Signature · 1 line
2.0.0.rc2
PATCH v2 1/1 thor: cosmetic: Update the cmd_thordown help message to present example usage
Quoted 10 lines · Lukasz Majewski
Signed-off-by Lukasz Majewski <[email protected]>--- common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/cmd_thordown.c +0
-0
common/cmd_thordown.c exit: · line 70
Quoted 8 lines
common/cmd_thordown.c +1
-1@@ -64,7 +64,7 @@ exit:U_BOOT_CMD (thordown,CONFIG_SYS_MAXARGS ,1 , do_thor_down,"TIZEN \"THOR\" downloader" , -"<USB_controller> <interface> <dev>\n" +"thor <USB_controller> <interface> <dev>\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
Looks like v2014.07 matter to me. A description in the patch would be appreciated though, so can you do a V3 with it ?
Best regards,
Marek Vasut
PATCH v2 1/1 thor: cosmetic: Update the cmd_thordown help message to present example usage
In reply to Lukasz MajewskiDear all,
Quoted 10 lines
Signed-off-by Lukasz Majewski <[email protected]>--- common/cmd_thordown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/cmd_thordown.c +0
-0
common/cmd_thordown.c exit: · line 70
Quoted 8 lines
common/cmd_thordown.c +1
-1@@ -64,7 +64,7 @@ exit:U_BOOT_CMD (thordown,CONFIG_SYS_MAXARGS ,1 , do_thor_down,"TIZEN \"THOR\" downloader" , -"<USB_controller> <interface> <dev>\n" +"thor <USB_controller> <interface> <dev>\n" " - device software upgrade via LTHOR TIZEN dowload\n" " program via <USB_controller> on device <dev>,\n" " attached to interface <interface>\n"
Please discard this patch. I need to devise more neat solution.
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group