Skip to contentSkip to conversation

ASoC: cs42l56: Fix stereo channel register assignment for Headphone and LineOut volume mixers

PATCH Brian Austin 2 participants 5 messages Jun 23, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Brian Austin

author Acked-by
#1 lore raw
Quoted 27 lines · Ryan Harvey

Stereo Headphone and LineOut volume mixers are now attached to HPA+HPB, LOA+LOB.

---
sound/soc/codecs/cs42l56.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/cs42l56.c +2 -2
index fdc4bd2..8e68ef5 100644
@@ -445,9 +445,9 @@ static const struct snd_kcontrol_new cs42l56_snd_controls[] = {
 	SOC_DOUBLE("ADC Boost Switch", CS42L56_GAIN_BIAS_CTL, 3, 2, 1, 1),
 
 	SOC_DOUBLE_R_SX_TLV("Headphone Volume", CS42L56_HPA_VOLUME,
-			      CS42L56_HPA_VOLUME, 0, 0x44, 0x55, hl_tlv),
+			      CS42L56_HPB_VOLUME, 0, 0x44, 0x55, hl_tlv),
 	SOC_DOUBLE_R_SX_TLV("LineOut Volume", CS42L56_LOA_VOLUME,
-			      CS42L56_LOA_VOLUME, 0, 0x44, 0x55, hl_tlv),
+			      CS42L56_LOB_VOLUME, 0, 0x44, 0x55, hl_tlv),
 
 	SOC_SINGLE_TLV("Bass Shelving Volume", CS42L56_TONE_CTL,
 			0, 0x00, 1, tone_tlv),
Signature · 1 line
1.7.9.5

Thanks,

#2 lore raw
Quoted 3 lines · Brian Austin
Quoted 1 line · Ryan Harvey

Stereo Headphone and LineOut volume mixers are now attached to HPA+HPB, LOA+LOB.

I don't seem to have been copied on the original patches here, or they're snarled up somewhere in transmission anyway.

#3 lore raw
Quoted 8 lines · Mark Brown
Quoted 3 lines · Brian Austin
Quoted 1 line · Ryan Harvey

Stereo Headphone and LineOut volume mixers are now attached to HPA+HPB, LOA+LOB.

I don't seem to have been copied on the original patches here, or they're snarled up somewhere in transmission anyway.

You're there. Maybe stuck in Moderator with first post to mailing list?

#4 lore raw
Quoted 10 lines · Brian Austin
Quoted 7 lines · Mark Brown
Quoted 3 lines · Brian Austin
Quoted 1 line · Ryan Harvey

Stereo Headphone and LineOut volume mixers are now attached to HPA+HPB, LOA+LOB.

I don't seem to have been copied on the original patches here, or they're snarled up somewhere in transmission anyway.

You're there. Maybe stuck in Moderator with first post to mailing list?

The list shouldn't affect the direct CC to me though.

#5 lore raw
Quoted 5 lines · Mark Brown
Quoted 3 lines · Brian Austin
Quoted 2 lines · Mark Brown
Quoted 1 line · Brian Austin

On Mon, 23 Jun 2014, Ryan Harvey wrote:

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line

Stereo Headphone and LineOut volume mixers are now attached to HPA+HPB, LOA+LOB.

I don't seem to have been copied on the original patches here, or they're snarled up somewhere in transmission anyway.

You're there. Maybe stuck in Moderator with first post to mailing list?

The list shouldn't affect the direct CC to me though.

Good point...
For some reason our IT department does not like us sending email

I may just send on behalf of him until this can get straightened out.

Thanks,