timerfd c/r support, v4
Subsystems (4)
cover timerfd c/r support, v4
Hi guys, here is an updated version of c/r support for timerfd files. The main change is in how @ticks are restored in patch 3 -- I switched to ioctl code, which is wrapped with CONFIG because I still think that while there is only one ioctl designated solely for c/r needs no need to build it all the time until explicitly requested. Please take a look once time permit. Comments are highly appreciated. Also note the last patch is for man-page git repo, not for kernel.
Thanks!
PATCH 1/4 timerfd: Implement show_fdinfo method
For checkpoint/restore of timerfd files we need to know how exactly the timer were armed, to be able to recreate it on restore stage. Thus implement show_fdinfo method which provides enough information for that.
One of significant changes I think is the addition of @settime_flags member. Currently there are two flags TFD_TIMER_ABSTIME and TFD_TIMER_CANCEL_ON_SET, and the second can be found from @might_cancel variable but in case if the flags will be extended in future we most probably will have to somehow remember them explicitly anyway so I guss doing that right now won't hurt.
To not bloat the timerfd_ctx structure I've converted @expired to short integer and defined @settime_flags as short too.
v2 (by avagin@, vdavydov@ and tglx@):
- Add it_value/it_interval fields
- Save flags being used in timerfd_setup in context
v3 (by tglx@):
- don't forget to use CONFIG_PROC_FS
--- fs/timerfd.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-)
fs/timerfd.c +33 -1
@@ -35,8 +35,9 @@ struct timerfd_ctx {ktime_t moffs;wait_queue_head_t wqh;u64 ticks; -int expired;int clockid; +short unsigned expired; +short unsigned settime_flags;/* to show in fdinfo */ struct rcu_head rcu;struct list_head clist;bool might_cancel;
@@ -196,6 +197,8 @@ static int timerfd_setup(struct timerfd_if (timerfd_canceled (ctx))return -ECANCELED ; } + + ctx->settime_flags = flags &TFD_SETTIME_FLAGS ;return 0 ; }
@@ -284,11 +287,40 @@ static ssize_t timerfd_read(struct filereturn res; } +#ifdef CONFIG_PROC_FS +static int timerfd_show (struct seq_file *m,struct file *file) +{ +struct timerfd_ctx *ctx = file->private_data; +struct itimerspec t; + +spin_lock_irq (&ctx->wqh.lock); + t.it_value =ktime_to_timespec (timerfd_get_remaining (ctx)); + t.it_interval =ktime_to_timespec (ctx->tintv); +spin_unlock_irq (&ctx->wqh.lock); + +return seq_printf (m, +"clockid: %d\n" +"ticks: %llu\n" +"settime flags: 0%o\n" +"it_value: (%llu, %llu)\n" +"it_interval: (%llu, %llu)\n" , + ctx->clockid, (unsigned long long )ctx->ticks, + ctx->settime_flags, + (unsigned long long )t.it_value.tv_sec, + (unsigned long long )t.it_value.tv_nsec, + (unsigned long long )t.it_interval.tv_sec, + (unsigned long long )t.it_interval.tv_nsec); +} +#endif +static const struct file_operations timerfd_fops = { .release = timerfd_release, .poll = timerfd_poll, .read = timerfd_read, .llseek = noop_llseek, +#ifdef CONFIG_PROC_FS + .show_fdinfo = timerfd_show, +#endif };static int timerfd_fget (int fd,struct fd *p)
PATCH 1/4 timerfd: Implement show_fdinfo method
For checkpoint/restore of timerfd files we need to know how exactly the timer were armed, to be able to recreate it on restore stage. Thus implement show_fdinfo method which provides enough information for that.
One of significant changes I think is the addition of @settime_flags member. Currently there are two flags TFD_TIMER_ABSTIME and TFD_TIMER_CANCEL_ON_SET, and the second can be found from @might_cancel variable but in case if the flags will be extended in future we most probably will have to somehow remember them explicitly anyway so I guss doing that right now won't hurt.
To not bloat the timerfd_ctx structure I've converted @expired to short integer and defined @settime_flags as short too.
v2 (by avagin@, vdavydov@ and tglx@):
- Add it_value/it_interval fields
- Save flags being used in timerfd_setup in context
v3 (by tglx@):
- don't forget to use CONFIG_PROC_FS
v4 (by akpm@):
-Use define timerfd_show NULL for non c/r config
---
A nit fixed in timerfd_show for non c/r config
fs/timerfd.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-)
fs/timerfd.c +33 -1
@@ -35,8 +35,9 @@ struct timerfd_ctx {ktime_t moffs;wait_queue_head_t wqh;u64 ticks; -int expired;int clockid; +short unsigned expired; +short unsigned settime_flags;/* to show in fdinfo */ struct rcu_head rcu;struct list_head clist;bool might_cancel;
@@ -196,6 +197,8 @@ static int timerfd_setup(struct timerfd_if (timerfd_canceled (ctx))return -ECANCELED ; } + + ctx->settime_flags = flags &TFD_SETTIME_FLAGS ;return 0 ; }
@@ -284,11 +287,40 @@ static ssize_t timerfd_read(struct filereturn res; } +#ifdef CONFIG_PROC_FS +static int timerfd_show (struct seq_file *m,struct file *file) +{ +struct timerfd_ctx *ctx = file->private_data; +struct itimerspec t; + +spin_lock_irq (&ctx->wqh.lock); + t.it_value =ktime_to_timespec (timerfd_get_remaining (ctx)); + t.it_interval =ktime_to_timespec (ctx->tintv); +spin_unlock_irq (&ctx->wqh.lock); + +return seq_printf (m, +"clockid: %d\n" +"ticks: %llu\n" +"settime flags: 0%o\n" +"it_value: (%llu, %llu)\n" +"it_interval: (%llu, %llu)\n" , + ctx->clockid, (unsigned long long )ctx->ticks, + ctx->settime_flags, + (unsigned long long )t.it_value.tv_sec, + (unsigned long long )t.it_value.tv_nsec, + (unsigned long long )t.it_interval.tv_sec, + (unsigned long long )t.it_interval.tv_nsec); +} +#else +#define timerfd_show NULL +#endif +static const struct file_operations timerfd_fops = { .release = timerfd_release, .poll = timerfd_poll, .read = timerfd_read, .llseek = noop_llseek, + .show_fdinfo = timerfd_show, };static int timerfd_fget (int fd,struct fd *p)
PATCH 2/4 docs: procfs -- Document timerfd output
In reply to Cyrill Gorcunov--- Documentation/filesystems/proc.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
Documentation/filesystems/proc.txt +19 -0
@@ -1743,6 +1743,25 @@ pair provide additional information part While the first three lines are mandatory and always printed, the rest is optional and may be omitted if no marks created yet. + Timerfd files + ~~~~~~~~~~~~~ + + pos: 0 + flags: 02 + mnt_id: 9 + clockid: 0 + ticks: 0 + settime flags: 01 + it_value: (0, 49406829) + it_interval: (1, 0) + + where 'clockid' is the clock type and 'ticks' is the number of the timer expirations + that have occurred [see timerfd_create(2) for details]. 'settime flags' are + flags in octal form been used to setup the timer [see timerfd_settime(2) for + details]. 'it_value' is remaining time until the timer exiration. + 'it_interval' is the interval for the timer. Note the timer might be set up + with TIMER_ABSTIME option which will be shown in 'settime flags', but 'it_value' + still exhibits timer's remaining time. ------------------------------------------------------------------------------ Configuring procfs
PATCH 3/4 timerfd: Implement timerfd_ioctl method to restore timerfd_ctx::ticks
In reply to Cyrill GorcunovThe read() of timerfd files allows to fetch the number of timer ticks while there is no way to set it back from userspace.
To restore the timer's state as it was at checkpoint moment we need a path to bring @ticks back. Initially I thought about writing ticks back via write() interface but it seems such API is somehow obscure.
Instead implement timerfd_ioctl() method with TFD_IOC_SET_TICKS command which allows to adjust @ticks into non-zero value waking up the waiters. The reason to forbid from
I wrapped code with CONFIG_CHECKPOINT_RESTORE which can be dropped off if there users except c/r camp appear.
--- fs/timerfd.c | 37 +++++++++++++++++++++++++++++++++++++ include/linux/timerfd.h | 5 +++++ 2 files changed, 42 insertions(+)
fs/timerfd.c +37 -0
@@ -313,11 +313,48 @@ static int timerfd_show(struct seq_file }#endif +#ifdef CONFIG_CHECKPOINT_RESTORE +static long timerfd_ioctl (struct file *file,unsigned int cmd,unsigned long arg) +{ +struct timerfd_ctx *ctx = file->private_data; +int ret =0 ; + +switch (cmd) { +case TFD_IOC_SET_TICKS : { +u64 ticks; + +if (get_user (ticks, (u64 __user *)arg)) +return -EFAULT ; +if (!ticks) +return -EINVAL ; + +spin_lock_irq (&ctx->wqh.lock); +if (!timerfd_canceled (ctx)) { + ctx->ticks = ticks; +if (ticks) +wake_up_locked (&ctx->wqh); + }else + ret = -ECANCELED ; +spin_unlock_irq (&ctx->wqh.lock); +break ; + } +default : + ret = -ENOTTY ; +break ; + } + +return ret; +} +#endif +static const struct file_operations timerfd_fops = { .release = timerfd_release, .poll = timerfd_poll, .read = timerfd_read, .llseek = noop_llseek, +#ifdef CONFIG_CHECKPOINT_RESTORE + .unlocked_ioctl = timerfd_ioctl, +#endif #ifdef CONFIG_PROC_FS .show_fdinfo = timerfd_show, #endif
include/linux/timerfd.h +5 -0
@@ -11,6 +11,9 @@/* For O_CLOEXEC and O_NONBLOCK */ #include <linux/fcntl.h> +/* For _IO helpers */ +#include <linux/ioctl.h> +/* * CAREFUL: Check include/asm-generic/fcntl.h when defining * new flags, since they might collide with O_* ones. We want
@@ -29,4 +32,6 @@/* Flags for timerfd_settime. */ #define TFD_SETTIME_FLAGS (TFD_TIMER_ABSTIME | TFD_TIMER_CANCEL_ON_SET) +#define TFD_IOC_SET_TICKS _IOW('T', 0, u64) +#endif /* _LINUX_TIMERFD_H */
PATCH 3/4 timerfd: Implement timerfd_ioctl method to restore timerfd_ctx::ticks
The read() of timerfd files allows to fetch the number of timer ticks while there is no way to set it back from userspace.
To restore the timer's state as it was at checkpoint moment we need a path to bring @ticks back. Initially I thought about writing ticks back via write() interface but it seems such API is somehow obscure.
Instead implement timerfd_ioctl() method with TFD_IOC_SET_TICKS command which allows to adjust @ticks into non-zero value waking up the waiters.
I wrapped code with CONFIG_CHECKPOINT_RESTORE which can be dropped off if there users except c/r camp appear.
v2 (by akpm@):
-Use define timerfd_ioctl NULL for non c/r config
---
A nit fixed for for non c/r config in timerfd_ioctl declaration
fs/timerfd.c | 37 +++++++++++++++++++++++++++++++++++++ include/linux/timerfd.h | 5 +++++ 2 files changed, 42 insertions(+)
fs/timerfd.c +37 -0
@@ -315,12 +315,49 @@ static int timerfd_show(struct seq_file#define timerfd_show NULL#endif +#ifdef CONFIG_CHECKPOINT_RESTORE +static long timerfd_ioctl (struct file *file,unsigned int cmd,unsigned long arg) +{ +struct timerfd_ctx *ctx = file->private_data; +int ret =0 ; + +switch (cmd) { +case TFD_IOC_SET_TICKS : { +u64 ticks; + +if (get_user (ticks, (u64 __user *)arg)) +return -EFAULT ; +if (!ticks) +return -EINVAL ; + +spin_lock_irq (&ctx->wqh.lock); +if (!timerfd_canceled (ctx)) { + ctx->ticks = ticks; +if (ticks) +wake_up_locked (&ctx->wqh); + }else + ret = -ECANCELED ; +spin_unlock_irq (&ctx->wqh.lock); +break ; + } +default : + ret = -ENOTTY ; +break ; + } + +return ret; +} +#else +#define timerfd_ioctl NULL +#endif +static const struct file_operations timerfd_fops = { .release = timerfd_release, .poll = timerfd_poll, .read = timerfd_read, .llseek = noop_llseek, .show_fdinfo = timerfd_show, + .unlocked_ioctl = timerfd_ioctl, };static int timerfd_fget (int fd,struct fd *p)
include/linux/timerfd.h +5 -0
@@ -11,6 +11,9 @@/* For O_CLOEXEC and O_NONBLOCK */ #include <linux/fcntl.h> +/* For _IO helpers */ +#include <linux/ioctl.h> +/* * CAREFUL: Check include/asm-generic/fcntl.h when defining * new flags, since they might collide with O_* ones. We want
@@ -29,4 +32,6 @@/* Flags for timerfd_settime. */ #define TFD_SETTIME_FLAGS (TFD_TIMER_ABSTIME | TFD_TIMER_CANCEL_ON_SET) +#define TFD_IOC_SET_TICKS _IOW('T', 0, u64) +#endif /* _LINUX_TIMERFD_H */
Re: [patch 3/4] timerfd: Implement timerfd_ioctl method to restore timerfd_ctx::ticks
Hi Cyrill,
Quoted 40 lines · Cyrill Gorcunov
The
read()of timerfd files allows to fetch the number of timer ticks while there is no way to set it back from userspace.To restore the timer's state as it was at checkpoint moment we need a path to bring @ticks back. Initially I thought about writing ticks back via
write()interface but it seems such API is somehow obscure.Instead implement
timerfd_ioctl()method withTFD_IOC_SET_TICKScommand which allows to adjust @ticks into non-zero value waking up the waiters.I wrapped code with
CONFIG_CHECKPOINT_RESTOREwhich can be dropped off if there users except c/r camp appear.v2 (by akpm@):
-Use definetimerfd_ioctlNULL for non c/r configCC Thomas Gleixner <[email protected]>CC Andrew Morton <[email protected]>CC Andrey Vagin <[email protected]>CC Pavel Emelyanov <[email protected]>CC Vladimir Davydov <[email protected]>Signed-off-by Cyrill Gorcunov <[email protected]>---
A nit fixed for for non c/r config in
timerfd_ioctldeclarationfs/timerfd.c | 37 +++++++++++++++++++++++++++++++++++++ include/linux/timerfd.h | 5 +++++ 2 files changed, 42 insertions(+)Index:
linux-2.6.git/fs/timerfd.c
===================================================================fs/timerfd.c +1
-0@@ -315,12 +315,49 @@ static int timerfd_show(struct seq_file#define timerfd_show NULL#endif +#ifdef CONFIG_CHECKPOINT_RESTORE
fs/timerfd.c static int timerfd_show(struct seq_file · line 328
Quoted 10 lines
fs/timerfd.c +10
-0+static long timerfd_ioctl (struct file *file,unsigned int cmd,unsigned long arg) +{ +struct timerfd_ctx *ctx = file->private_data; +int ret =0 ; + +switch (cmd) { +case TFD_IOC_SET_TICKS : { +u64 ticks; + +if (get_user (ticks, (u64 __user *)arg))
64-bit get_user is currently unsupported on ARM, although it appears work is ongoing [1].
1. https://lkml.org/lkml/2014/6/17/260
Regards,
Christopher
Signature · 3 lines
Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation.
Re: [patch 3/4] timerfd: Implement timerfd_ioctl method to restore timerfd_ctx::ticks
Quoted 16 lines · Christopher Covington
fs/timerfd.c static int timerfd_show(struct seq_file · line 328
Quoted 12 lines
fs/timerfd.c +11
-0+#ifdef CONFIG_CHECKPOINT_RESTORE +static long timerfd_ioctl (struct file *file,unsigned int cmd,unsigned long arg) +{ +struct timerfd_ctx *ctx = file->private_data; +int ret =0 ; + +switch (cmd) { +case TFD_IOC_SET_TICKS : { +u64 ticks; + +if (get_user (ticks, (u64 __user *)arg))64-bit
get_useris currently unsupported on ARM, although it appears work is ongoing [1].
Quoted 1 line
Thanks for info, Christopher! What arm camp is using then, copy-from-user?
Re: [patch 3/4] timerfd: Implement timerfd_ioctl method to restore timerfd_ctx::ticks
Quoted 17 lines · On Wednesday 02 July 2014 21:04:16 Cyrill Gorcunov wrote:
Quoted 16 lines · Christopher Covington
fs/timerfd.c static int timerfd_show(struct seq_file · line 328
Quoted 12 lines
fs/timerfd.c +11
-0+#ifdef CONFIG_CHECKPOINT_RESTORE +static long timerfd_ioctl (struct file *file,unsigned int cmd,unsigned long arg) +{ +struct timerfd_ctx *ctx = file->private_data; +int ret =0 ; + +switch (cmd) { +case TFD_IOC_SET_TICKS : { +u64 ticks; + +if (get_user (ticks, (u64 __user *)arg))64-bit
get_useris currently unsupported on ARM, although it appears work is ongoing [1].
Quoted 4 lines
Quoted 1 line
Thanks for info, Christopher! What arm camp is using then, copy-from-user?
copy_from_user should work on all architectures. I believe a 64-bit get_user is currently unsupported on most 32-bit architectures, x86-32 being a notable exception.
Arnd
Re: [patch 3/4] timerfd: Implement timerfd_ioctl method to restore timerfd_ctx::ticks
Quoted 4 lines · Arnd Bergmann
Quoted 4 lines
Quoted 4 lines
64-bit
get_useris currently unsupported on ARM, although it appears work is ongoing [1].
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Thanks for info, Christopher! What arm camp is using then, copy-from-user?
copy_from_usershould work on all architectures. I believe a 64-bitget_useris currently unsupported on most 32-bit architectures, x86-32 being a notable exception.
Thanks, I'll update.
Re: [patch 3/4] timerfd: Implement timerfd_ioctl method to restore timerfd_ctx::ticks
In reply to Arnd BergmannUpdated variant, thanks a lot for feedback!
---
From: Cyrill Gorcunov <[email protected]>
Subject: timerfd: Implement timerfd_ioctl method to restore timerfd_ctx::ticks, v3
The read() of timerfd files allows to fetch the number of timer ticks while there is no way to set it back from userspace.
To restore the timer's state as it was at checkpoint moment we need a path to bring @ticks back. Initially I thought about writing ticks back via write() interface but it seems such API is somehow obscure.
Instead implement timerfd_ioctl() method with TFD_IOC_SET_TICKS command which allows to adjust @ticks into non-zero value waking up the waiters.
I wrapped code with CONFIG_CHECKPOINT_RESTORE which can be dropped off if there users except c/r camp appear.
v2 (by akpm@):
- Use define timerfd_ioctl NULL for non c/r config
v3:
- Use copy_from_user for @ticks fetching since not all arch support get_user for 8 byte argument
--- fs/timerfd.c | 37 +++++++++++++++++++++++++++++++++++++ include/linux/timerfd.h | 5 +++++ 2 files changed, 42 insertions(+)
fs/timerfd.c +37 -0
@@ -315,12 +315,49 @@ static int timerfd_show(struct seq_file#define timerfd_show NULL#endif +#ifdef CONFIG_CHECKPOINT_RESTORE +static long timerfd_ioctl (struct file *file,unsigned int cmd,unsigned long arg) +{ +struct timerfd_ctx *ctx = file->private_data; +int ret =0 ; + +switch (cmd) { +case TFD_IOC_SET_TICKS : { +u64 ticks; + +if (copy_from_user (&ticks, (u64 __user *)arg,sizeof (ticks))) +return -EFAULT ; +if (!ticks) +return -EINVAL ; + +spin_lock_irq (&ctx->wqh.lock); +if (!timerfd_canceled (ctx)) { + ctx->ticks = ticks; +if (ticks) +wake_up_locked (&ctx->wqh); + }else + ret = -ECANCELED ; +spin_unlock_irq (&ctx->wqh.lock); +break ; + } +default : + ret = -ENOTTY ; +break ; + } + +return ret; +} +#else +#define timerfd_ioctl NULL +#endif +static const struct file_operations timerfd_fops = { .release = timerfd_release, .poll = timerfd_poll, .read = timerfd_read, .llseek = noop_llseek, .show_fdinfo = timerfd_show, + .unlocked_ioctl = timerfd_ioctl, };static int timerfd_fget (int fd,struct fd *p)
include/linux/timerfd.h +5 -0
@@ -11,6 +11,9 @@/* For O_CLOEXEC and O_NONBLOCK */ #include <linux/fcntl.h> +/* For _IO helpers */ +#include <linux/ioctl.h> +/* * CAREFUL: Check include/asm-generic/fcntl.h when defining * new flags, since they might collide with O_* ones. We want
@@ -29,4 +32,6 @@/* Flags for timerfd_settime. */ #define TFD_SETTIME_FLAGS (TFD_TIMER_ABSTIME | TFD_TIMER_CANCEL_ON_SET) +#define TFD_IOC_SET_TICKS _IOW('T', 0, u64) +#endif /* _LINUX_TIMERFD_H */
PATCH 4/4 timerfd.2: Add ioctl method description
In reply to Cyrill Gorcunovioctl(2)
The following commands are supported: TFD_IOC_SET_TICKS to adjust the number of the timer expirations that have occurred. It take a pointer to nonzero 8-byte integer (uint64_t*) containing new number of expirations. Once the number is set any waiter on the timer is woken up. The only purpose of this command is to restore the expirations in a sake of checkpoint/restore procedure. It requires the kernel to be built with CONFIG_CHECKPOINT_RESTORE support.
--- man2/timerfd_create.2 | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
man2/timerfd_create.2 +14 -0
@@ -260,6 +260,20 @@ multiplexing APIs: and .BR epoll (7). .TP +.BR ioctl "(2)" +The following commands are supported: +.B TFD_IOC_SET_TICKS +to adjust the number of the timer expirations that have occurred. +It take a pointer to nonzero 8-byte integer +.RI ( uint64_t *) +containing the new number of expirations. +Once the number is set any waiter on the timer is woken up. +The only purpose of this command is to restore the expirations +in a sake of checkpoint/restore procedure. +It requires the kernel to be built with +.BR CONFIG_CHECKPOINT_RESTORE +support. +.TP .BR close (2) When the file descriptor is no longer required it should be closed. When all file descriptors associated with the same timer object
Quoted 8 lines · Cyrill Gorcunov
Hi guys, here is an updated version of c/r support for timerfd files. The main change is in how @ticks are restored in patch 3 -- I switched to ioctl code, which is wrapped with CONFIG because I still think that while there is only one ioctl designated solely for c/r needs no need to build it all the time until explicitly requested. Please take a look once time permit. Comments are highly appreciated. Also note the last patch is for man-page git repo, not for kernel.
Thanks!
Quoted 7 lines · Cyrill Gorcunov
Hi guys, here is an updated version of c/r support for timerfd files. The main change is in how @ticks are restored in patch 3 -- I switched to ioctl code, which is wrapped with CONFIG because I still think that while there is only one ioctl designated solely for c/r needs no need to build it all the time until explicitly requested. Please take a look once time permit. Comments are highly appreciated. Also note the last patch is for man-page git repo, not for kernel.
Gentlemen, could you please point me if there something preventing the series from being picked up? Or there some way to improve the series?
Quoted 11 lines · Cyrill Gorcunov
Quoted 7 lines · Cyrill Gorcunov
Hi guys, here is an updated version of c/r support for timerfd files. The main change is in how @ticks are restored in patch 3 -- I switched to ioctl code, which is wrapped with CONFIG because I still think that while there is only one ioctl designated solely for c/r needs no need to build it all the time until explicitly requested. Please take a look once time permit. Comments are highly appreciated. Also note the last patch is for man-page git repo, not for kernel.
Gentlemen, could you please point me if there something preventing the series from being picked up? Or there some way to improve the series?
Dear sirs, ping?
Quoted 10 lines · Cyrill Gorcunov
Quoted 9 lines · Cyrill Gorcunov
Quoted 7 lines · Cyrill Gorcunov
Hi guys, here is an updated version of c/r support for timerfd files. The main change is in how @ticks are restored in patch 3 -- I switched to ioctl code, which is wrapped with CONFIG because I still think that while there is only one ioctl designated solely for c/r needs no need to build it all the time until explicitly requested. Please take a look once time permit. Comments are highly appreciated. Also note the last patch is for man-page git repo, not for kernel.
Quoted 4 lines
Quoted 2 lines
Gentlemen, could you please point me if there something preventing the series from being picked up? Or there some way to improve the series?
Dear sirs, ping?
Hmm, I was waiting for a V5, but it seems you just updated that single patch according to the review. I'll pick it up
Quoted 5 lines · Thomas Gleixner
Quoted 2 lines
Dear sirs, ping?
Hmm, I was waiting for a V5, but it seems you just updated that single patch according to the review. I'll pick it up
Thanks a lot, Thomas!
Quoted 8 lines · Cyrill Gorcunov
Quoted 5 lines · Thomas Gleixner
Quoted 2 lines
Dear sirs, ping?
Hmm, I was waiting for a V5, but it seems you just updated that single patch according to the review. I'll pick it up
Thanks a lot, Thomas!
Sigh. That updated 3/4 patch does not even apply....
Quoted 4 lines · Thomas Gleixner
Quoted 2 lines · Cyrill Gorcunov
Quoted 1 line · Thomas Gleixner
Quoted 1 line
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Dear sirs, ping?
Hmm, I was waiting for a V5, but it seems you just updated that single patch according to the review. I'll pick it up
Thanks a lot, Thomas!
Sigh. That updated 3/4 patch does not even apply....
Maybe it's because of new -rc? Letme check...
Quoted 7 lines · Cyrill Gorcunov
Quoted 6 lines · Thomas Gleixner
Quoted 4 lines · Cyrill Gorcunov
Quoted 3 lines · Thomas Gleixner
Quoted 2 lines
Dear sirs, ping?
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Hmm, I was waiting for a V5, but it seems you just updated that single patch according to the review. I'll pick it up
Thanks a lot, Thomas!
Sigh. That updated 3/4 patch does not even apply....
Maybe it's because of new -rc? Letme check...
No, it's because its against an older version of your patches which lack the #ifdef PROC_FS around the show function ....
Quoted 5 lines · Thomas Gleixner
Quoted 2 lines
Maybe it's because of new -rc? Letme check...
No, it's because its against an older version of your patches which lack the #ifdef
PROC_FSaround the show function ....
Crap. Sorry. Thomas, I'm fetching -rc5 now, I suppose better will be if I rebase the whole series and resend. Sounds good?
Quoted 9 lines · Cyrill Gorcunov
Quoted 5 lines · Thomas Gleixner
Quoted 2 lines
Maybe it's because of new -rc? Letme check...
No, it's because its against an older version of your patches which lack the #ifdef
PROC_FSaround the show function ....Crap. Sorry. Thomas, I'm fetching -rc5 now, I suppose better will be if I rebase the whole series and resend. Sounds good?
No rebase necessary. 1&2 apply fine. It's home made wreckage :)