mfd: arizona: Add comment to explain non-devm regulator_get
Subsystems (2)
PATCH 1/1 mfd: arizona: Add comment to explain non-devm regulator_get
To avoid someone attempting to change this regulator_get back into a devm_regulator_get put a comment in explaining that devres can't be used here as the regulator will be destroyed before devres calls regulator_put.
Signed-off-by Charles Keepax <[email protected]>
--- drivers/mfd/arizona-core.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/mfd/arizona-core.c +6 -0
@@ -683,6 +683,12 @@ int arizona_dev_init(struct arizona *arizona) goto err_early; } +/** +* Don't use devres here because the only device we have to get +* against is the MFD device and DCVDD will likely be supplied by +* one of its children. Meaning that the regulator will be +* destroyed by the time devres calls regulator put. +*/ arizona->dcvdd =regulator_get (arizona->dev,"DCVDD" );if (IS_ERR (arizona->dcvdd)) { ret =PTR_ERR (arizona->dcvdd);
Signature · 1 line
1.7.2.5
Lee Jones
AppliedQuoted 9 lines
To avoid someone attempting to change this
regulator_getback into adevm_regulator_getput a comment in explaining that devres can't be used here as the regulator will be destroyed before devres callsregulator_put.Signed-off-by Charles Keepax <[email protected]>--- drivers/mfd/arizona-core.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
Applied, thanks.
Quoted 17 lines
drivers/mfd/arizona-core.c +6
-0@@ -683,6 +683,12 @@ int arizona_dev_init(struct arizona *arizona) goto err_early; } +/** +* Don't use devres here because the only device we have to get +* against is the MFD device and DCVDD will likely be supplied by +* one of its children. Meaning that the regulator will be +* destroyed by the time devres calls regulator put. +*/ arizona->dcvdd =regulator_get (arizona->dev,"DCVDD" );if (IS_ERR (arizona->dcvdd)) { ret =PTR_ERR (arizona->dcvdd);
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog