perf/urgent fixes
Jiri Olsa
reviewerhi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit cf230918cda19532e4a5cc4f0d5c82fa7e5e94f6:
Merge branch 'perf/core' into perf/urgent, to pick up the latest fixes (2014-06-14 14:10:08 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-urgent-for-mingo
for you to fetch changes up to a93f0e551af9e194db38bfe16001e17a3a1d189a:
perf symbols: Get kernel start address by symbol name (2014-06-20 09:34:22 +0200)
----------------------------------------------------------------
perf/urgent fixes:
. Fix kernel start address lookup in report code (Simon Que)
. Fix segfault in cumulative.callchain report (Jiri Olsa)
----------------------------------------------------------------
Jiri Olsa (1):
perf tools: Fix segfault in cumulative.callchain report
Simon Que (1):
perf symbols: Get kernel start address by symbol name
tools/perf/ui/browsers/hists.c | 21 ++++++++++++---- tools/perf/util/machine.c | 54 +++++++++++++++++------------------------- 2 files changed, 38 insertions(+), 37 deletions(-)
Jiri Olsa
reviewerPATCH 1/2 perf tools: Fix segfault in cumulative.callchain report
When cumulative callchain mode is on, we could get samples with with no actual hits. This breaks the assumption of the annotation code, that each sample has annotation counts allocated and leads to segfault.
Fixing this by additional checks for annotation stats.
--- tools/perf/ui/browsers/hists.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-)
tools/perf/ui/browsers/hists.c +16 -5
@@ -17,6 +17,7 @@#include "../util.h" #include "../ui.h" #include "map.h" +#include "annotate.h" struct hist_browser {struct ui_browser b;
@@ -1593,13 +1594,18 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, bi->to.sym->name) > 0) annotate_t = nr_options++; }else { -if (browser->selection !=NULL && browser->selection->sym !=NULL && - !browser->selection->map->dso->annotate_warned && -asprintf (&options[nr_options],"Annotate %s" , - browser->selection->sym->name) >0 ) - annotate = nr_options++; + !browser->selection->map->dso->annotate_warned) { +struct annotation *notes; + + notes =symbol__annotation (browser->selection->sym); + +if (notes->src && +asprintf (&options[nr_options],"Annotate %s" , + browser->selection->sym->name) >0 ) + annotate = nr_options++; + } } if (thread != NULL &&
@@ -1656,6 +1662,7 @@ retry_popup_menu:if (choice == annotate || choice == annotate_t || choice == annotate_f) {struct hist_entry *he; +struct annotation *notes;int err; do_annotate:if (!objdump_path &&perf_session_env__lookup_objdump (env))
@@ -1679,6 +1686,10 @@ do_annotate: he->ms.map = he->branch_info->to.map; } + notes =symbol__annotation (he->ms.sym); +if (!notes->src) +continue ; +/* * Don't let this be freed, say, by hists__decay_entry. */
Signature · 1 line
1.8.3.1
Jiri Olsa
reviewerPATCH 2/2 perf symbols: Get kernel start address by symbol name
In reply to Jiri OlsaFrom: Simon Que <[email protected]>
The function machine__get_kernel_start_addr() was taking the first symbol of kallsyms as the start address. This is incorrect in certain cases where the first symbol is something at 0, while the actual kernel functions begin at a later point (e.g. 0x80200000).
This patch fixes machine__get_kernel_start_addr() to search for the symbol "_text" or "_stext", which marks the beginning of kernel mapping. This was already being done in machine__create_kernel_maps(). Thus, this patch is just a refactor, to move that code into machine__get_kernel_start_addr().
--- tools/perf/util/machine.c | 54 +++++++++++++++++++---------------------------- 1 file changed, 22 insertions(+), 32 deletions(-)
tools/perf/util/machine.c +22 -32
@@ -496,18 +496,6 @@ struct process_args {u64 start; }; -static int symbol__in_kernel (void *arg,const char *name, -char type__maybe_unused ,u64 start) -{ -struct process_args *args = arg; - -if (strchr (name,'[' )) -return 0 ; - - args->start = start; -return 1 ; -} -static void machine__get_kallsyms_filename (struct machine *machine,char *buf,size_t bufsz) {
@@ -517,27 +505,41 @@ static void machine__get_kallsyms_filename(struct machine *machine, char *buf,scnprintf (buf, bufsz,"%s/proc/kallsyms" , machine->root_dir); } -/* Figure out the start address of kernel map from /proc/kallsyms */ -static u64 machine__get_kernel_start_addr (struct machine *machine) +const char *ref_reloc_sym_names[] = {"_text" ,"_stext" ,NULL }; + +/* Figure out the start address of kernel map from /proc/kallsyms. +* Returns the name of the start symbol in *symbol_name. Pass in NULL as +* symbol_name if it's not that important. +*/ +static u64 machine__get_kernel_start_addr (struct machine *machine, +const char **symbol_name) {char filename[PATH_MAX ]; -struct process_args args; +int i; +const char *name; +u64 addr =0 ;machine__get_kallsyms_filename (machine, filename,PATH_MAX );if (symbol__restricted_filename (filename,"/proc/kallsyms" ))return 0 ; -if (kallsyms__parse (filename, &args, symbol__in_kernel) <=0 ) -return 0 ; +for (i =0 ; (name = ref_reloc_sym_names[i]) !=NULL ; i++) { + addr =kallsyms__get_function_start (filename, name); +if (addr) +break ; + } + +if (symbol_name) + *symbol_name = name; -return args.start; +return addr; }int __machine__create_kernel_maps (struct machine *machine,struct dso *kernel) {enum map_type type; -u64 start =machine__get_kernel_start_addr (machine); +u64 start =machine__get_kernel_start_addr (machine,NULL );for (type =0 ; type <MAP__NR_TYPES ; ++type) {struct kmap *kmap;
@@ -852,23 +854,11 @@ static int machine__create_modules(struct machine *machine)return 0 ; } -const char *ref_reloc_sym_names[] = {"_text" ,"_stext" ,NULL }; -int machine__create_kernel_maps (struct machine *machine) {struct dso *kernel =machine__get_kernel (machine); -char filename[PATH_MAX ];const char *name; -u64 addr =0 ; -int i; - -machine__get_kallsyms_filename (machine, filename,PATH_MAX ); - -for (i =0 ; (name = ref_reloc_sym_names[i]) !=NULL ; i++) { - addr =kallsyms__get_function_start (filename, name); -if (addr) -break ; - } +u64 addr =machine__get_kernel_start_addr (machine, &name);if (!addr)return -1 ;
Signature · 1 line
1.8.3.1
Quoted 33 lines · Jiri Olsa
hi Ingo,
please consider pullingthanks,
jirkaThe following changes since commit
cf230918cda19532e4a5cc4f0d5c82fa7e5e94f6:Merge branch 'perf/core' into perf/urgent, to pick up the latest fixes (2014-06-14 14:10:08 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.gittags/perf-urgent-for-mingofor you to fetch changes up to
a93f0e551af9e194db38bfe16001e17a3a1d189a:perf symbols: Get kernel start address by symbol name (2014-06-20 09:34:22 +0200)
----------------------------------------------------------------
perf/urgent fixes:. Fix kernel start address lookup in report code (Simon Que)
. Fix segfault in cumulative.callchain report (Jiri Olsa)
Signed-off-by Jiri Olsa <[email protected]>----------------------------------------------------------------
Jiri Olsa (1):
perf tools: Fix segfault in cumulative.callchain report
Quoted 6 lines
Simon Que (1):
perf symbols: Get kernel start address by symbol nametools/perf/ui/browsers/hists.c | 21 ++++++++++++---- tools/perf/util/machine.c | 54 +++++++++++++++++------------------------- 2 files changed, 38 insertions(+), 37 deletions(-)
Pulled, thanks a lot Jiri!
Ingo