Skip to contentSkip to conversation

vmsplice.2: vmsplice() does not fail on nr_segs=0

PATCH In review Cyril Hrubis 3 participants 5 messages Jun 25, 2014 – Oct 1, 2014 2 messages not in the archive Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore

Cyril Hrubis

author
#0 lore raw

PATCH 1/1 vmsplice.2: vmsplice() does not fail on nr_segs=0

This case is no-op and no error is returned.

See fs/splice.c vmsplice syscall which contains:

if (unlikely(nr_segs > UIO_MAXIOV))
return -EINVAL;
else if (unlikely(!nr_segs))
return 0;

and looking at the git log suggests that this snipped was always there.

Signed-off-by Cyril Hrubis <[email protected]>
---
 man2/vmsplice.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man2/vmsplice.2 +1 -1
index 35ab07f..a9ad786 100644
@@ -133,7 +133,7 @@ either not valid, or doesn't refer to a pipe.
 .TP
 .B EINVAL
 .I nr_segs
-is 0 or greater than
+is greater than
 .BR IOV_MAX ;
 or memory not aligned if
 .B SPLICE_F_GIFT
Signature · 10 lines
1.8.5.5


-- 
Cyril Hrubis
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi!

Quoted 10 lines

This case is no-op and no error is returned.

See fs/splice.c vmsplice syscall which contains:

if (unlikely(nr_segs > UIO_MAXIOV))
return -EINVAL;
else if (unlikely(!nr_segs))
return 0;

and looking at the git log suggests that this snipped was always there.

Ping?

Signature · 6 lines
Cyril Hrubis
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
In reply to a message not in the archive

Hi!

Quoted 21 lines

This case is no-op and no error is returned.

See fs/splice.c vmsplice syscall which contains:

if (unlikely(nr_segs > UIO_MAXIOV))
return -EINVAL;
else if (unlikely(!nr_segs))
return 0;

and looking at the git log suggests that this snipped was always there.

Signed-off-by Cyril Hrubis <[email protected]>
---
 man2/vmsplice.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man2/vmsplice.2 +0 -0
index 35ab07f..a9ad786 100644

man2/vmsplice.2 either not valid, or doesn't refer to a pipe. · line 139

Quoted 8 lines
man2/vmsplice.2 +1 -1
@@ -133,7 +133,7 @@ either not valid, or doesn't refer to a pipe.
 .TP
 .B EINVAL
 .I nr_segs
-is 0 or greater than
+is greater than
 .BR IOV_MAX ;
 or memory not aligned if
 .B SPLICE_F_GIFT

Ping.

Signature · 6 lines
Cyril Hrubis
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20140826084242.GA25225-J5syqNJeCN7twjQa/[email protected]

#5 lore raw

Ping?

Quoted 29 lines
Quoted 29 lines

This case is no-op and no error is returned.

See fs/splice.c vmsplice syscall which contains:

if (unlikely(nr_segs > UIO_MAXIOV))
return -EINVAL;
else if (unlikely(!nr_segs))
return 0;

and looking at the git log suggests that this snipped was always there.

Signed-off-by Cyril Hrubis <[email protected]>
---
 man2/vmsplice.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man2/vmsplice.2 +1 -1
index 35ab07f..a9ad786 100644
@@ -133,7 +133,7 @@ either not valid, or doesn't refer to a pipe.
 .TP
 .B EINVAL
 .I nr_segs
-is 0 or greater than
+is greater than
 .BR IOV_MAX ;
 or memory not aligned if
 .B SPLICE_F_GIFT
Signature · 6 lines
Cyril Hrubis
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#6 lore raw
In reply to a message not in the archive
Quoted 10 lines · Cyril Hrubis

This case is no-op and no error is returned.

See fs/splice.c vmsplice syscall which contains:

if (unlikely(nr_segs > UIO_MAXIOV))
return -EINVAL;
else if (unlikely(!nr_segs))
return 0;

and looking at the git log suggests that this snipped was always there.

Apologies for the delay, Cyril (and thanks for pinging). I've applied this patch now.

Cheers,

Michael

Quoted 19 lines
Signed-off-by Cyril Hrubis <[email protected]>
---
 man2/vmsplice.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man2/vmsplice.2 +1 -1
index 35ab07f..a9ad786 100644
@@ -133,7 +133,7 @@ either not valid, or doesn't refer to a pipe.
 .TP
 .B EINVAL
 .I nr_segs
-is 0 or greater than
+is greater than
 .BR IOV_MAX ;
 or memory not aligned if
 .B SPLICE_F_GIFT
Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html