ARM: imx: add cpufreq support for i.mx6sx

PATCH New Anson Huang 5 participants 14 messages Jun 25, 2014 – Aug 18, 2014

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape

lore

Share & tools

lore

Anson Huang

author

2014-06-25 09:10 UTC #0 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

Add cpufreq support for i.MX6SX, using common
i.MX6Q cpufreq driver.

Signed-off-by Anson Huang <[email protected]>

---
 arch/arm/mach-imx/mach-imx6sx.c |    3 +++
 1 file changed, 3 insertions(+)

arch/arm/mach-imx/mach-imx6sx.c +3 -0

index 74ff7d6..9221e1d 100644
@@ -42,6 +42,9 @@ static void __init imx6sx_init_irq(void)
 static void __init imx6sx_init_late(void)
 {
 	imx6q_cpuidle_init();
+
+	if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ))
+		platform_device_register_simple("imx6q-cpufreq", -1, NULL, 0);
 }
 
 static const char *imx6sx_dt_compat[] __initconst = {

Signature · 1 line

1.7.9.5

Viresh Kumar

2014-06-25 09:33 UTC #1 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

Quoted 13 lines · Anson Huang

Add cpufreq support for i.MX6SX, using common
i.MX6Q cpufreq driver.
Signed-off-by Anson Huang <[email protected]>
---
 arch/arm/mach-imx/mach-imx6sx.c |    3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/mach-imx6sx.c +0 -0
index 74ff7d6..9221e1d 100644

arch/arm/mach-imx/mach-imx6sx.c static void __init imx6sx_init_irq(void) · line 48

Quoted 7 lines

arch/arm/mach-imx/mach-imx6sx.c +3 -0

@@ -42,6 +42,9 @@ static void __init imx6sx_init_irq(void)
 static void __init imx6sx_init_late(void)
 {
        imx6q_cpuidle_init();
+
+       if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ))
+               platform_device_register_simple("imx6q-cpufreq", -1, NULL, 0);
 }

Acked-by Viresh Kumar <[email protected]>

Shawn Guo

Applied

2014-06-25 16:14 UTC #2 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

In reply to Anson Huang

Quoted 4 lines · Anson Huang

Add cpufreq support for i.MX6SX, using common
i.MX6Q cpufreq driver.
Signed-off-by Anson Huang <[email protected]>

Applied, thanks.

Fabio Estevam

reviewer

2014-06-26 01:23 UTC #3 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

In reply to Anson Huang

Hi Anson,

Quoted 13 lines · Anson Huang

Add cpufreq support for i.MX6SX, using common
i.MX6Q cpufreq driver.
Signed-off-by Anson Huang <[email protected]>
---
 arch/arm/mach-imx/mach-imx6sx.c |    3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/mach-imx6sx.c +0 -0
index 74ff7d6..9221e1d 100644

arch/arm/mach-imx/mach-imx6sx.c static void __init imx6sx_init_irq(void) · line 48

Quoted 7 lines

arch/arm/mach-imx/mach-imx6sx.c +3 -0

@@ -42,6 +42,9 @@ static void __init imx6sx_init_irq(void)
 static void __init imx6sx_init_late(void)
 {
        imx6q_cpuidle_init();
+
+       if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ))
+               platform_device_register_simple("imx6q-cpufreq", -1, NULL, 0);
 }

With this patch applied I get a flood of these messages:

cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22

Any suggestions?

Fabio Estevam

reviewer

2014-06-26 01:55 UTC #4 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

Quoted 10 lines · Fabio Estevam

With this patch applied I get a flood of these messages:
cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22
Any suggestions?

Ok, I managed to fix it. Will send the patch soon.

Anson.Huang at freescale.com

2014-06-26 02:53 UTC #5 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

In reply to Fabio Estevam

Hi, Fabio
I have already sent cpufreq driver patch for review which is supporting i.MX6SX, you may need to add it by yourself if you want to test it, I attached the patch, hope it helps.

Best Regards.
Anson Huang
?
Freescale Semiconductor Shanghai
Tel:021-28937058

Quoted 33 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: Thursday, June 26, 2014 9:23 AM
To: Huang Yongcai-B20788
Cc: Guo Shawn-R65073; Sascha Hauer; Russell King; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH V2] ARM: imx: add cpufreq support for i.mx6sx
Hi Anson,
Quoted 12 lines · Anson Huang
Add cpufreq support for i.MX6SX, using common i.MX6Q cpufreq driver.
Signed-off-by Anson Huang <[email protected]>
---
 arch/arm/mach-imx/mach-imx6sx.c |    3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0
b/arch/arm/mach-imx/mach-imx6sx.c index 74ff7d6..9221e1d 100644
arch/arm/mach-imx/mach-imx6sx.c static void __init imx6sx_init_irq(void) static · line 48
Quoted 7 lines
arch/arm/mach-imx/mach-imx6sx.c +4 -0
@@ -42,6 +42,9 @@ static void __init imx6sx_init_irq(void)  static
 void __init imx6sx_init_late(void)  {
        imx6q_cpuidle_init();
+
+       if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ))
+               platform_device_register_simple("imx6q-cpufreq", -1,
+ NULL, 0);
 }
With this patch applied I get a flood of these messages:

Quoted 8 lines

cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22
Any suggestions?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cpufreq-imx6-remove-pu-regulator-dependency-for-SOCs.patch
Type: application/octet-stream
Size: 3415 bytes
Desc: 0001-cpufreq-imx6-remove-pu-regulator-dependency-for-SOCs.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140626/d2877930/attachment-0001.obj>

Fabio Estevam

reviewer

2014-06-26 03:06 UTC #6 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

Quoted 2 lines · Anson.Huang at freescale.com

Hi, Fabio
I have already sent cpufreq driver patch for review which is supporting i.MX6SX, you may need to add it by yourself if you want to test it, I attached the patch, hope it helps.

Thanks. It works fine now.

Fabio Estevam

reviewer

2014-06-26 03:11 UTC #7 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

Quoted 6 lines · Fabio Estevam

Quoted 2 lines · Anson.Huang at freescale.com
Hi, Fabio
I have already sent cpufreq driver patch for review which is supporting i.MX6SX, you may need to add it by yourself if you want to test it, I attached the patch, hope it helps.
Thanks. It works fine now.

Forgot to mention that this error still appears:

cpu cpu0: dev_pm_opp_get_opp_count: device OPP not found (-19)

Anson.Huang at freescale.com

2014-06-26 03:15 UTC #8 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

Maybe it is another issue? Do you see it on other platforms? As cpufreq function did work on SX. I will try other platform soon to see whether it is a new issue.

Best Regards.
Anson Huang
?
Freescale Semiconductor Shanghai
Tel:021-28937058

Quoted 21 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: Thursday, June 26, 2014 11:12 AM
To: Huang Yongcai-B20788
Cc: Guo Shawn-R65073; Sascha Hauer; Russell King; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH V2] ARM: imx: add cpufreq support for i.mx6sx
Quoted 4 lines · Fabio Estevam
Quoted 2 lines · Anson.Huang at freescale.com
Hi, Fabio
I have already sent cpufreq driver patch for review which is
supporting i.MX6SX, you may need to add it by yourself if you want to test it, I attached the patch, hope it helps.
Quoted 2 lines
Thanks. It works fine now.
Forgot to mention that this error still appears:
cpu cpu0: dev_pm_opp_get_opp_count: device OPP not found (-19)

Fabio Estevam

reviewer

2014-06-26 03:21 UTC #9 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

Quoted 1 line · Anson.Huang at freescale.com

Maybe it is another issue? Do you see it on other platforms? As cpufreq function did work on SX. I will try other platform soon to see whether it is a new issue.

I see the same error message on mx6sl as well. I am running Shawn's for-next branch.

Thanks

Shawn Guo

2014-06-26 03:21 UTC #10 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

In reply to Fabio Estevam

Quoted 11 lines · Fabio Estevam

Quoted 6 lines · Fabio Estevam
Quoted 2 lines · Anson.Huang at freescale.com
Hi, Fabio
I have already sent cpufreq driver patch for review which is supporting i.MX6SX, you may need to add it by yourself if you want to test it, I attached the patch, hope it helps.
Thanks. It works fine now.
Forgot to mention that this error still appears:
cpu cpu0: dev_pm_opp_get_opp_count: device OPP not found (-19)

The driver checks if platform supplies an OPP table by attempting to call dev_pm_opp_get_opp_count() and check the return. So there is no real issue behind this message.

Shawn

Shawn Guo

2014-06-26 05:54 UTC #11 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

In reply to Fabio Estevam

Quoted 26 lines · Fabio Estevam

Hi Anson,
Quoted 13 lines · Anson Huang
Add cpufreq support for i.MX6SX, using common
i.MX6Q cpufreq driver.
Signed-off-by Anson Huang <[email protected]>
---
 arch/arm/mach-imx/mach-imx6sx.c |    3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/mach-imx6sx.c +0 -0
index 74ff7d6..9221e1d 100644
arch/arm/mach-imx/mach-imx6sx.c static void __init imx6sx_init_irq(void) · line 48
Quoted 7 lines
arch/arm/mach-imx/mach-imx6sx.c +3 -0
@@ -42,6 +42,9 @@ static void __init imx6sx_init_irq(void)
 static void __init imx6sx_init_late(void)
 {
        imx6q_cpuidle_init();
+
+       if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ))
+               platform_device_register_simple("imx6q-cpufreq", -1, NULL, 0);
 }
With this patch applied I get a flood of these messages:

Quoted 6 lines

cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22

So it's because the driver change for imx6sx hasn't been in place. I just dropped the patch from my branch for now, and will revisit later when driver part shows up on my branch. (Unfortunately, that will be next cycle).

Shawn

Anson.Huang at freescale.com

2014-06-26 07:34 UTC #12 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

Hi, Shawn
I am OK with this.

Best Regards.
Anson Huang
?
Freescale Semiconductor Shanghai
Tel:021-28937058

Quoted 46 lines

-----Original Message-----
From: Shawn Guo [mailto:shawn.guo at freescale.com]
Sent: Thursday, June 26, 2014 1:55 PM
To: Fabio Estevam
Cc: Huang Yongcai-B20788; Sascha Hauer; Russell King; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH V2] ARM: imx: add cpufreq support for i.mx6sx
Quoted 25 lines · Fabio Estevam
Hi Anson,
Quoted 12 lines · Anson Huang
Add cpufreq support for i.MX6SX, using common i.MX6Q cpufreq driver.
Signed-off-by Anson Huang <[email protected]>
---
 arch/arm/mach-imx/mach-imx6sx.c |    3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0
b/arch/arm/mach-imx/mach-imx6sx.c index 74ff7d6..9221e1d 100644
arch/arm/mach-imx/mach-imx6sx.c static void __init imx6sx_init_irq(void) static · line 48
Quoted 7 lines
arch/arm/mach-imx/mach-imx6sx.c +4 -0
@@ -42,6 +42,9 @@ static void __init imx6sx_init_irq(void)  static
 void __init imx6sx_init_late(void)  {
        imx6q_cpuidle_init();
+
+       if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ))
+               platform_device_register_simple("imx6q-cpufreq", -1,
+ NULL, 0);
 }
With this patch applied I get a flood of these messages:
Quoted 6 lines
cpu cpu0: failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0:
failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22 cpu cpu0:
failed to scale vddpu up: -22
cpufreq: __target_index: Failed to change cpu frequency: -22
So it's because the driver change for imx6sx hasn't been in place. I just dropped the patch from my branch for now, and will revisit later when driver part shows up on my branch. (Unfortunately, that will be next cycle).
Shawn

Shawn Guo

2014-08-18 05:24 UTC #13 lore raw

PATCH v2 1/1 ARM: imx: add cpufreq support for i.mx6sx

In reply to Shawn Guo

Quoted 4 lines · Shawn Guo

So it's because the driver change for imx6sx hasn't been in place. I just dropped the patch from my branch for now, and will revisit later when driver part shows up on my branch. (Unfortunately, that will be next cycle).

The driver change is in v3.17-rc1, so I applies the dts patch.

Shawn