uclibc: clean-up test suite build command
PATCH 1/1 uclibc: clean-up test suite build command
Starting from uClibc 0.9.32 this cleaned-up command builds tests flawlessly. For 0.9.31 it lead to build failure, but assuming there're close to zero users who is going to test outdated uClibc library on obsolete (in Buildroot) AVR32 architecture I thin it worth applying.
Still it's possible to have 2 variants at the same time until AVR32 is not gone:
1. Old implementation used strictly for uClibc 0.9.31
2. New implementation for all other versions
--- package/uclibc/uclibc.mk | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/uclibc/uclibc.mk +2 -4
@@ -484,12 +484,10 @@ endef ifeq ($(BR2_UCLIBC_INSTALL_TEST_SUITE),y) define UCLIBC_BUILD_TEST_SUITE - $(MAKE1) -C $(@D)/test \ + $(MAKE1) -C $(@D) \ $(UCLIBC_MAKE_FLAGS) \ - ARCH_CFLAGS=-I$(STAGING_DIR)/usr/include \ UCLIBC_ONLY=1 \ - TEST_INSTALLED_UCLIBC=1 \ - compile + test_compile endef endif
Signature · 1 line
1.9.3
PATCH 1/1 uclibc: clean-up test suite build command
Dear Alexey Brodkin,
Quoted 10 lines · Alexey Brodkin
Starting from uClibc 0.9.32 this cleaned-up command builds tests flawlessly. For 0.9.31 it lead to build failure, but assuming there're close to zero users who is going to test outdated uClibc library on obsolete (in Buildroot) AVR32 architecture I thin it worth applying.
Still it's possible to have 2 variants at the same time until AVR32 is not gone:
1. Old implementation used strictly for uClibc 0.9.31
2. New implementation for all other versionsSigned-off-by Alexey Brodkin <[email protected]>
Unfortunately, unless this cleaned-up version brings significant benefits, I believe the best option is to keep things as is until AVR32 support is really deprecated and removed from Buildroot, so that we can drop support for 0.9.31.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 uclibc: clean-up test suite build command
Hi Thomas,
Quoted 4 lines · Thomas Petazzoni
Unfortunately, unless this cleaned-up version brings significant benefits, I believe the best option is to keep things as is until AVR32 support is really deprecated and removed from Buildroot, so that we can drop support for 0.9.31.
That's fine for me. Anyways patch is published and at any point anybody may apply it whether local or even upstream.
-Alexey
PATCH 1/1 uclibc: clean-up test suite build command
In reply to Thomas PetazzoniHi Thomas,
Quoted 12 lines · Thomas Petazzoni
Dear Alexey Brodkin,
Quoted 9 lines · Alexey Brodkin
Starting from uClibc 0.9.32 this cleaned-up command builds tests flawlessly. For 0.9.31 it lead to build failure, but assuming there're close to zero users who is going to test outdated uClibc library on obsolete (in Buildroot) AVR32 architecture I thin it worth applying.
Still it's possible to have 2 variants at the same time until AVR32 is not gone:
1. Old implementation used strictly for uClibc 0.9.31
2. New implementation for all other versions
Quoted 6 lines
Quoted 1 line
Signed-off-by Alexey Brodkin <[email protected]>Unfortunately, unless this cleaned-up version brings significant benefits, I believe the best option is to keep things as is until AVR32 support is really deprecated and removed from Buildroot, so that we can drop support for 0.9.31.
Now when AVR32 support is finally dropped do you think this patch might be accepted?
It still applies flawlessly on current master.
I build tested it on ARC and ARM. Note on ARM uClibc tests (BR2_UCLIBC_INSTALL_TEST_SUITE) will be only compiled without errors with uClibc-ng (BR2_UCLIBC_VERSION_NG), either BR2_UCLIBC_VERSION_0_9_33 or BR2_UCLIBC_VERSION_SNAPSHOT will fail on testsuite compilation but that has nothing to do with current patch.
-Alexey
PATCH 1/1 uclibc: clean-up test suite build command
Dear Alexey Brodkin,
Quoted 7 lines · Alexey Brodkin
Quoted 4 lines
Unfortunately, unless this cleaned-up version brings significant benefits, I believe the best option is to keep things as is until AVR32 support is really deprecated and removed from Buildroot, so that we can drop support for 0.9.31.
Now when AVR32 support is finally dropped do you think this patch might be accepted?
Yes, sure! AVR32 / supporting old uClibc versions was the only reason to keep the old way around. Now that AVR32 is gone, all clean-ups we can do following this removal are very welcome.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 uclibc: clean-up test suite build command
Hi Thomas,
Quoted 9 lines · Thomas Petazzoni
Dear Alexey Brodkin,
Quoted 5 lines · Alexey Brodkin
Quoted 4 lines
Unfortunately, unless this cleaned-up version brings significant benefits, I believe the best option is to keep things as is until AVR32 support is really deprecated and removed from Buildroot, so that we can drop support for 0.9.31.
Quoted 6 lines
Quoted 2 lines
Now when AVR32 support is finally dropped do you think this patch might be accepted?
Yes, sure! AVR32 / supporting old uClibc versions was the only reason to keep the old way around. Now that AVR32 is gone, all clean-ups we can do following this removal are very welcome.
Please treat this as a gentle reminder. I'm wondering if that pretty straight-forward change has a chance for being applied?
From your previous answer I understood that you\re in general fine with clean-up stuff like that.
-Alexey
PATCH 1/1 uclibc: clean-up test suite build command
Dear Alexey Brodkin,
Quoted 5 lines · Alexey Brodkin
Please treat this as a gentle reminder. I'm wondering if that pretty straight-forward change has a chance for being applied?
From your previous answer I understood that you\re in general fine with clean-up stuff like that.
Sure. Can you resend a new version of the patch, so that it shows up in patchwork?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 uclibc: clean-up test suite build command
Hi Thomas,
Quoted 4 lines · Thomas Petazzoni
Dear Alexey Brodkin,
On Mon, 20 Apr 2015 08:39:07 +0000, Alexey Brodkin wrote:
Quoted 8 lines
Quoted 5 lines
Please treat this as a gentle reminder. I'm wondering if that pretty straight-forward change has a chance for being applied?
From your previous answer I understood that you\re in general fine with clean-up stuff like that.
Sure. Can you resend a new version of the patch, so that it shows up in patchwork?
Sure, done!
-Alexey