Skip to contentSkip to conversation

bsr: avoid format string leaking into device name

PATCH RESEND New Kees Cook 1 participant 1 message Jun 30, 2014 Char and misc drivers

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH RESEND 1/1 bsr: avoid format string leaking into device name

This makes sure a format string cannot accidentally leak into a device name.

---
 drivers/char/bsr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/bsr.c +1 -1
index 8fedbc250414..a6cef548e01e 100644
@@ -259,7 +259,7 @@ static int bsr_add_node(struct device_node *bn)
 		}
 
 		cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
-						cur, cur->bsr_name);
+						cur, "%s", cur->bsr_name);
 		if (IS_ERR(cur->bsr_device)) {
 			printk(KERN_ERR "device_create failed for %s\n",
 			       cur->bsr_name);
Signature · 6 lines
1.7.9.5


-- 
Kees Cook
Chrome OS Security