wget: Depends on libuuid
PATCH 1/1 wget: Depends on libuuid
--- package/wget/Config.in | 2 ++ 1 file changed, 2 insertions(+)
package/wget/Config.in +2 -0
@@ -3,6 +3,8 @@ config BR2_PACKAGE_WGET # fork() depends on BR2_USE_MMU depends on BR2_USE_WCHAR + select BR2_PACKAGE_UTIL_LINUX + select BR2_PACKAGE_UTIL_LINUX_LIBUUID help Network utility to retrieve files from http, https and ftp.
Signature · 1 line
1.9.3
PATCH 1/1 wget: Depends on libuuid
Hi Alexander,
Quoted 10 lines · Alexander Potashev
Signed-off-by Alexander Potashev <[email protected]>--- package/wget/Config.in | 2 ++ 1 file changed, 2 insertions(+)package/wget/Config.in +0
-0
package/wget/Config.in config BR2_PACKAGE_WGET · line 7
Quoted 5 lines
package/wget/Config.in +2
-0@@ -3,6 +3,8 @@ config BR2_PACKAGE_WGET # fork() depends on BR2_USE_MMU depends on BR2_USE_WCHAR + select BR2_PACKAGE_UTIL_LINUX + select BR2_PACKAGE_UTIL_LINUX_LIBUUID
Care to explain why this is needed?
Also, you forgot to copy here the BR2_LARGEFILE dependency of util-linux.
baruch
Quoted 2 lines
package/wget/Config.in +0
-0help Network utility to retrieve files from http, https and ftp.
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH 1/1 wget: Depends on libuuid
In reply to Alexander PotashevDear Alexander Potashev,
Quoted 10 lines · Alexander Potashev
Signed-off-by Alexander Potashev <[email protected]>--- package/wget/Config.in | 2 ++ 1 file changed, 2 insertions(+)package/wget/Config.in +0
-0
package/wget/Config.in config BR2_PACKAGE_WGET · line 9
Quoted 7 lines
package/wget/Config.in +2
-0@@ -3,6 +3,8 @@ config BR2_PACKAGE_WGET # fork() depends on BR2_USE_MMU depends on BR2_USE_WCHAR + select BR2_PACKAGE_UTIL_LINUX + select BR2_PACKAGE_UTIL_LINUX_LIBUUID help Network utility to retrieve files from http, https and ftp.
I don't think libuuid is a mandatory dependency of wget, and if it was, your patch would not be sufficient, because it does not add 'util-linux' to WGET_DEPENDENCIES.
However, it indeed seems to be a possible optional dependency of wget, in which case what you want is the following addition in wget.mk:
ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBUUID),y)WGET_DEPENDENCIES += util-linux
endif
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
A message that is not in the archive (sent off-list or not yet received): 2414587.c08SQIiSAD@aspotashev
PATCH 1/1 wget: Depends on libuuid
Hi Alexander,
Quoted 10 lines · Alexander Potashev
? ?????? ?? 1 ???? 2014 11:35:49 ???????????? Thomas Petazzoni ???????:
Quoted 6 lines
However, it indeed seems to be a possible optional dependency of wget, in which case what you want is the following addition in wget.mk:
ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBUUID),y)
WGET_DEPENDENCIES+= util-linux
endifLooks good, although one could argue if keeping
*_DEPENDENCIESup-to-date is important when we also have dependency assurance in Config.in.
No. These are two different levels of dependencies. Config.in 'select' determines which packages are to be built. You need this for mandatory dependencies. The per package $(PKG)_DEPENDENCIES determines the ORDER of the build. $(PKG)_DEPENDENCIES should list both mandatory AND optional dependencies to get a reproducible result.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH 1/1 wget: Depends on libuuid
Hi Baruch,
? ?????? ?? 1 ???? 2014 13:07:27 ?? ????????:
Quoted 9 lines · Alexander Potashev
Quoted 2 lines
Looks good, although one could argue if keeping
*_DEPENDENCIESup-to-date is important when we also have dependency assurance in Config.in.No. These are two different levels of dependencies. Config.in 'select' determines which packages are to be built. You need this for mandatory dependencies. The per package $(PKG)_DEPENDENCIES determines the ORDER of the build. $(PKG)_DEPENDENCIES should list both mandatory AND optional dependencies to get a reproducible result.
Thanks for clarification! Now I see the change suggested by Thomas is important.
Signature · 2 lines
Regards, Alexander Potashev
PATCH 1/1 wget: Depends on libuuid
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Alexander" == Alexander Potashev <[email protected]> writes:
Hi Baruch,
? ?????? ?? 1 ???? 2014 13:07:27 ?? ????????:Quoted 4 lines · Alexander Potashev
Quoted 2 lines
Looks good, although one could argue if keeping
*_DEPENDENCIESup-to-date is important when we also have dependency assurance in Config.in.
Quoted 8 lines
Quoted 5 lines
No. These are two different levels of dependencies. Config.in 'select' determines which packages are to be built. You need this for mandatory dependencies. The per package $(PKG)_DEPENDENCIES determines the ORDER of the build. $(PKG)_DEPENDENCIES should list both mandatory AND optional dependencies to get a reproducible result.
Thanks for clarification! Now I see the change suggested by Thomas is important.
Great, I've committed a patch adding the optional libuuid depency. Thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 wget: Depends on libuuid
In reply to Thomas PetazzoniHello Thomas,
? ?????? ?? 1 ???? 2014 11:35:49 ???????????? Thomas Petazzoni ???????:
Quoted 3 lines
I don't think libuuid is a mandatory dependency of wget, and if it was, your patch would not be sufficient, because it does not add 'util-linux' to
WGET_DEPENDENCIES.
I was wrong: it is an optional dependency. I had a problem running wget because it found libuuid.so dangling somewhere in my Buildroot working copy but it was not installed onto the target. So it was a typical Buildroot non- clean rebuild problem, not a bug.
Sorry for the noise.
Quoted 6 lines
However, it indeed seems to be a possible optional dependency of wget, in which case what you want is the following addition in wget.mk:
ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBUUID),y)
WGET_DEPENDENCIES+= util-linux
endif
Looks good, although one could argue if keeping *_DEPENDENCIES up-to-date is important when we also have dependency assurance in Config.in.
Signature · 2 lines
Regards, Alexander Potashev