clk: qcom: Add support for IPQ8064's global clock controller (GCC)
Subsystems (5)
PATCH v4 1/1 clk: qcom: Add support for IPQ8064's global clock controller (GCC)
Add a driver for the global clock controller found on IPQ8064 based platforms. This should allow most non-multimedia device drivers to probe and control their clocks.
This is currently missing clocks for USB HSIC and networking devices.
---
v4:
* Fix usb utmi freq clk table
* Fix numbering issue in dt-bindings/clock/qcom,gcc-ipq806x.h
v3:
* Based on APQ8084 clk patches
* Added USB3 and SATA clks
* Minor clean ups (made hex numbers lowercase)
v2:
* dropped audio clock from commit message
* changed Kconfig symbol to IPQ_GCC_806X
* Fixed PXO/CXO clk freq to 25Mhz
.../devicetree/bindings/clock/qcom,gcc.txt | 1 + drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-ipq806x.c | 2424 ++++++++++++++++++++ include/dt-bindings/clock/qcom,gcc-ipq806x.h | 293 +++ include/dt-bindings/reset/qcom,gcc-ipq806x.h | 132 ++ 6 files changed, 2859 insertions(+) create mode 100644 drivers/clk/qcom/gcc-ipq806x.c create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq806x.h create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq806x.h
Documentation/devicetree/bindings/clock/qcom,gcc.txt +1 -0
@@ -6,6 +6,7 @@ Required properties : "qcom,gcc-apq8064" "qcom,gcc-apq8084" + "qcom,gcc-ipq8064" "qcom,gcc-msm8660" "qcom,gcc-msm8960" "qcom,gcc-msm8974"
drivers/clk/qcom/Kconfig +8 -0
@@ -12,6 +12,14 @@ config APQ_GCC_8084 Say Y if you want to use peripheral devices such as UART, SPI, i2c, USB, SD/eMMC, SATA, PCIe, etc. +config IPQ_GCC_806X + tristate "IPQ806x Global Clock Controller" + depends on COMMON_CLK_QCOM + help + Support for the global clock controller on ipq806x devices. + Say Y if you want to use peripheral devices such as UART, SPI, + i2c, USB, SD/eMMC, etc. + config MSM_GCC_8660 tristate "MSM8660 Global Clock Controller" depends on COMMON_CLK_QCOM
drivers/clk/qcom/Makefile +1 -0
@@ -9,6 +9,7 @@ clk-qcom-y += clk-branch.o clk-qcom-y += reset.o obj-$(CONFIG_APQ_GCC_8084) += gcc-apq8084.o +obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o obj-$(CONFIG_MSM_GCC_8660) += gcc-msm8660.o obj-$(CONFIG_MSM_GCC_8960) += gcc-msm8960.o obj-$(CONFIG_MSM_GCC_8974) += gcc-msm8974.o
drivers/clk/qcom/gcc-ipq806x.c new file +2424 -0
2,424 lines not on this page · raw message
include/dt-bindings/clock/qcom,gcc-ipq806x.h new file +293 -0
293 lines not on this page · raw message
include/dt-bindings/reset/qcom,gcc-ipq806x.h new file +132 -0
132 lines not on this page · raw message
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Quoted 31 lines · Kumar Gala
Add a driver for the global clock controller found on IPQ8064 based platforms. This should allow most non-multimedia device drivers to probe and control their clocks.
This is currently missing clocks for USB HSIC and networking devices.
Signed-off-by Kumar Gala <[email protected]>Signed-off-by Andy Gross <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
v4:
* Fix usb utmi freq clk table
* Fix numbering issue indt-bindings/clock/qcom,gcc-ipq806x.hv3:
* Based on APQ8084 clk patches
* Added USB3 and SATA clks
* Minor clean ups (made hex numbers lowercase)v2:
* dropped audio clock from commit message
* changedKconfigsymbol toIPQ_GCC_806X
* Fixed PXO/CXO clk freq to 25Mhz.../devicetree/bindings/clock/qcom,gcc.txt | 1 + drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-ipq806x.c | 2424 ++++++++++++++++++++ include/dt-bindings/clock/qcom,gcc-ipq806x.h | 293 +++ include/dt-bindings/reset/qcom,gcc-ipq806x.h | 132 ++ 6 files changed, 2859 insertions(+)
Quoted 3 lines
create mode 100644
drivers/clk/qcom/gcc-ipq806x.ccreate mode 100644include/dt-bindings/clock/qcom,gcc-ipq806x.hcreate mode 100644include/dt-bindings/reset/qcom,gcc-ipq806x.h
Mike,
Any update on pulling this in?
- k
Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 1/1 clk: qcom: Add support for IPQ8064's global clock controller (GCC)
Quoting Kumar Gala (2014-06-30 09:08:33)
Quoted 38 lines · Kumar Gala
Quoted 32 lines
Add a driver for the global clock controller found on IPQ8064 based platforms. This should allow most non-multimedia device drivers to probe and control their clocks.
This is currently missing clocks for USB HSIC and networking devices.
Signed-off-by Kumar Gala <[email protected]>Signed-off-by Andy Gross <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
v4:
* Fix usb utmi freq clk table
* Fix numbering issue indt-bindings/clock/qcom,gcc-ipq806x.hv3:
* Based on APQ8084 clk patches
* Added USB3 and SATA clks
* Minor clean ups (made hex numbers lowercase)v2:
* dropped audio clock from commit message
* changedKconfigsymbol toIPQ_GCC_806X
* Fixed PXO/CXO clk freq to 25Mhz.../devicetree/bindings/clock/qcom,gcc.txt | 1 + drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-ipq806x.c | 2424 ++++++++++++++++++++ include/dt-bindings/clock/qcom,gcc-ipq806x.h | 293 +++ include/dt-bindings/reset/qcom,gcc-ipq806x.h | 132 ++ 6 files changed, 2859 insertions(+)Quoted 3 lines
create mode 100644
drivers/clk/qcom/gcc-ipq806x.ccreate mode 100644include/dt-bindings/clock/qcom,gcc-ipq806x.hcreate mode 100644include/dt-bindings/reset/qcom,gcc-ipq806x.h
Quoted 3 lines
Mike,
Any update on pulling this in?
Looks good to me.
What's the story on getting a pull request for qcom clock stuff in the future? For more mature clock drivers it is nice for a clock maintainer (maybe Stephen in this case, based on patch count in drivers/clk/qcom?) to batch up everything. It also helps lazy maintainers like me not have to review every line of code for the non-controversial stuff.
Regards,
Mike
Quoted 7 lines
- k
Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation