Skip to contentSkip to conversation

ARM: kirkwood: add appended DTB support in kirkwood_defconfig

PATCH New Thomas Petazzoni 3 participants 8 messages Jul 2, 2014 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: kirkwood: add appended DTB support in kirkwood_defconfig

Most of the Kirkwood platforms use fairly old bootloaders that don't have Device Tree support, so it makes sense to enable appended DTB support by default, as well as the backward compatibility with ATAGS passed by the bootloader for those platforms. It helps having a defconfig that works fine out of the box for most Kirkwood platforms.

---
 arch/arm/configs/kirkwood_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/kirkwood_defconfig +2 -0
index b9e480c..2da96bc 100644
@@ -30,6 +30,8 @@ CONFIG_AEABI=y
 CONFIG_HIGHMEM=y
 CONFIG_ZBOOT_ROM_TEXT=0x0
 CONFIG_ZBOOT_ROM_BSS=0x0
+CONFIG_ARM_APPENDED_DTB=y
+CONFIG_ARM_ATAG_DTB_COMPAT=y
 CONFIG_CPU_FREQ=y
 CONFIG_CPU_FREQ_STAT_DETAILS=y
 CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
Signature · 1 line
2.0.0
#1 lore raw

PATCH 2/2 ARM: kirkwood: add devtmpfs to kirkwood_defconfig

The devtmpfs filesystem is now widely used and generally needed to boot Linux systems. 42 ARM defconfigs have it enabled, so it makes sense to have it enabled as well in kirkwood_defconfig.

---
 arch/arm/configs/kirkwood_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/kirkwood_defconfig +2 -0
index 2da96bc..5827c5f 100644
@@ -49,6 +49,8 @@ CONFIG_NET_PKTGEN=m
 CONFIG_CFG80211=y
 CONFIG_MAC80211=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_MTD=y
 CONFIG_MTD_CMDLINE_PARTS=y
 CONFIG_MTD_BLOCK=y
Signature · 1 line
2.0.0
#2 lore raw

PATCH 1/2 ARM: kirkwood: add appended DTB support in kirkwood_defconfig

In reply to Thomas Petazzoni
Quoted 9 lines · Thomas Petazzoni

Most of the Kirkwood platforms use fairly old bootloaders that don't have Device Tree support, so it makes sense to enable appended DTB support by default, as well as the backward compatibility with ATAGS passed by the bootloader for those platforms. It helps having a defconfig that works fine out of the box for most Kirkwood platforms.

---
 arch/arm/configs/kirkwood_defconfig | 2 ++

Hi Thomas

I plan to remove mach-kirkwood this cycle. So kirkwood_defconfig will get removed. Please could you patch mvebu_v5_defconfig instead?

Thanks
Andrew

#3 lore raw

PATCH 1/2 ARM: kirkwood: add appended DTB support in kirkwood_defconfig

Quoted 7 lines · Andrew Lunn
Quoted 6 lines · Thomas Petazzoni

Most of the Kirkwood platforms use fairly old bootloaders that don't have Device Tree support, so it makes sense to enable appended DTB support by default, as well as the backward compatibility with ATAGS passed by the bootloader for those platforms. It helps having a defconfig that works fine out of the box for most Kirkwood platforms.

Quoted 8 lines
Quoted 3 lines
---
 arch/arm/configs/kirkwood_defconfig | 2 ++

Hi Thomas

I plan to remove mach-kirkwood this cycle. So kirkwood_defconfig will get removed. Please could you patch mvebu_v5_defconfig instead?

Do we need to? There may be users who want to build a non-multiplatform kernel for kirkwood, or dove... It certainly takes less time than a multiplatform build.

thx,

Jason.

#4 lore raw

PATCH 1/2 ARM: kirkwood: add appended DTB support in kirkwood_defconfig

Quoted 12 lines · Jason Cooper
Quoted 11 lines · Andrew Lunn
Quoted 9 lines · Thomas Petazzoni

Most of the Kirkwood platforms use fairly old bootloaders that don't have Device Tree support, so it makes sense to enable appended DTB support by default, as well as the backward compatibility with ATAGS passed by the bootloader for those platforms. It helps having a defconfig that works fine out of the box for most Kirkwood platforms.

---
 arch/arm/configs/kirkwood_defconfig | 2 ++
Quoted 8 lines
Quoted 4 lines

Hi Thomas

I plan to remove mach-kirkwood this cycle. So kirkwood_defconfig will get removed. Please could you patch mvebu_v5_defconfig instead?

Do we need to? There may be users who want to build a non-multiplatform kernel for kirkwood, or dove... It certainly takes less time than a multiplatform build.

Hi Jason

mvebu_v5_defconfig is a single platform build, since kirkwood is the only mvebu v5 device. In future orion5x could be added, but i don't expect a huge build time difference.

Andrew

#5 lore raw

PATCH 1/2 ARM: kirkwood: add appended DTB support in kirkwood_defconfig

Quoted 22 lines · Andrew Lunn
Quoted 12 lines · Jason Cooper
Quoted 11 lines · Andrew Lunn
Quoted 9 lines · Thomas Petazzoni

Most of the Kirkwood platforms use fairly old bootloaders that don't have Device Tree support, so it makes sense to enable appended DTB support by default, as well as the backward compatibility with ATAGS passed by the bootloader for those platforms. It helps having a defconfig that works fine out of the box for most Kirkwood platforms.

---
 arch/arm/configs/kirkwood_defconfig | 2 ++
Quoted 8 lines
Quoted 4 lines

Hi Thomas

I plan to remove mach-kirkwood this cycle. So kirkwood_defconfig will get removed. Please could you patch mvebu_v5_defconfig instead?

Do we need to? There may be users who want to build a non-multiplatform kernel for kirkwood, or dove... It certainly takes less time than a multiplatform build.

Quoted 5 lines

Hi Jason

mvebu_v5_defconfig is a single platform build, since kirkwood is the only mvebu v5 device. In future orion5x could be added, but i don't expect a huge build time difference.

Ok, just make kirkwood_defconfig removal a separate patch so we can revert it later if we want.

thx,

Jason.

#6 lore raw

PATCH 1/2 ARM: kirkwood: add appended DTB support in kirkwood_defconfig

Quoted 2 lines

Ok, just make kirkwood_defconfig removal a separate patch so we can revert it later if we want.

Hi Jason

How would that work exactly, without having mach-kirkwood?

Andrew

#7 lore raw

PATCH 1/2 ARM: kirkwood: add appended DTB support in kirkwood_defconfig

Quoted 6 lines · Andrew Lunn
Quoted 2 lines

Ok, just make kirkwood_defconfig removal a separate patch so we can revert it later if we want.

Hi Jason

How would that work exactly, without having mach-kirkwood?

Set ARCH_MVEBU, MACH_KIRKWOOD, unset ARCH_MULTI_V5 and adjust the Kconfig to allow such a scenario.

It may not be desirable right now, but having it as a separate patch doesn't hurt anything, and it keeps the door open to the possibility in the future.

thx,

Jason.