Skip to contentSkip to conversation

pinctrl: sunxi: Remove gpio_out function from sun5i-a13 PG0/1/2 pins

PATCH New Chen-Yu Tsai 3 participants 3 messages Jul 1, 2014 – Jul 7, 2014

Subsystems (2)
Arm/Allwinner sunXi SoC support Pin control
lore
Share & tools
lore

Chen-Yu Tsai

author
#0 lore raw

PATCH 1/1 pinctrl: sunxi: Remove gpio_out function from sun5i-a13 PG0/1/2 pins

The A13 user manual states pins PG0/1/2 only have GPIO input and interrupt functions. Remove the gpio_out functions for these pins.

Signed-off-by Chen-Yu Tsai <[email protected]>

---
Hi,

The A13 manual [1] and reference design [2] explicitly warn that pins PG0/1/2 can not be used as gpio outputs. This patch removes the output functions from the pin definitions.

ChenYu

[1] http://dl.linux-sunxi.org/A13/A13%20User%20Manual%20-%20v1.2%20%282013-01-08%29.pdf

    Page 384.

[2] https://github.com/OLIMEX/OLINUXINO/raw/master/HARDWARE/A13-PDFs/a13-sch.pdf
Page 1, reminder in the red box (in Chinese)

---
 drivers/pinctrl/sunxi/pinctrl-sun5i-a13.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/pinctrl/sunxi/pinctrl-sun5i-a13.c +0 -3
index 29c734a..e47c33d 100644
@@ -330,15 +330,12 @@ static const struct sunxi_desc_pin sun5i_a13_pins[] = {
 	/* Hole */
 	SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 0),
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
-		  SUNXI_FUNCTION(0x1, "gpio_out"),
 		  SUNXI_FUNCTION_IRQ(0x6, 0)),		/* EINT0 */
 	SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 1),
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
-		  SUNXI_FUNCTION(0x1, "gpio_out"),
 		  SUNXI_FUNCTION_IRQ(0x6, 1)),		/* EINT1 */
 	SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 2),
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
-		  SUNXI_FUNCTION(0x1, "gpio_out"),
 		  SUNXI_FUNCTION_IRQ(0x6, 2)),		/* EINT2 */
 	SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 3),
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
Signature · 1 line
2.0.0
#1 lore raw

PATCH 1/1 pinctrl: sunxi: Remove gpio_out function from sun5i-a13 PG0/1/2 pins

Hi,

Quoted 4 lines · Chen-Yu Tsai

The A13 user manual states pins PG0/1/2 only have GPIO input and interrupt functions. Remove the gpio_out functions for these pins.

Signed-off-by Chen-Yu Tsai <[email protected]>

Good catch!

Acked-by Maxime Ripard <[email protected]>

Thanks,
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140704/8008aa6f/attachment.sig>
#2 lore raw

PATCH 1/1 pinctrl: sunxi: Remove gpio_out function from sun5i-a13 PG0/1/2 pins

In reply to Chen-Yu Tsai
Quoted 4 lines · Chen-Yu Tsai

The A13 user manual states pins PG0/1/2 only have GPIO input and interrupt functions. Remove the gpio_out functions for these pins.

Signed-off-by Chen-Yu Tsai <[email protected]>

Patch applied with Maxime's ACK.

Yours,
Linus Walleij