Skip to contentSkip to conversation

ASoC: wm-adsp: Add missing MODULE_LICENSE

PATCH Applied Vinod Koul 3 participants 5 messages Jul 4, 2014 – Jul 9, 2014

Subsystems (3)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH 1/1 ASoC: wm-adsp: Add missing MODULE_LICENSE

From: Praveen Diwakar <[email protected]>

Since MODULE_LICENSE is missing the module load fails, so add this for module.

---

---
 sound/soc/codecs/wm_adsp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/soc/codecs/wm_adsp.c +2 -0
index 0600271..2537725 100644
@@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(wm_adsp2_init);
+
+MODULE_LICENSE("GPL v2");
Signature · 1 line
1.7.0.4
maintainer
#1 lore raw
Quoted 4 lines · Vinod Koul

From: Praveen Diwakar <[email protected]>

Since MODULE_LICENSE is missing the module load fails, so add this for module.

Always CC maintainers on patches (in this case the Wolfson people), especially for something like licensing.

Quoted 21 lines

---

---
 sound/soc/codecs/wm_adsp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/soc/codecs/wm_adsp.c +2 -0
index 0600271..2537725 100644
@@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(wm_adsp2_init);
+
+MODULE_LICENSE("GPL v2");
Signature · 1 line
1.7.0.4
Reviewed-by
#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 4 lines · Vinod Koul

From: Praveen Diwakar <[email protected]>

Since MODULE_LICENSE is missing the module load fails, so add this for module.

Always CC maintainers on patches (in this case the Wolfson people), especially for something like licensing.

Indeed we would definitely like to be in the loop on licensing changes :-)

Quoted 8 lines
Quoted 8 lines

---

---
 sound/soc/codecs/wm_adsp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 10 lines

sound/soc/codecs/wm_adsp.c int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs) · line 1762

Quoted 10 lines
sound/soc/codecs/wm_adsp.c +2 -0
index 0600271..2537725 100644
@@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(wm_adsp2_init);
+
+MODULE_LICENSE("GPL v2");

Yeah this is fine, I have been meaning to do that myself.

Thanks,
Charles

author
#3 lore raw
Quoted 4 lines · Charles Keepax
Quoted 3 lines · Mark Brown
Quoted 2 lines · Vinod Koul

From: Praveen Diwakar <[email protected]>

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Since MODULE_LICENSE is missing the module load fails, so add this for module.

Always CC maintainers on patches (in this case the Wolfson people), especially for something like licensing.

Indeed we would definitely like to be in the loop on licensing changes :-)

Sorry about missing you folks on this. Somehow still mind equated wm with Mark.

We should let get_maintainers do this, always :)

Signature · 1 line
~Vinod