Skip to contentSkip to conversation

x86: kill ptregscall_common

PATCH In review Oleg Nesterov 2 participants 2 messages Jul 4, 2014 8 messages not in the archive x86

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 100531b7498c9148eaf7163ead7adef263d9981c.1404340903.git.luto@amacapital.net

A message that is not in the archive (sent off-list or not yet received): CALCETrVkg7_GzR0QqyW-hNS8iJGr3i_R6AbrjwjwwUboWCiNOw@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CALCETrVRJZeLam5jbNrgptETbXbsnPXMBgLwcO_uAMK6CSF65g@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CA+55aFzMSswoVaHhM41rATubj+rqBsa4jyQaBVPNHO_-BpyHJg@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CALCETrUDCDfm8+xEFiPDwJbSu25yo2xNKYYfCiU9RO5C_X=bDg@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CA+55aFwehdBTK=dXFQkXK2ZB6GYXxEcnY7Eg8jwSV5E6yaJNTQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw

PATCH 1/1 x86: kill ptregscall_common

It has no users since commit b3af11afe06a "x86: get rid of pt_regs argument of iopl(2)".

---
 arch/x86/kernel/entry_64.S |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)
arch/x86/kernel/entry_64.S +0 -13
index b25ca96..fa64128 100644
@@ -640,19 +640,6 @@ END(\label)
 	FORK_LIKE  vfork
 	FIXED_FRAME stub_iopl, sys_iopl
 
-ENTRY(ptregscall_common)
-	DEFAULT_FRAME 1 8	/* offset 8: return address */
-	RESTORE_TOP_OF_STACK %r11, 8
-	movq_cfi_restore R15+8, r15
-	movq_cfi_restore R14+8, r14
-	movq_cfi_restore R13+8, r13
-	movq_cfi_restore R12+8, r12
-	movq_cfi_restore RBP+8, rbp
-	movq_cfi_restore RBX+8, rbx
-	ret $REST_SKIP		/* pop extended registers */
-	CFI_ENDPROC
-END(ptregscall_common)
-
 ENTRY(stub_execve)
 	CFI_STARTPROC
 	addq $8, %rsp
Signature · 1 line
1.5.5.1
#9 lore raw
Quoted 2 lines · Oleg Nesterov

It has no users since commit b3af11afe06a "x86: get rid of pt_regs argument of iopl(2)".

Looks good to me.

--Andy

Quoted 34 lines
---
 arch/x86/kernel/entry_64.S |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)
arch/x86/kernel/entry_64.S +0 -14
index b25ca96..fa64128 100644
@@ -640,19 +640,6 @@ END(\label)
        FORK_LIKE  vfork
        FIXED_FRAME stub_iopl, sys_iopl
 
-ENTRY(ptregscall_common)
-       DEFAULT_FRAME 1 8       /* offset 8: return address */
-       RESTORE_TOP_OF_STACK %r11, 8
-       movq_cfi_restore R15+8, r15
-       movq_cfi_restore R14+8, r14
-       movq_cfi_restore R13+8, r13
-       movq_cfi_restore R12+8, r12
-       movq_cfi_restore RBP+8, rbp
-       movq_cfi_restore RBX+8, rbx
-       ret $REST_SKIP          /* pop extended registers */
-       CFI_ENDPROC
-END(ptregscall_common)
-
 ENTRY(stub_execve)
        CFI_STARTPROC
        addq $8, %rsp
--

1.5.5.1

Signature · 2 lines
Andy Lutomirski
AMA Capital Management, LLC