Skip to contentSkip to conversation

: staging/rtl8821ae/debug.c: sparse warning correction

PATCH In review Sami Laine 2 participants 2 messages Jul 6, 2014 – Jul 9, 2014 Staging

lore
Share & tools
lore

Sami Laine

author
#0 lore raw

PATCH 1/1 : staging/rtl8821ae/debug.c: sparse warning correction

From: Sami Laine <[email protected]>

Sparse warning correction:

vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was not declared. Should it be static?

Signed-off-by Sami Laine <[email protected]>

---

drivers/staging/rtl8821ae/debug.c +1 -1
index 8aefbf1..e4a19ba 100644
@@ -77,7 +77,7 @@ void rtl_dbgp_flag_init(struct ieee80211_hw *hw)
        /*Init Debug flag enable condition */
 }
 
-struct proc_dir_entry *proc_topdir;
+static struct proc_dir_entry *proc_topdir;
 static int rtl_proc_get_mac_0(struct seq_file *m, void *v)
 {
        struct ieee80211_hw *hw = m->private;
maintainer
#1 lore raw
Quoted 14 lines · Sami Laine

From: Sami Laine <[email protected]>

Sparse warning correction:

vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was not declared. Should it be static?

Signed-off-by Sami Laine <[email protected]>

---

drivers/staging/rtl8821ae/debug.c +0 -0
index 8aefbf1..e4a19ba 100644

drivers/staging/rtl8821ae/debug.c void rtl_dbgp_flag_init(struct ieee80211_hw *hw) · line 83

Quoted 8 lines
drivers/staging/rtl8821ae/debug.c +1 -1
@@ -77,7 +77,7 @@ void rtl_dbgp_flag_init(struct ieee80211_hw *hw)
        /*Init Debug flag enable condition */
 }
 
-struct proc_dir_entry *proc_topdir;
+static struct proc_dir_entry *proc_topdir;
 static int rtl_proc_get_mac_0(struct seq_file *m, void *v)
 {
        struct ieee80211_hw *hw = m->private;

This does not apply properly, and given the lack of testing of your other patch, I'm loath to try to fix it up by hand myself :(

greg k-h