thunderbolt: Correct the size argument to devm_kzalloc
PATCH 1/1 thunderbolt: Correct the size argument to devm_kzalloc
nhi->rx_rings does not have type as struct tb_ring *, as it is a double pointer so the elements of the array should have pointer type, not structure type.
The Coccinelle semantic patch that makes this change is as follows:
// <smpl>
@disable sizeof_type_expr@
type T;
T **x;
@@
x =
<+...sizeof(
- T
+ *x
)...+>
// </smpl>
--- drivers/thunderbolt/nhi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/thunderbolt/nhi.c +2 -2
@@ -570,10 +570,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)INIT_WORK (&nhi->interrupt_work, nhi_interrupt_work); nhi->tx_rings =devm_kzalloc (&pdev->dev, - nhi->hop_count *sizeof (struct tb_ring ), + nhi->hop_count *sizeof (*nhi->tx_rings),GFP_KERNEL ); nhi->rx_rings =devm_kzalloc (&pdev->dev, - nhi->hop_count *sizeof (struct tb_ring ), + nhi->hop_count *sizeof (*nhi->rx_rings),GFP_KERNEL );if (!nhi->tx_rings || !nhi->rx_rings)return -ENOMEM ;
Signature · 1 line
1.9.1
Quoted 3 lines · Himangi Saraogi
nhi->rx_ringsdoes not have type as structtb_ring*, as it is a double pointer so the elements of the array should have pointer type, not structure type.
[]
drivers/thunderbolt/nhi.c
Quoted 1 line
drivers/thunderbolt/nhi.c +0
-0
[]
drivers/thunderbolt/nhi.c static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id) · line 577
Quoted 11 lines
drivers/thunderbolt/nhi.c +2
-2@@ -570,10 +570,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)INIT_WORK (&nhi->interrupt_work, nhi_interrupt_work); nhi->tx_rings =devm_kzalloc (&pdev->dev, - nhi->hop_count *sizeof (struct tb_ring ), + nhi->hop_count *sizeof (*nhi->tx_rings),GFP_KERNEL ); nhi->rx_rings =devm_kzalloc (&pdev->dev, - nhi->hop_count *sizeof (struct tb_ring ), + nhi->hop_count *sizeof (*nhi->rx_rings),GFP_KERNEL );
It could use devm_kcalloc here too.
btw: are there many false positives with the cocci test?
Quoted 19 lines · Himangi Saraogi
nhi->rx_ringsdoes not have type as structtb_ring*, as it is a double pointer so the elements of the array should have pointer type, not structure type.The Coccinelle semantic patch that makes this change is as follows:
// <smpl>
@disable sizeof_type_expr@
type T;
T **x;
@@x =
<+...sizeof(
- T
+ *x
)...+>
// </smpl>
Quoted 5 lines
Signed-off-by Himangi Saraogi <[email protected]>Acked-by Julia Lawall <[email protected]>--- drivers/thunderbolt/nhi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Any reason you didn't cc: the developers in charge of this code so they see it and can pick it up? Otherwise it's just going to float around on the mailing list, listless and sad.
greg k-h
Quoted 26 lines · Greg KH
Quoted 19 lines · Himangi Saraogi
nhi->rx_ringsdoes not have type as structtb_ring*, as it is a double pointer so the elements of the array should have pointer type, not structure type.The Coccinelle semantic patch that makes this change is as follows:
// <smpl>
@disable sizeof_type_expr@
type T;
T **x;
@@x =
<+...sizeof(
- T
+ *x
)...+>
// </smpl>Quoted 5 lines
Signed-off-by Himangi Saraogi <[email protected]>Acked-by Julia Lawall <[email protected]>--- drivers/thunderbolt/nhi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 3 lines
Any reason you didn't cc: the developers in charge of this code so they see it and can pick it up? Otherwise it's just going to float around on the mailing list, listless and sad.
They don't seem to be in the MAINTAINERS file.
Himangi, you would see some people if you drop the --nogit-fallback argument from get_maintainers. Maybe that is too strict.
julia
Quoted 30 lines · Julia Lawall
Quoted 26 lines · Greg KH
Quoted 24 lines · Himangi Saraogi
nhi->rx_ringsdoes not have type as structtb_ring*, as it is a double pointer so the elements of the array should have pointer type, not structure type.The Coccinelle semantic patch that makes this change is as follows:
// <smpl>
@disable sizeof_type_expr@
type T;
T **x;
@@x =
<+...sizeof(
- T
+ *x
)...+>
// </smpl>Signed-off-by Himangi Saraogi <[email protected]>Acked-by Julia Lawall <[email protected]>--- drivers/thunderbolt/nhi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 3 lines
Any reason you didn't cc: the developers in charge of this code so they see it and can pick it up? Otherwise it's just going to float around on the mailing list, listless and sad.
They don't seem to be in the
MAINTAINERSfile.
Ah, good point. Andreas, care to send me a patch adding yourself to the MAINTAINERS file for drivers/thunderbolt/* so that you will get patches like this?
thanks,
greg k-h