ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
Subsystems (2)
PATCH 1/1 ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
The SDMA on imx6sl and imx6sx is more compatible with imx6q one than imx35. Let's use "fsl,imx6q-sdma" instead of "fsl,imx35-sdma", so that SDMA ROM script on imx6sl and imx6sx can work for audio driver just like the case of imx6q.
---
Thanks to Robin for finding this out.
arch/arm/boot/dts/imx6sl.dtsi | 2 +- arch/arm/boot/dts/imx6sx.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6sl.dtsi +1 -1
@@ -608,7 +608,7 @@ }; sdma: sdma at 020ec000 { - compatible = "fsl,imx6sl-sdma", "fsl,imx35-sdma"; + compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma"; reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SL_CLK_SDMA>,
arch/arm/boot/dts/imx6sx.dtsi +1 -1
@@ -706,7 +706,7 @@ }; sdma: sdma at 020ec000 { - compatible = "fsl,imx6sx-sdma", "fsl,imx35-sdma"; + compatible = "fsl,imx6sx-sdma", "fsl,imx6q-sdma"; reg = <0x020ec000 0x4000>; interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SX_CLK_SDMA>,
Signature · 1 line
1.8.3.2
PATCH 1/1 ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
-----Original Message-----
From: Shawn Guo [mailto:shawn.guo at freescale.com]
Sent: Friday, July 04, 2014 2:46 PM
To: linux-arm-kernel at lists.infradead.org
Cc: Gong Yibin-B38343; Estevam Fabio-R49496; Guo Shawn-R65073
Subject: [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
The SDMA on imx6sl and imx6sx is more compatible with imx6q one than imx35. Let's use "fsl,imx6q-sdma" instead of "fsl,imx35-sdma", so that SDMA ROM script on imx6sl and imx6sx can work for audio driver just like the case of imx6q.
---
Thanks to Robin for finding this out.
arch/arm/boot/dts/imx6sl.dtsi | 2 +- arch/arm/boot/dts/imx6sx.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6sl.dtsi +1 -1
@@ -608,7 +608,7 @@ }; sdma: sdma at 020ec000 { - compatible = "fsl,imx6sl-sdma", "fsl,imx35-sdma"; + compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma"; reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SL_CLK_SDMA>,
arch/arm/boot/dts/imx6sx.dtsi +1 -1
@@ -706,7 +706,7 @@ }; sdma: sdma at 020ec000 { - compatible = "fsl,imx6sx-sdma", "fsl,imx35-sdma"; + compatible = "fsl,imx6sx-sdma", "fsl,imx6q-sdma"; reg = <0x020ec000 0x4000>; interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SX_CLK_SDMA>,
--
1.8.3.2
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
In reply to Shawn GuoQuoted 9 lines · Shawn Guo
The SDMA on imx6sl and imx6sx is more compatible with imx6q one than imx35. Let's use "fsl,imx6q-sdma" instead of "fsl,imx35-sdma", so that SDMA ROM script on imx6sl and imx6sx can work for audio driver just like the case of imx6q.
Reported-by Fabio Estevam <[email protected]>Signed-off-by Shawn Guo <[email protected]>---
Thanks to Robin for finding this out.
Very good! Now I can play audio on mx6sl and mx6sx without the need of loading the external SDMA firmware.
However, I still have a question: wouldn't it be better to describe the compatible string as:
compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?
Regards,
Fabio Estevam
PATCH 1/1 ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
Quoted 11 lines · Fabio Estevam
Quoted 9 lines · Shawn Guo
The SDMA on imx6sl and imx6sx is more compatible with imx6q one than imx35. Let's use "fsl,imx6q-sdma" instead of "fsl,imx35-sdma", so that SDMA ROM script on imx6sl and imx6sx can work for audio driver just like the case of imx6q.
Reported-by Fabio Estevam <[email protected]>Signed-off-by Shawn Guo <[email protected]>---
Thanks to Robin for finding this out.
Quoted 6 lines
Very good! Now I can play audio on mx6sl and mx6sx without the need of loading the external SDMA firmware.
However, I still have a question: wouldn't it be better to describe the compatible string as:
compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?
No, it wouldn't be better or necessary.
Shawn
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
Quoted 5 lines · Shawn Guo
Quoted 3 lines
However, I still have a question: wouldn't it be better to describe the compatible string as:
compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?No, it wouldn't be better or necessary.
I have some trouble understanding when/if the three elements need to be passed into the compatible string.
For example: on mx6sl ssi node:
ssi1: ssi at 02028000 {
compatible = "fsl,imx6sl-ssi",
"fsl,imx51-ssi",
"fsl,imx21-ssi";However on mx6sx node we have:
ssi1: ssi at 02028000 {
compatible = "fsl,imx6sx-ssi", "fsl,imx21-ssi";Which one is correct? Care to explain?
PATCH 1/1 ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
Quoted 11 lines · Fabio Estevam
Quoted 5 lines · Shawn Guo
Quoted 3 lines
However, I still have a question: wouldn't it be better to describe the compatible string as:
compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?No, it wouldn't be better or necessary.
I have some trouble understanding when/if the three elements need to be passed into the compatible string.
Quoted 6 lines
For example: on mx6sl ssi node:
ssi1: ssi at 02028000 { compatible = "fsl,imx6sl-ssi", "fsl,imx51-ssi", "fsl,imx21-ssi";
I would say either one below is correct.
- compatible = "fsl,imx6sl-ssi", "fsl,imx51-ssi", "fsl,imx21-ssi";
- compatible = "fsl,imx6sl-ssi", "fsl,imx51-ssi";
But when commit 98ea6ad2edd2 (ARM: dts: imx6: use imx51-ssi) updates the compatible, it might be better to just replace "fsl,imx21-ssi" with "fsl,imx51-ssi".
Quoted 7 lines
However on mx6sx node we have:
ssi1: ssi at 02028000 { compatible = "fsl,imx6sx-ssi", "fsl,imx21-ssi";Which one is correct? Care to explain?
This one is incorrect now. The "fsl,imx21-ssi" should be replaced by "fsl,imx51-ssi" per commit above. Care to send a patch for it?
Shawn