crc32: Proper name of command is "crc32".
PATCH 1/1 crc32: Proper name of command is "crc32".
Signed-off-by Robert P. J. Day <[email protected]>
---
as i understand it, this fix should take care of the command being
named "crc32", is that right? it seems to generate the correct sphinx documentation.
Documentation/user/memory-areas.rst +1 -1
@@ -2,7 +2,7 @@ Memory areas ============ Several barebox commands like :ref:`command_md`, :ref:`command_erase` -or :ref:`command_crc` work on an area of memory. Areas have the following form:: +or :ref:`command_crc32` work on an area of memory. Areas have the following form:: <start>-<end>
commands/crc.c +1 -1
@@ -107,7 +107,7 @@ static int do_crc(int argc, char *argv[])return err; } -BAREBOX_CMD_HELP_START(crc) +BAREBOX_CMD_HELP_START(crc32) BAREBOX_CMD_HELP_TEXT("Calculate a CRC32 checksum of a memory area.") BAREBOX_CMD_HELP_TEXT("")BAREBOX_CMD_HELP_TEXT ("Options:" )
Signature · 12 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/bareboxSascha Hauer
AppliedQuoted 2 lines · Robert P. J. Day
Signed-off-by Robert P. J. Day <[email protected]>
Applied, thanks
Sascha
Quoted 49 lines
---
as i understand it, this fix should take care of the command being
named "crc32", is that right? it seems to generate the correct sphinx documentation.Documentation/user/memory-areas.rst +1
-1@@ -2,7 +2,7 @@ Memory areas ============ Several barebox commands like :ref:`command_md`, :ref:`command_erase` -or :ref:`command_crc` work on an area of memory. Areas have the following form:: +or :ref:`command_crc32` work on an area of memory. Areas have the following form:: <start>-<end>commands/crc.c +1
-1@@ -107,7 +107,7 @@ static int do_crc(int argc, char *argv[])return err; } -BAREBOX_CMD_HELP_START(crc) +BAREBOX_CMD_HELP_START(crc32) BAREBOX_CMD_HELP_TEXT("Calculate a CRC32 checksum of a memory area.") BAREBOX_CMD_HELP_TEXT("")BAREBOX_CMD_HELP_TEXT ("Options:" )Signature · 14 lines
-- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 27 lines · Robert P. J. Day
Signed-off-by Robert P. J. Day <[email protected]>---
as i understand it, this fix should take care of the command being
named "crc32", is that right? it seems to generate the correct sphinx documentation.Documentation/user/memory-areas.rst +1
-1@@ -2,7 +2,7 @@ Memory areas ============ Several barebox commands like :ref:`command_md`, :ref:`command_erase` -or :ref:`command_crc` work on an area of memory. Areas have the following form:: +or :ref:`command_crc32` work on an area of memory. Areas have the following form:: <start>-<end>commands/crc.c +0
-0
commands/crc.c static int do_crc(int argc, char *argv[]) · line 113
Quoted 8 lines
commands/crc.c +1
-1@@ -107,7 +107,7 @@ static int do_crc(int argc, char *argv[])return err; } -BAREBOX_CMD_HELP_START(crc) +BAREBOX_CMD_HELP_START(crc32) BAREBOX_CMD_HELP_TEXT("Calculate a CRC32 checksum of a memory area.") BAREBOX_CMD_HELP_TEXT("")BAREBOX_CMD_HELP_TEXT ("Options:" )
Damn, I pushed this to master without compile testing. Needs this fixup:
-----------------------------8<----------------------------
From 3f4e7adae9365aa08b5f87355bbb2ba370961304 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <[email protected]>
Date: Tue, 8 Jul 2014 10:52:55 +0200
Subject: [PATCH] Fix crc32 compile error
This fixes a compile error introduced with:
| commit 37f47a2a8c2dba420a849625b2926dacdc23cf49 | Author: Robert P. J. Day <[email protected]> | Date: Mon Jul 7 05:36:33 2014 -0400 | | crc32: Proper name of command is "crc32". | | Signed-off-by: Robert P. J. Day <[email protected]> | Signed-off-by: Sascha Hauer <[email protected]>
Signed-off-by Sascha Hauer <[email protected]>
--- commands/crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
commands/crc.c +1 -1
@@ -128,5 +128,5 @@ BAREBOX_CMD_START(crc32)#endif "vV] AREA") BAREBOX_CMD_GROUP(CMD_GRP_MEM) - BAREBOX_CMD_HELP(cmd_crc_help) + BAREBOX_CMD_HELP(cmd_crc32_help) BAREBOX_CMD_END
Signature · 12 lines
2.0.0 -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 2 lines · Sascha Hauer
Damn, I pushed this to master without compile testing. Needs this fixup:
oops, my fault, i checked only that it fixed the documentation
genration. apologies.
rday
Signature · 12 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox