Skip to contentSkip to conversation

staging: dgap: redundant NULL and magic check in dgap_get_modem_info()

PATCH In review Daeseok Youn 1 participant 1 message Jul 11, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/9 staging: dgap: redundant NULL and magic check in dgap_get_modem_info()

The "ch" is already checking in caller.

---
 drivers/staging/dgap/dgap.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
drivers/staging/dgap/dgap.c +0 -3
index 9affc5b..79ea116 100644
@@ -3061,9 +3061,6 @@ static int dgap_get_modem_info(struct channel_t *ch, unsigned int __user *value)
 	ulong lock_flags;
 	int rc;
 
-	if (!ch || ch->magic != DGAP_CHANNEL_MAGIC)
-		return -EIO;
-
 	spin_lock_irqsave(&ch->ch_lock, lock_flags);
 
 	mstat = readb(&(ch->ch_bs->m_stat));
Signature · 1 line
1.7.1