Skip to contentSkip to conversation

staging: android: Clean up binder_send_failed_reply

PATCH RESEND Superseded Lucas Tanure 2 participants 6 messages Jul 13, 2014 Staging

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: android: Clean up binder_send_failed_reply

Kernel coding style. Remove useless else statement after return.

---
 drivers/staging/android/binder.c | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)
drivers/staging/android/binder.c +13 -14
index 14714a6..67c9847 100644
@@ -1210,24 +1210,23 @@ static void binder_send_failed_reply(struct binder_transaction *t,
 					target_thread->return_error);
 			}
 			return;
-		} else {
-			struct binder_transaction *next = t->from_parent;
+		}
+		struct binder_transaction *next = t->from_parent;
 
-			binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
-				     "send failed reply for transaction %d, target dead\n",
-				     t->debug_id);
+		binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
+			"send failed reply for transaction %d, target dead\n",
+			t->debug_id);
 
-			binder_pop_transaction(target_thread, t);
-			if (next == NULL) {
-				binder_debug(BINDER_DEBUG_DEAD_BINDER,
-					     "reply failed, no target thread at root\n");
-				return;
-			}
-			t = next;
+		binder_pop_transaction(target_thread, t);
+		if (next == NULL) {
 			binder_debug(BINDER_DEBUG_DEAD_BINDER,
-				     "reply failed, no target thread -- retry %d\n",
-				      t->debug_id);
+				     "reply failed, no target thread at root\n");
+			return;
 		}
+		t = next;
+		binder_debug(BINDER_DEBUG_DEAD_BINDER,
+			     "reply failed, no target thread -- retry %d\n",
+			      t->debug_id);
 	}
 }
 
Signature · 1 line
2.0.1
#1 lore raw
Quoted 6 lines · Lucas Tanure

Kernel coding style. Remove useless else statement after return.

---
 drivers/staging/android/binder.c | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

Why the "RESEND"? What was wrong with the first patch? What is different with this one?

confused,

greg k-h

#2 lore raw

I missed on trailing whitespace in first patch. Didn't saw a ERROR: trailing whitespace in the first patch.

Sorry,
Thanks

--
Lucas Tanure
+55 (19) 988176559

#3 lore raw
Quoted 2 lines · Lucas Tanure

I missed on trailing whitespace in first patch. Didn't saw a ERROR: trailing whitespace in the first patch.

Ok. Please, always say that this is a 'v2' patch, and what the difference is between this one, and the previous version, otherwise I have no idea what to do here.

thanks,

greg k-h

#4 lore raw
In reply to Lucas Tanure
Quoted 6 lines · Lucas Tanure

Kernel coding style. Remove useless else statement after return.

---
 drivers/staging/android/binder.c | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

You didn't compile this patch :(

Or if you did, you ignored the fact that it now adds a warning to the kernel build process, which is not allowed. Please fix this up and resend.

thanks,

greg k-h

#5 lore raw

Sorry,
I didn't know. I will fix.

Thanks
--
Lucas Tanure
+55 (19) 988176559

Quoted 17 lines · Greg Kroah-Hartman
Quoted 6 lines · Lucas Tanure

Kernel coding style. Remove useless else statement after return.

---
 drivers/staging/android/binder.c | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

You didn't compile this patch :(

Or if you did, you ignored the fact that it now adds a warning to the kernel build process, which is not allowed. Please fix this up and resend.

thanks,

greg k-h