Skip to contentSkip to conversation

drm/tegra: sor - missing unlock on error

PATCH Applied Dan Carpenter 2 participants 2 messages Jun 11, 2014 – Jul 14, 2014

Subsystems (4)
DRM drivers Kernel janitors Tegra architecture support DRM drivers for NVIDIA Tegra
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/tegra: sor - missing unlock on error

We should unlock before returning the error code.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/tegra/sor.c +1 -1
index 27c979b..64f57fa 100644
@@ -516,7 +516,7 @@ static int tegra_output_sor_enable(struct tegra_output *output)
 		if (err < 0) {
 			dev_err(sor->dev, "failed to probe eDP link: %d\n",
 				err);
-			return err;
+			goto unlock;
 		}
 	}
Applied
#1 lore raw
Quoted 9 lines · Dan Carpenter

We should unlock before returning the error code.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/tegra/sor.c +0 -0
index 27c979b..64f57fa 100644

drivers/gpu/drm/tegra/sor.c static int tegra_output_sor_enable(struct tegra_output *output) · line 522

Quoted 8 lines
drivers/gpu/drm/tegra/sor.c +1 -1
@@ -516,7 +516,7 @@ static int tegra_output_sor_enable(struct tegra_output *output)
 		if (err < 0) {
 			dev_err(sor->dev, "failed to probe eDP link: %d\n",
 				err);
-			return err;
+			goto unlock;
 		}
 	}

Applied, thanks.

Thierry