drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM

PATCH In review Chen Gang 2 participants 6 messages Jul 13, 2014 – Jul 23, 2014 PWM

lore

Share & tools

lore

Chen Gang

author

2014-07-13 11:49 UTC #0 lore raw

PATCH 1/1 drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM

PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.

The related error (with allmodconfig under score):

MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!

Signed-off-by Chen Gang <[email protected]>

---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/pwm/Kconfig +1 -1

index 4ad7b89..2faf5ce 100644
@@ -82,7 +82,7 @@ config PWM_BFIN
 
 config PWM_CLPS711X
 	tristate "CLPS711X PWM support"
-	depends on ARCH_CLPS711X || COMPILE_TEST
+	depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
 	help
 	  Generic PWM framework driver for Cirrus Logic CLPS711X.

Signature · 1 line

1.7.11.7

Thierry Reding

2014-07-14 08:18 UTC #1 lore raw

Quoted 4 lines · Chen Gang

PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
The related error (with allmodconfig under score):

Quoted 8 lines

MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
Signed-off-by Chen Gang <[email protected]>
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

NAK given the discussion in the other thread.

Thierry

Chen Gang

author

2014-07-14 09:10 UTC #2 lore raw

Quoted 9 lines · 在 2014年7月14日，下午4:18，Thierry Reding <[email protected]> 写道：

Quoted 8 lines · Chen Gang
PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
The related error (with allmodconfig under score):
MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!

Quoted 8 lines

Quoted 4 lines
Signed-off-by Chen Gang <[email protected]>
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
NAK given the discussion in the other thread.
Thierry

OK, thanks, and I shall continue focusing the other thread, and send related patch after get conclusion (hope I can finish within this week).

Thanks
—
Chen Gang
Open share, and attitude like air water, and life which God blessed.

Thierry Reding

2014-07-14 09:33 UTC #3 lore raw

Quoted 17 lines · Chen Gang

Quoted 14 lines · 在 2014年7月14日，下午4:18，Thierry Reding <[email protected]> 写道：
Quoted 12 lines · Chen Gang
PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
The related error (with allmodconfig under score):
MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
Signed-off-by Chen Gang <[email protected]>
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 6 lines

Quoted 3 lines
NAK given the discussion in the other thread.
Thierry
OK, thanks, and I shall continue focusing the other thread, and send related patch after get conclusion (hope I can finish within this week).

Great, thanks for taking care of this.

Thierry

Chen Gang

author

2014-07-14 09:55 UTC #4 lore raw

Quoted 18 lines · 在 2014年7月14日，下午5:33，Thierry Reding <[email protected]> 写道：

Quoted 17 lines · Chen Gang
Quoted 14 lines · 在 2014年7月14日，下午4:18，Thierry Reding <[email protected]> 写道：
Quoted 12 lines · Chen Gang
PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
The related error (with allmodconfig under score):
MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
Signed-off-by Chen Gang <[email protected]>
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 9 lines

Quoted 6 lines
Quoted 3 lines
NAK given the discussion in the other thread.
Thierry
OK, thanks, and I shall continue focusing the other thread, and send related patch after get conclusion (hope I can finish within this week).
Great, thanks for taking care of this.

That what I should/will do. I start the related thread, so I have duty to try to finish it in time. :-)

Thanks.
—
Chen Gang
Open, share, and attitude like air, water, and life which God blessed.-

Chen Gang

author

2014-07-23 11:51 UTC #5 lore raw

Oh, sorry, after a long discussion, we have to keep current status no touch -- let individual modules depends on HAS_IOMEM if they need it.

So, this patch is still alive, please help check it, when you have time.

Thanks.

Quoted 39 lines · Chen Gang

Quoted 18 lines · 在 2014年7月14日，下午5:33，Thierry Reding <[email protected]> 写道：
Quoted 17 lines · Chen Gang
Quoted 14 lines · 在 2014年7月14日，下午4:18，Thierry Reding <[email protected]> 写道：
Quoted 12 lines · Chen Gang
PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
The related error (with allmodconfig under score):
MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
Signed-off-by Chen Gang <[email protected]>
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
NAK given the discussion in the other thread.
Thierry
OK, thanks, and I shall continue focusing the other thread, and send related patch after get conclusion (hope I can finish within this week).
Great, thanks for taking care of this.
That what I should/will do. I start the related thread, so I have duty to try to finish it in time. :-)
Thanks.
—
Chen Gang
Open, share, and attitude like air, water, and life which God blessed.

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed