dib7000m: Remove unnecessary null test
PATCH 1/1 dib7000m: Remove unnecessary null test
This patch removes the null test on ch. ch is initialized at the beginning of the function to &demod->dtv_property_cache. Since demod is dereferenced prior to the null test, demod must be a valid pointer, and &demod->dtv_property_cache cannot be null.
The following Coccinelle script is used for detecting the change:
@r@
expression e,f;
identifier g,y;
statement S1,S2;
@@
*e = &f->g
<+...
f->y
...+>
*if (e != NULL || ...)
S1 else S2
Signed-off-by Himangi Saraogi <[email protected]>
Acked-by Julia Lawall <[email protected]>
--- drivers/media/dvb-frontends/dib7000m.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/dvb-frontends/dib7000m.c +1 -4
@@ -1041,10 +1041,7 @@ static int dib7000m_tune(struct dvb_frontend *demod)u16 value;// we are already tuned - just resuming from suspend -if (ch !=NULL ) -dib7000m_set_channel (state, ch,0 ); -else -return -EINVAL ; +dib7000m_set_channel (state, ch,0 );// restart demod ret |=dib7000m_write_word (state,898 ,0x4000 );
Signature · 1 line
1.9.1