Skip to contentSkip to conversation

infra: fix "<pkg>-rebuild" when using rsync source feature

PATCH New Fabio Porcedda 3 participants 3 messages Jun 30, 2014 – Jul 16, 2014

lore
Share & tools
lore

Fabio Porcedda

author
#0 lore raw

PATCH 1/1 infra: fix "<pkg>-rebuild" when using rsync source feature

Because the configure stamp file depends on the rsync stamp file, removing it by the "<pkg>-clean-for-rebuild" rule trigger the configure step. To avoid triggering the configure step use an order-only dependency.

Signed-off-by Fabio Porcedda <[email protected]>
Reported-by C?dric Marie <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 package/pkg-generic.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/pkg-generic.mk +4 -1
index 54193d2..3c05a94 100644
@@ -544,7 +544,10 @@ else
 #  source, by rsyncing
 #  depends
 #  configure
-$$($(2)_TARGET_CONFIGURE):	$$($(2)_TARGET_RSYNC)
+
+# Use an order-only dependency so the "<pkg>-clean-for-rebuild" rule
+# can remove the stamp file without triggering the configure step.
+$$($(2)_TARGET_CONFIGURE): | $$($(2)_TARGET_RSYNC)
 
 $(1)-depends:		$$($(2)_FINAL_DEPENDENCIES)
Signature · 1 line
2.0.0
Applied
#1 lore raw

PATCH 1/1 infra: fix "<pkg>-rebuild" when using rsync source feature

Dear Fabio Porcedda,

Quoted 10 lines · Fabio Porcedda

Because the configure stamp file depends on the rsync stamp file, removing it by the "<pkg>-clean-for-rebuild" rule trigger the configure step. To avoid triggering the configure step use an order-only dependency.

Signed-off-by Fabio Porcedda <[email protected]>
Reported-by C?dric Marie <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 package/pkg-generic.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 infra: fix "<pkg>-rebuild" when using rsync source feature

Le 2014-07-15 22:45, Thomas Petazzoni a ?crit?:

Quoted 1 line

Applied, thanks.

Thanks a lot :)

Signature · 1 line
C?dric