Skip to contentSkip to conversation

uclibc: fix tests building in uClibc 0.9.33.2

PATCH New Alexey Brodkin 3 participants 5 messages Jun 29, 2014 – Jul 15, 2014

lore
Share & tools
lore

Alexey Brodkin

author
#0 lore raw

PATCH 1/1 uclibc: fix tests building in uClibc 0.9.33.2

Following patches are required for successful bulding of uClibc built-int tests (BR2_UCLIBC_INSTALL_TEST_SUITE=y):

1.
uclibc-0059-test-cater-for-config.patch
http://git.uclibc.org/uClibc/commit/test?id=7598eeaa1defa2884adaa890bb115c493d69cc35

2. uclibc-0058-test-tls-fix-build-with-newer-binutils.patch
http://git.uclibc.org/uClibc/commit/test?id=931e8391565323ed2e589c83b83a7345813a5514

3.
uclibc-0060-test-Fix-math-c-dependency.patch
http://git.uclibc.org/uClibc/commit/test/math?id=a20a91ad7c042c46e4a2adee6d03315f857f9985

All mentioned patches must be removed as obsolete on bumping uClibc to the next release.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Anton Kolesov <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Gustavo Zacarias <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Thomas De Schampheleire <[email protected]>
---
 ...58-test-tls-fix-build-with-newer-binutils.patch | 37 ++++++++++
 .../uclibc-0059-test-cater-for-config.patch        | 81 ++++++++++++++++++++++
 .../uclibc-0060-test-Fix-math-c-dependency.patch   | 30 ++++++++
 3 files changed, 148 insertions(+)
 create mode 100644 package/uclibc/0.9.33.2/uclibc-0058-test-tls-fix-build-with-newer-binutils.patch
 create mode 100644 package/uclibc/0.9.33.2/uclibc-0059-test-cater-for-config.patch
 create mode 100644 package/uclibc/0.9.33.2/uclibc-0060-test-Fix-math-c-dependency.patch
package/uclibc/0.9.33.2/uclibc-0058-test-tls-fix-build-with-newer-binutils.patch new file +37 -0
new file mode 100644
index 0000000..04dfb1e
@@ -0,0 +1,37 @@
+From 931e8391565323ed2e589c83b83a7345813a5514 Mon Sep 17 00:00:00 2001
+From: Baruch Siach <[email protected]>
+Date: Wed, 02 Oct 2013 07:08:29 +0000
+Subject: test: tls: fix build with newer binutils
+
+Fix the following build failures:
+
+ld: tst-tls10.o: undefined reference to symbol 'f2a'
+ld: tst-tls12.o: undefined reference to symbol 'a1'
+
+binutils ld defaults to --no-copy-dt-needed-entries since version 2.22. Add
+library dependencies explicitly.
+
+Signed-off-by: Baruch Siach <[email protected]>
+Signed-off-by: Bernhard Reutner-Fischer <[email protected]>
+---
+(limited to 'test')
+
+diff --git a/test/tls/Makefile.in b/test/tls/Makefile.in
+index 875c607..7ab4e2a 100644
+--- a/test/tls/Makefile.in
++++ b/test/tls/Makefile.in
+@@ -102,9 +102,9 @@ LDFLAGS_tst-tls6 := -ldl
+ LDFLAGS_tst-tls7 := -ldl
+ LDFLAGS_tst-tls8 := -ldl
+ LDFLAGS_tst-tls9 := -ldl
+-LDFLAGS_tst-tls10 := -Wl,-rpath-link=. tst-tlsmod8.so
+-LDFLAGS_tst-tls11 := -Wl,-rpath-link=. tst-tlsmod10.so
+-LDFLAGS_tst-tls12 := -Wl,-rpath-link=. tst-tlsmod12.so
++LDFLAGS_tst-tls10 := -Wl,-rpath-link=. tst-tlsmod8.so tst-tlsmod7.so
++LDFLAGS_tst-tls11 := -Wl,-rpath-link=. tst-tlsmod9.so tst-tlsmod10.so
++LDFLAGS_tst-tls12 := -Wl,-rpath-link=. tst-tlsmod11.so tst-tlsmod12.so
+ LDFLAGS_tst-tls13 := -ldl -Wl,-rpath-link=.
+ LDFLAGS_tst-tls14 := -ldl -Wl,-rpath-link=. tst-tlsmod14a.so
+ LDFLAGS_tst-tls15 := -ldl -Wl,-rpath-link=.
+--
+cgit v0.9.1
package/uclibc/0.9.33.2/uclibc-0059-test-cater-for-config.patch new file +81 -0

81 lines not on this page · raw message

package/uclibc/0.9.33.2/uclibc-0060-test-Fix-math-c-dependency.patch new file +30 -0
new file mode 100644
index 0000000..c6ee47d
@@ -0,0 +1,30 @@
+From a20a91ad7c042c46e4a2adee6d03315f857f9985 Mon Sep 17 00:00:00 2001
+From: Bernhard Reutner-Fischer <[email protected]>
+Date: Tue, 18 Feb 2014 23:30:28 +0100
+Subject: [PATCH] test: Fix math .c dependency
+
+When explicitly running the compile target we were missing a dependency
+to generate the libm-test.c.
+
+Signed-off-by: Bernhard Reutner-Fischer <[email protected]>
+---
+ test/math/Makefile.in | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/test/math/Makefile.in b/test/math/Makefile.in
+index beef650..0285b66 100644
+--- a/test/math/Makefile.in
++++ b/test/math/Makefile.in
+@@ -25,7 +25,8 @@ EXTRA_LDFLAGS   := -lm
+ 
+ PERL := /usr/bin/perl
+ 
+-$(TESTS): libm-test.c
++MDEPS := $(wildcard test-*.c)
++$(MDEPS): libm-test.c
+ 
+ libm-test.c: libm-test-ulps-$(TARGET_ARCH) libm-test.inc gen-libm-test.pl
+ 	$(Q)$(PERL) ./gen-libm-test.pl -u libm-test-ulps-$(TARGET_ARCH) ./libm-test.inc -o "." 2>&1 > /dev/null
+-- 
+1.9.3
+
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 uclibc: fix tests building in uClibc 0.9.33.2

Alexey Brodkin <[email protected]> schreef:

Quoted 47 lines

Following patches are required for successful bulding of uClibc built-int tests (BR2_UCLIBC_INSTALL_TEST_SUITE=y):

1.
uclibc-0059-test-cater-for-config.patch
http://git.uclibc.org/uClibc/commit/test?id=7598eeaa1defa2884adaa890bb115c493d69cc35

2. uclibc-0058-test-tls-fix-build-with-newer-binutils.patch
http://git.uclibc.org/uClibc/commit/test?id=931e8391565323ed2e589c83b83a7345813a5514

3.
uclibc-0060-test-Fix-math-c-dependency.patch
http://git.uclibc.org/uClibc/commit/test/math?id=a20a91ad7c042c46e4a2adee6d03315f857f9985

All mentioned patches must be removed as obsolete on bumping uClibc to the next release.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Anton Kolesov <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Gustavo Zacarias <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Thomas De Schampheleire <[email protected]>

---

...58-test-tls-fix-build-with-newer-binutils.patch | 37 ++++++++++
.../uclibc-0059-test-cater-for-config.patch        | 81 ++++++++++++++++++++++
.../uclibc-0060-test-Fix-math-c-dependency.patch   | 30 ++++++++
3 files changed, 148 insertions(+)

create mode 100644 package/uclibc/0.9.33.2/uclibc-0058-test-tls-fix-build-with-newer-binutils.patch create mode 100644 package/uclibc/0.9.33.2/uclibc-0059-test-cater-for-config.patch create mode 100644 package/uclibc/0.9.33.2/uclibc-0060-test-Fix-math-c-dependency.patch

package/uclibc/0.9.33.2/uclibc-0058-test-tls-fix-build-with-newer-binutils.patch new file +7 -0
new file mode 100644
index 0000000..04dfb1e
@@ -0,0 +1,37 @@
+From 931e8391565323ed2e589c83b83a7345813a5514 Mon Sep 17 00:00:00 2001
+From: Baruch Siach <[email protected]>
+Date: Wed, 02 Oct 2013 07:08:29 +0000
+Subject: test: tls: fix build with newer binutils
+
+Fix the following build failures:
+

package/uclibc/0.9.33.2/uclibc-0058-test-tls-fix-build-with-newer-binutils.patch line 17

Quoted 10 lines
package/uclibc/0.9.33.2/uclibc-0058-test-tls-fix-build-with-newer-binutils.patch new file +10 -0
+ld: tst-tls10.o: undefined reference to symbol 'f2a'
+ld: tst-tls12.o: undefined reference to symbol 'a1'
+
+binutils ld defaults to --no-copy-dt-needed-entries since version 2.22. Add
+library dependencies explicitly.
+
+Signed-off-by: Baruch Siach <[email protected]>
+Signed-off-by: Bernhard Reutner-Fischer <[email protected]>
+---
+(limited to 'test')

When taking patches via a git web interface, it's important to check the full patch, not limited to a particular file or subdirectory, as is the case here. You can do that by browsing up the file hierarchy once a revision is selected, or do manual editing of the url remove the path.

This is because there may be changes in other places for this patch...

Same comment on the other patches added...

Best regards,
Thomas

author
#2 lore raw

PATCH 1/1 uclibc: fix tests building in uClibc 0.9.33.2

Hi Thomas,

Quoted 5 lines · Thomas De Schampheleire

When taking patches via a git web interface, it's important to check the full patch, not limited to a particular file or subdirectory, as is the case here. You can do that by browsing up the file hierarchy once a revision is selected, or do manual editing of the url remove the path.

This is because there may be changes in other places for this patch...

Same comment on the other patches added...

Thanks for this warning.
I did notice this strange behavior earlier so this time I double-checked if patches are complete.

Moreover the best proof of concept is successful build :)

References to gitweb I put just for convenience of next users/developers.

-Alexey

author
#3 lore raw

PATCH 1/1 uclibc: fix tests building in uClibc 0.9.33.2

In reply to Thomas De Schampheleire

Hi Thomas, Peter,

Quoted 20 lines · Thomas De Schampheleire

Alexey Brodkin <[email protected]> schreef:

Quoted 19 lines

Following patches are required for successful bulding of uClibc built-int tests (BR2_UCLIBC_INSTALL_TEST_SUITE=y):

1.
uclibc-0059-test-cater-for-config.patch
http://git.uclibc.org/uClibc/commit/test?id=7598eeaa1defa2884adaa890bb115c493d69cc35

2. uclibc-0058-test-tls-fix-build-with-newer-binutils.patch
http://git.uclibc.org/uClibc/commit/test?id=931e8391565323ed2e589c83b83a7345813a5514

3.
uclibc-0060-test-Fix-math-c-dependency.patch
http://git.uclibc.org/uClibc/commit/test/math?id=a20a91ad7c042c46e4a2adee6d03315f857f9985

All mentioned patches must be removed as obsolete on bumping uClibc to the next release.

Signed-off-by Alexey Brodkin <[email protected]>

Any chance to get it applied?
This allows people compile uClibc tests so IMHO is useful.

-Alexey

Applied
#4 lore raw

PATCH 1/1 uclibc: fix tests building in uClibc 0.9.33.2

In reply to Alexey Brodkin

Dear Alexey Brodkin,

Quoted 11 lines · Alexey Brodkin

Following patches are required for successful bulding of uClibc built-int tests (BR2_UCLIBC_INSTALL_TEST_SUITE=y):

1.
uclibc-0059-test-cater-for-config.patch
http://git.uclibc.org/uClibc/commit/test?id=7598eeaa1defa2884adaa890bb115c493d69cc35

2. uclibc-0058-test-tls-fix-build-with-newer-binutils.patch
http://git.uclibc.org/uClibc/commit/test?id=931e8391565323ed2e589c83b83a7345813a5514

Quoted 8 lines

3.
uclibc-0060-test-Fix-math-c-dependency.patch
http://git.uclibc.org/uClibc/commit/test/math?id=a20a91ad7c042c46e4a2adee6d03315f857f9985

All mentioned patches must be removed as obsolete on bumping uClibc to the next release.

Signed-off-by Alexey Brodkin <[email protected]>

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com