perf/core improvements and fixes
Jiri Olsa
reviewerhi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 8b5b584daf3b92fc5cdc83919e64231817d2f5a7:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-07-05 11:29:32 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to d243144af0b52fc5164a0823194f29a5979e236c:
perf timechart: Add more options to IO mode (2014-07-10 00:22:54 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Add IO mode into timechart command (Stanislav Fomichev)
----------------------------------------------------------------
Stanislav Fomichev (4):
perf timechart: Fix rendering in Firefox
perf timechart: Implement IO mode
perf timechart: Conditionally update start_time on fork perf timechart: Add more options to IO mode
tools/perf/Documentation/perf-timechart.txt | 38 +- tools/perf/builtin-timechart.c | 693 +++++++++++++++++++++++++++- tools/perf/util/svghelper.c | 168 +++++-- tools/perf/util/svghelper.h | 6 +- 4 files changed, 845 insertions(+), 60 deletions(-)
Jiri Olsa
reviewerPATCH 1/4 perf timechart: Fix rendering in Firefox
From: Stanislav Fomichev <[email protected]>
Firefox doesn't correctly handle cases where we specify number in quotes and have some padding around the number, like the following:
<rect ... height=" 3.1" ...>
In this case, it doesn't draw the figure. This patch removes 'field width' component from fprintf strings to fix it.
--- tools/perf/util/svghelper.c | 72 ++++++++++++++++++++++----------------------- 1 file changed, 36 insertions(+), 36 deletions(-)
tools/perf/util/svghelper.c +36 -36
@@ -137,7 +137,7 @@ void svg_box(int Yslot, u64 start, u64 end, const char *type)if (!svgfile)return ; -fprintf (svgfile,"<rect x=\"%4.8f\" width=\"%4.8f\" y=\"%4.1f\" height=\"%4.1f\" class=\"%s\"/>\n" , +fprintf (svgfile,"<rect x=\"%.8f\" width=\"%.8f\" y=\"%.1f\" height=\"%.1f\" class=\"%s\"/>\n" ,time2pixels (start),time2pixels (end)-time2pixels (start), Yslot *SLOT_MULT ,SLOT_HEIGHT , type); }
@@ -174,7 +174,7 @@ void svg_running(int Yslot, int cpu, u64 start, u64 end, const char *backtrace) cpu, time_to_string(end - start));if (backtrace)fprintf (svgfile,"<desc>Switched because:\n%s</desc>\n" , backtrace); -fprintf (svgfile,"<rect x=\"%4.8f\" width=\"%4.8f\" y=\"%4.1f\" height=\"%4.1f\" class=\"%s\"/>\n" , +fprintf (svgfile,"<rect x=\"%.8f\" width=\"%.8f\" y=\"%.1f\" height=\"%.1f\" class=\"%s\"/>\n" ,time2pixels (start),time2pixels (end)-time2pixels (start), Yslot *SLOT_MULT ,SLOT_HEIGHT , type);
@@ -186,7 +186,7 @@ void svg_running(int Yslot, int cpu, u64 start, u64 end, const char *backtrace) text_size =round_text_size (text_size);if (text_size >MIN_TEXT_SIZE ) -fprintf (svgfile,"<text x=\"%1.8f\" y=\"%1.8f\" font-size=\"%1.8fpt\">%i</text>\n" , +fprintf (svgfile,"<text x=\"%.8f\" y=\"%.8f\" font-size=\"%.8fpt\">%i</text>\n" ,time2pixels (start), Yslot *SLOT_MULT +SLOT_HEIGHT -1 , text_size, cpu +1 );fprintf (svgfile,"</g>\n" );
@@ -202,10 +202,10 @@ static char *time_to_string(u64 duration)return text;if (duration <1000 *1000 ) {/* less than 1 msec */ -sprintf (text,"%4.1f us" , duration /1000.0 ); +sprintf (text,"%.1f us" , duration /1000.0 );return text; } -sprintf (text,"%4.1f ms" , duration /1000.0 /1000 ); +sprintf (text,"%.1f ms" , duration /1000.0 /1000 );return text; }
@@ -233,14 +233,14 @@ void svg_waiting(int Yslot, int cpu, u64 start, u64 end, const char *backtrace) font_size =round_text_size (font_size); -fprintf (svgfile,"<g transform=\"translate(%4.8f,%4.8f)\">\n" ,time2pixels (start), Yslot *SLOT_MULT ); +fprintf (svgfile,"<g transform=\"translate(%.8f,%.8f)\">\n" ,time2pixels (start), Yslot *SLOT_MULT );fprintf (svgfile,"<title>#%d waiting %s</title>\n" , cpu,time_to_string (end - start));if (backtrace)fprintf (svgfile,"<desc>Waiting on:\n%s</desc>\n" , backtrace); -fprintf (svgfile,"<rect x=\"0\" width=\"%4.8f\" y=\"0\" height=\"%4.1f\" class=\"%s\"/>\n" , +fprintf (svgfile,"<rect x=\"0\" width=\"%.8f\" y=\"0\" height=\"%.1f\" class=\"%s\"/>\n" ,time2pixels (end)-time2pixels (start),SLOT_HEIGHT , style);if (font_size >MIN_TEXT_SIZE ) -fprintf (svgfile,"<text transform=\"rotate(90)\" font-size=\"%1.8fpt\"> %s</text>\n" , +fprintf (svgfile,"<text transform=\"rotate(90)\" font-size=\"%.8fpt\"> %s</text>\n" , font_size, text);fprintf (svgfile,"</g>\n" ); }
@@ -289,16 +289,16 @@ void svg_cpu_box(int cpu, u64 __max_freq, u64 __turbo_freq)fprintf (svgfile,"<g>\n" ); -fprintf (svgfile,"<rect x=\"%4.8f\" width=\"%4.8f\" y=\"%4.1f\" height=\"%4.1f\" class=\"cpu\"/>\n" , +fprintf (svgfile,"<rect x=\"%.8f\" width=\"%.8f\" y=\"%.1f\" height=\"%.1f\" class=\"cpu\"/>\n" ,time2pixels (first_time),time2pixels (last_time)-time2pixels (first_time),cpu2y (cpu),SLOT_MULT +SLOT_HEIGHT );sprintf (cpu_string,"CPU %i" , (int )cpu); -fprintf (svgfile,"<text x=\"%4.8f\" y=\"%4.8f\">%s</text>\n" , +fprintf (svgfile,"<text x=\"%.8f\" y=\"%.8f\">%s</text>\n" ,10 +time2pixels (first_time),cpu2y (cpu) +SLOT_HEIGHT /2 , cpu_string); -fprintf (svgfile,"<text transform=\"translate(%4.8f,%4.8f)\" font-size=\"1.25pt\">%s</text>\n" , +fprintf (svgfile,"<text transform=\"translate(%.8f,%.8f)\" font-size=\"1.25pt\">%s</text>\n" ,10 +time2pixels (first_time),cpu2y (cpu) +SLOT_MULT +SLOT_HEIGHT -4 ,cpu_model ());fprintf (svgfile,"</g>\n" );
@@ -319,11 +319,11 @@ void svg_process(int cpu, u64 start, u64 end, int pid, const char *name, const celse type ="sample" ; -fprintf (svgfile,"<g transform=\"translate(%4.8f,%4.8f)\">\n" ,time2pixels (start),cpu2y (cpu)); +fprintf (svgfile,"<g transform=\"translate(%.8f,%.8f)\">\n" ,time2pixels (start),cpu2y (cpu));fprintf (svgfile,"<title>%d %s running %s</title>\n" , pid, name,time_to_string (end - start));if (backtrace)fprintf (svgfile,"<desc>Switched because:\n%s</desc>\n" , backtrace); -fprintf (svgfile,"<rect x=\"0\" width=\"%4.8f\" y=\"0\" height=\"%4.1f\" class=\"%s\"/>\n" , +fprintf (svgfile,"<rect x=\"0\" width=\"%.8f\" y=\"0\" height=\"%.1f\" class=\"%s\"/>\n" ,time2pixels (end)-time2pixels (start),SLOT_MULT +SLOT_HEIGHT , type); width =time2pixels (end)-time2pixels (start);if (width >6 )
@@ -332,7 +332,7 @@ void svg_process(int cpu, u64 start, u64 end, int pid, const char *name, const c width =round_text_size (width);if (width >MIN_TEXT_SIZE ) -fprintf (svgfile,"<text transform=\"rotate(90)\" font-size=\"%3.8fpt\">%s</text>\n" , +fprintf (svgfile,"<text transform=\"rotate(90)\" font-size=\"%.8fpt\">%s</text>\n" , width, name);fprintf (svgfile,"</g>\n" );
@@ -353,7 +353,7 @@ void svg_cstate(int cpu, u64 start, u64 end, int type) type =6 ;sprintf (style,"c%i" , type); -fprintf (svgfile,"<rect class=\"%s\" x=\"%4.8f\" width=\"%4.8f\" y=\"%4.1f\" height=\"%4.1f\"/>\n" , +fprintf (svgfile,"<rect class=\"%s\" x=\"%.8f\" width=\"%.8f\" y=\"%.1f\" height=\"%.1f\"/>\n" , style,time2pixels (start),time2pixels (end)-time2pixels (start),cpu2y (cpu),SLOT_MULT +SLOT_HEIGHT );
@@ -365,7 +365,7 @@ void svg_cstate(int cpu, u64 start, u64 end, int type) width =round_text_size (width);if (width >MIN_TEXT_SIZE ) -fprintf (svgfile,"<text x=\"%4.8f\" y=\"%4.8f\" font-size=\"%3.8fpt\">C%i</text>\n" , +fprintf (svgfile,"<text x=\"%.8f\" y=\"%.8f\" font-size=\"%.8fpt\">C%i</text>\n" ,time2pixels (start),cpu2y (cpu)+width, width, type);fprintf (svgfile,"</g>\n" );
@@ -407,9 +407,9 @@ void svg_pstate(int cpu, u64 start, u64 end, u64 freq)if (max_freq) height = freq *1.0 / max_freq * (SLOT_HEIGHT +SLOT_MULT ); height =1 +cpu2y (cpu) +SLOT_MULT +SLOT_HEIGHT - height; -fprintf (svgfile,"<line x1=\"%4.8f\" x2=\"%4.8f\" y1=\"%4.1f\" y2=\"%4.1f\" class=\"pstate\"/>\n" , +fprintf (svgfile,"<line x1=\"%.8f\" x2=\"%.8f\" y1=\"%.1f\" y2=\"%.1f\" class=\"pstate\"/>\n" ,time2pixels (start),time2pixels (end), height, height); -fprintf (svgfile,"<text x=\"%4.8f\" y=\"%4.8f\" font-size=\"0.25pt\">%s</text>\n" , +fprintf (svgfile,"<text x=\"%.8f\" y=\"%.8f\" font-size=\"0.25pt\">%s</text>\n" ,time2pixels (start), height+0.9 ,HzToHuman (freq));fprintf (svgfile,"</g>\n" );
@@ -435,32 +435,32 @@ void svg_partial_wakeline(u64 start, int row1, char *desc1, int row2, char *descif (row1 < row2) {if (row1) { -fprintf (svgfile,"<line x1=\"%4.8f\" y1=\"%4.2f\" x2=\"%4.8f\" y2=\"%4.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" , +fprintf (svgfile,"<line x1=\"%.8f\" y1=\"%.2f\" x2=\"%.8f\" y2=\"%.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" ,time2pixels (start), row1 *SLOT_MULT +SLOT_HEIGHT ,time2pixels (start), row1 *SLOT_MULT +SLOT_HEIGHT +SLOT_MULT /32 );if (desc2) -fprintf (svgfile,"<g transform=\"translate(%4.8f,%4.8f)\"><text transform=\"rotate(90)\" font-size=\"0.02pt\">%s ></text></g>\n" , +fprintf (svgfile,"<g transform=\"translate(%.8f,%.8f)\"><text transform=\"rotate(90)\" font-size=\"0.02pt\">%s ></text></g>\n" ,time2pixels (start), row1 *SLOT_MULT +SLOT_HEIGHT +SLOT_HEIGHT /48 , desc2); }if (row2) { -fprintf (svgfile,"<line x1=\"%4.8f\" y1=\"%4.2f\" x2=\"%4.8f\" y2=\"%4.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" , +fprintf (svgfile,"<line x1=\"%.8f\" y1=\"%.2f\" x2=\"%.8f\" y2=\"%.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" ,time2pixels (start), row2 *SLOT_MULT -SLOT_MULT /32 ,time2pixels (start), row2 *SLOT_MULT );if (desc1) -fprintf (svgfile,"<g transform=\"translate(%4.8f,%4.8f)\"><text transform=\"rotate(90)\" font-size=\"0.02pt\">%s ></text></g>\n" , +fprintf (svgfile,"<g transform=\"translate(%.8f,%.8f)\"><text transform=\"rotate(90)\" font-size=\"0.02pt\">%s ></text></g>\n" ,time2pixels (start), row2 *SLOT_MULT -SLOT_MULT /32 , desc1); } }else {if (row2) { -fprintf (svgfile,"<line x1=\"%4.8f\" y1=\"%4.2f\" x2=\"%4.8f\" y2=\"%4.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" , +fprintf (svgfile,"<line x1=\"%.8f\" y1=\"%.2f\" x2=\"%.8f\" y2=\"%.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" ,time2pixels (start), row2 *SLOT_MULT +SLOT_HEIGHT ,time2pixels (start), row2 *SLOT_MULT +SLOT_HEIGHT +SLOT_MULT /32 );if (desc1) -fprintf (svgfile,"<g transform=\"translate(%4.8f,%4.8f)\"><text transform=\"rotate(90)\" font-size=\"0.02pt\">%s <</text></g>\n" , +fprintf (svgfile,"<g transform=\"translate(%.8f,%.8f)\"><text transform=\"rotate(90)\" font-size=\"0.02pt\">%s <</text></g>\n" ,time2pixels (start), row2 *SLOT_MULT +SLOT_HEIGHT +SLOT_MULT /48 , desc1); }if (row1) { -fprintf (svgfile,"<line x1=\"%4.8f\" y1=\"%4.2f\" x2=\"%4.8f\" y2=\"%4.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" , +fprintf (svgfile,"<line x1=\"%.8f\" y1=\"%.2f\" x2=\"%.8f\" y2=\"%.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" ,time2pixels (start), row1 *SLOT_MULT -SLOT_MULT /32 ,time2pixels (start), row1 *SLOT_MULT );if (desc2) -fprintf (svgfile,"<g transform=\"translate(%4.8f,%4.8f)\"><text transform=\"rotate(90)\" font-size=\"0.02pt\">%s <</text></g>\n" , +fprintf (svgfile,"<g transform=\"translate(%.8f,%.8f)\"><text transform=\"rotate(90)\" font-size=\"0.02pt\">%s <</text></g>\n" ,time2pixels (start), row1 *SLOT_MULT -SLOT_HEIGHT /32 , desc2); } }
@@ -468,7 +468,7 @@ void svg_partial_wakeline(u64 start, int row1, char *desc1, int row2, char *descif (row2 > row1) height +=SLOT_HEIGHT ;if (row1) -fprintf (svgfile,"<circle cx=\"%4.8f\" cy=\"%4.2f\" r = \"0.01\" style=\"fill:rgb(32,255,32)\"/>\n" , +fprintf (svgfile,"<circle cx=\"%.8f\" cy=\"%.2f\" r = \"0.01\" style=\"fill:rgb(32,255,32)\"/>\n" ,time2pixels (start), height);fprintf (svgfile,"</g>\n" );
@@ -488,16 +488,16 @@ void svg_wakeline(u64 start, int row1, int row2, const char *backtrace)fprintf (svgfile,"<desc>%s</desc>\n" , backtrace);if (row1 < row2) -fprintf (svgfile,"<line x1=\"%4.8f\" y1=\"%4.2f\" x2=\"%4.8f\" y2=\"%4.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" , +fprintf (svgfile,"<line x1=\"%.8f\" y1=\"%.2f\" x2=\"%.8f\" y2=\"%.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" ,time2pixels (start), row1 *SLOT_MULT +SLOT_HEIGHT ,time2pixels (start), row2 *SLOT_MULT );else -fprintf (svgfile,"<line x1=\"%4.8f\" y1=\"%4.2f\" x2=\"%4.8f\" y2=\"%4.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" , +fprintf (svgfile,"<line x1=\"%.8f\" y1=\"%.2f\" x2=\"%.8f\" y2=\"%.2f\" style=\"stroke:rgb(32,255,32);stroke-width:0.009\"/>\n" ,time2pixels (start), row2 *SLOT_MULT +SLOT_HEIGHT ,time2pixels (start), row1 *SLOT_MULT ); height = row1 *SLOT_MULT ;if (row2 > row1) height +=SLOT_HEIGHT ; -fprintf (svgfile,"<circle cx=\"%4.8f\" cy=\"%4.2f\" r = \"0.01\" style=\"fill:rgb(32,255,32)\"/>\n" , +fprintf (svgfile,"<circle cx=\"%.8f\" cy=\"%.2f\" r = \"0.01\" style=\"fill:rgb(32,255,32)\"/>\n" ,time2pixels (start), height);fprintf (svgfile,"</g>\n" );
@@ -515,9 +515,9 @@ void svg_interrupt(u64 start, int row, const char *backtrace)if (backtrace)fprintf (svgfile,"<desc>%s</desc>\n" , backtrace); -fprintf (svgfile,"<circle cx=\"%4.8f\" cy=\"%4.2f\" r = \"0.01\" style=\"fill:rgb(255,128,128)\"/>\n" , +fprintf (svgfile,"<circle cx=\"%.8f\" cy=\"%.2f\" r = \"0.01\" style=\"fill:rgb(255,128,128)\"/>\n" ,time2pixels (start), row *SLOT_MULT ); -fprintf (svgfile,"<circle cx=\"%4.8f\" cy=\"%4.2f\" r = \"0.01\" style=\"fill:rgb(255,128,128)\"/>\n" , +fprintf (svgfile,"<circle cx=\"%.8f\" cy=\"%.2f\" r = \"0.01\" style=\"fill:rgb(255,128,128)\"/>\n" ,time2pixels (start), row *SLOT_MULT +SLOT_HEIGHT );fprintf (svgfile,"</g>\n" );
@@ -528,7 +528,7 @@ void svg_text(int Yslot, u64 start, const char *text)if (!svgfile)return ; -fprintf (svgfile,"<text x=\"%4.8f\" y=\"%4.8f\">%s</text>\n" , +fprintf (svgfile,"<text x=\"%.8f\" y=\"%.8f\">%s</text>\n" ,time2pixels (start), Yslot *SLOT_MULT +SLOT_HEIGHT /2 , text); }
@@ -537,9 +537,9 @@ static void svg_legenda_box(int X, const char *text, const char *style)double boxsize; boxsize =SLOT_HEIGHT /2 ; -fprintf (svgfile,"<rect x=\"%i\" width=\"%4.8f\" y=\"0\" height=\"%4.1f\" class=\"%s\"/>\n" , +fprintf (svgfile,"<rect x=\"%i\" width=\"%.8f\" y=\"0\" height=\"%.1f\" class=\"%s\"/>\n" ,X , boxsize, boxsize, style); -fprintf (svgfile,"<text transform=\"translate(%4.8f, %4.8f)\" font-size=\"%4.8fpt\">%s</text>\n" , +fprintf (svgfile,"<text transform=\"translate(%.8f, %.8f)\" font-size=\"%.8fpt\">%s</text>\n" ,X + boxsize +5 , boxsize,0.8 * boxsize, text); }
@@ -579,7 +579,7 @@ void svg_time_grid(void) color =128 ; } -fprintf (svgfile,"<line x1=\"%4.8f\" y1=\"%4.2f\" x2=\"%4.8f\" y2=\"%" PRIu64"\" style=\"stroke:rgb(%i,%i,%i);stroke-width:%1.3f\"/>\n" , +fprintf (svgfile,"<line x1=\"%.8f\" y1=\"%.2f\" x2=\"%.8f\" y2=\"%" PRIu64"\" style=\"stroke:rgb(%i,%i,%i);stroke-width:%.3f\"/>\n" ,time2pixels (i),SLOT_MULT /2 ,time2pixels (i), total_height, color, color, color, thickness); i +=10000000 ;
Signature · 1 line
1.8.3.1
Jiri Olsa
reviewerPATCH 2/4 perf timechart: Implement IO mode
In reply to Jiri OlsaFrom: Stanislav Fomichev <[email protected]>
Currently, timechart records only scheduler and CPU events (task switches, running times, CPU power states, etc); this commit adds IO mode which makes it possible to record IO (disk, network) activity. In this mode perf timechart will generate SVG with IO charts (writes, reads, tx, rx, polls).
--- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 620 +++++++++++++++++++++++++++- tools/perf/util/svghelper.c | 98 ++++- tools/perf/util/svghelper.h | 6 +- 4 files changed, 725 insertions(+), 24 deletions(-)
tools/perf/Documentation/perf-timechart.txt +23 -2
@@ -15,10 +15,20 @@ DESCRIPTION There are two variants of perf timechart: 'perf timechart record <command>' to record the system level events - of an arbitrary workload. + of an arbitrary workload. By default timechart records only scheduler + and CPU events (task switches, running times, CPU power states, etc), + but it's possible to record IO (disk, network) activity using -I argument. 'perf timechart' to turn a trace into a Scalable Vector Graphics file, - that can be viewed with popular SVG viewers such as 'Inkscape'. + that can be viewed with popular SVG viewers such as 'Inkscape'. Depending + on the events in the perf.data file, timechart will contain scheduler/cpu + events or IO events. + + In IO mode, every bar has two charts: upper and lower. + Upper bar shows incoming events (disk reads, ingress network packets). + Lower bar shows outgoing events (disk writes, egress network packets). + There are also poll bars which show how much time application spent + in poll/epoll/select syscalls. TIMECHART OPTIONS -----------------
@@ -63,6 +73,9 @@ RECORD OPTIONS -T:: --tasks-only:: Record only tasks-related events +-I:: +--io-only:: + Record only io-related events -g:: --callchain:: Do call-graph (stack chain/backtrace) recording
@@ -87,6 +100,14 @@ Record system-wide timechart: $ perf timechart --highlight gcc +Record system-wide IO events: + + $ perf timechart record -I + + then generate timechart: + + $ perf timechart + SEE ALSO -------- linkperf:perf-record[1]
tools/perf/builtin-timechart.c +602 -18
725 lines not on this page · raw message
tools/perf/util/svghelper.c +95 -3
136 lines not on this page · raw message
tools/perf/util/svghelper.h +5 -1
@@ -4,6 +4,9 @@#include <linux/types.h> extern void open_svg (const char *filename,int cpus,int rows,u64 start,u64 end); +extern void svg_ubox (int Yslot,u64 start,u64 end,double height,const char *type,int fd,int err,int merges); +extern void svg_lbox (int Yslot,u64 start,u64 end,double height,const char *type,int fd,int err,int merges); +extern void svg_fbox (int Yslot,u64 start,u64 end,double height,const char *type,int fd,int err,int merges);extern void svg_box (int Yslot,u64 start,u64 end,const char *type);extern void svg_blocked (int Yslot,int cpu,u64 start,u64 end,const char *backtrace);extern void svg_running (int Yslot,int cpu,u64 start,u64 end,const char *backtrace);
@@ -16,7 +19,8 @@ extern void svg_cstate(int cpu, u64 start, u64 end, int type);extern void svg_pstate (int cpu,u64 start,u64 end,u64 freq); -extern void svg_time_grid (void ); +extern void svg_time_grid (double min_thickness); +extern void svg_io_legenda (void );extern void svg_legenda (void );extern void svg_wakeline (u64 start,int row1,int row2,const char *backtrace);extern void svg_partial_wakeline (u64 start,int row1,char *desc1,int row2,char *desc2,const char *backtrace);
Signature · 1 line
1.8.3.1
Jiri Olsa
reviewerPATCH 3/4 perf timechart: Conditionally update start_time on fork
In reply to Jiri OlsaFrom: Stanislav Fomichev <[email protected]>
We don't need to overwrite current task start_time on fork, so update it only if it's zero.
--- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-timechart.c +1 -1
@@ -242,7 +242,7 @@ static void pid_fork(struct timechart *tchart, int pid, int ppid, u64 timestamp)pid_set_comm (tchart, pid, pp->current->comm); p->start_time = timestamp; -if (p->current) { +if (p->current && !p->current->start_time) { p->current->start_time = timestamp; p->current->state_since = timestamp; }
Signature · 1 line
1.8.3.1
Jiri Olsa
reviewerPATCH 4/4 perf timechart: Add more options to IO mode
In reply to Jiri OlsaFrom: Stanislav Fomichev <[email protected]>
--io-skip-eagain - don't show EAGAIN errors
--io-min-time - make small io bursts visible
--io-merge-dist - merge adjacent events
--- tools/perf/Documentation/perf-timechart.txt | 13 +++++ tools/perf/builtin-timechart.c | 75 ++++++++++++++++++++++++++++- 2 files changed, 86 insertions(+), 2 deletions(-)
tools/perf/Documentation/perf-timechart.txt +13 -0
@@ -64,6 +64,19 @@ TIMECHART OPTIONS duration or tasks with given name. If number is given it's interpreted as number of nanoseconds. If non-numeric string is given it's interpreted as task name. +--io-skip-eagain:: + Don't draw EAGAIN IO events. +--io-min-time=<nsecs>:: + Draw small events as if they lasted min-time. Useful when you need + to see very small and fast IO. It's possible to specify ms or us + suffix to specify time in milliseconds or microseconds. + Default value is 1ms. +--io-merge-dist=<nsecs>:: + Merge events that are merge-dist nanoseconds apart. + Reduces number of figures on the SVG and makes it more render-friendly. + It's possible to specify ms or us suffix to specify time in + milliseconds or microseconds. + Default value is 1us. RECORD OPTIONS --------------
tools/perf/builtin-timechart.c +73 -2
123 lines not on this page · raw message
Signature · 1 line
1.8.3.1
Quoted 34 lines · Jiri Olsa
hi Ingo,
please consider pullingthanks,
jirkaThe following changes since commit
8b5b584daf3b92fc5cdc83919e64231817d2f5a7:Merge tag 'perf-core-for-mingo' of
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perfinto perf/core (2014-07-05 11:29:32 +0200)are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.gittags/perf-core-for-mingofor you to fetch changes up to
d243144af0b52fc5164a0823194f29a5979e236c:perf timechart: Add more options to IO mode (2014-07-10 00:22:54 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:. Add IO mode into timechart command (Stanislav Fomichev)
Signed-off-by Jiri Olsa <[email protected]>----------------------------------------------------------------
Stanislav Fomichev (4):
perf timechart: Fix rendering in Firefox
perf timechart: Implement IO mode
perf timechart: Conditionally updatestart_timeon fork perf timechart: Add more options to IO mode
Quoted 5 lines
tools/perf/Documentation/perf-timechart.txt | 38 +- tools/perf/builtin-timechart.c | 693 +++++++++++++++++++++++++++- tools/perf/util/svghelper.c | 168 +++++-- tools/perf/util/svghelper.h | 6 +- 4 files changed, 845 insertions(+), 60 deletions(-)
Pulled, thanks a lot Jiri!
Ingo