perf stat: Pass PERF_STAT_RUN environment variable for each run
Namhyung Kim
maintainerPATCH 1/1 perf stat: Pass PERF_STAT_RUN environment variable for each run
When perf stat runs multiple times via -r option, it's sometimes useful for a workload to know which run it executing. So pass new PERF_STAT_RUN environment variable to the workload for each run (starting from 1).
--- tools/perf/builtin-stat.c | 8 +++++--- tools/perf/util/evlist.c | 10 +++++++++- 2 files changed, 14 insertions(+), 4 deletions(-)
tools/perf/builtin-stat.c +5 -3
@@ -144,6 +144,8 @@ static struct timespec ref_time;static struct cpu_map *aggr_map;static int (*aggr_get_id)(struct cpu_map *m,int cpu); +int stat_run; +static volatile int done =0 ;struct perf_stat {
@@ -1674,7 +1676,7 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)"perf stat [<options>] [<command>]" , NULL }; -int status = -EINVAL , run_idx; +int status = -EINVAL ;const char *mode;setlocale (LC_ALL ,"" );
@@ -1812,10 +1814,10 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)signal (SIGABRT , skip_signal); status =0 ; -for (run_idx =0 ; forever || run_idx < run_count; run_idx++) { +for (stat_run =1 ; forever || stat_run <= run_count; stat_run++) {if (run_count !=1 && verbose)fprintf (output,"[ perf stat: executing run #%d ... ]\n" , - run_idx +1 ); + stat_run); status =run_perf_stat (argc, argv);if (forever && status !=-1 ) {
tools/perf/util/evlist.c +9 -1
@@ -1031,6 +1031,7 @@ out_err:return err; } +extern int stat_run;int perf_evlist__prepare_workload (struct perf_evlist *evlist,struct target *target,const char *argv[],bool pipe_output,void (*exec_error)(int signo,siginfo_t *info,void *ucontext))
@@ -1055,6 +1056,8 @@ int perf_evlist__prepare_workload(struct perf_evlist *evlist, struct target *tar }if (!evlist->workload.pid) { +char buf[32 ]; +if (pipe_output)dup2 (2 ,1 );
@@ -1075,7 +1078,12 @@ int perf_evlist__prepare_workload(struct perf_evlist *evlist, struct target *tarif (read (go_pipe[0 ], &bf,1 ) ==-1 )perror ("unable to read pipe" ); -execvp (argv[0 ], (char **)argv); +if (stat_run) { +snprintf (buf,sizeof (buf),"%d" , stat_run); +setenv ("PERF_STAT_RUN" , buf,1 ); + } + +execvpe (argv[0 ], (char **)argv, environ);if (exec_error) {union sigval val;
Signature · 1 line
2.0.1
Peter Zijlstra
maintainerQuoted 4 lines · Namhyung Kim
When perf stat runs multiple times via -r option, it's sometimes useful for a workload to know which run it executing. So pass new
PERF_STAT_RUNenvironment variable to the workload for each run (starting from 1).
This seems counter intuitive, runs should be _identical_ otherwise there's no point. That means the workload should very much _not_ know these things.
Namhyung Kim
maintainerHi Peter,
Quoted 9 lines · Peter Zijlstra
Quoted 4 lines · Namhyung Kim
When perf stat runs multiple times via -r option, it's sometimes useful for a workload to know which run it executing. So pass new
PERF_STAT_RUNenvironment variable to the workload for each run (starting from 1).This seems counter intuitive, runs should be _identical_ otherwise there's no point. That means the workload should very much _not_ know these things.
But I think it can be useful if a workload wants to save logfiles based on the iteration number for example. If it doesn't want, it can just ignore. :)
Thanks,
Namhyung
Peter Zijlstra
maintainerQuoted 9 lines · Namhyung Kim
Hi Peter,
Quoted 6 lines · Peter Zijlstra
Quoted 4 lines · Namhyung Kim
When perf stat runs multiple times via -r option, it's sometimes useful for a workload to know which run it executing. So pass new
PERF_STAT_RUNenvironment variable to the workload for each run (starting from 1).
Quoted 7 lines
Quoted 3 lines
This seems counter intuitive, runs should be _identical_ otherwise there's no point. That means the workload should very much _not_ know these things.
But I think it can be useful if a workload wants to save logfiles based on the iteration number for example. If it doesn't want, it can just ignore. :)
That's the wrong way around. Also, there's --pre and --post hooks to preserve logfiles if you really have to do that kind of thing.
Arnaldo Carvalho de Melo
maintainerEm Thu, Jul 17, 2014 at 10:40:11AM +0200, Peter Zijlstra escreveu:
Quoted 12 lines · Namhyung Kim
Quoted 10 lines · Peter Zijlstra
Quoted 9 lines · Namhyung Kim
Quoted 4 lines
When perf stat runs multiple times via -r option, it's sometimes useful for a workload to know which run it executing. So pass new
PERF_STAT_RUNenvironment variable to the workload for each run (starting from 1).This seems counter intuitive, runs should be _identical_ otherwise there's no point. That means the workload should very much _not_ know these things.
Quoted 6 lines
Quoted 3 lines
But I think it can be useful if a workload wants to save logfiles based on the iteration number for example. If it doesn't want, it can just ignore. :)
That's the wrong way around. Also, there's --pre and --post hooks to preserve logfiles if you really have to do that kind of thing.
Agreed, one can script this using --pre or --post if needed.
- Arnaldo
Namhyung Kim
maintainerHi Arnaldo and Peter,
Quoted 13 lines · Arnaldo Carvalho de Melo
Em Thu, Jul 17, 2014 at 10:40:11AM +0200, Peter Zijlstra escreveu:
Quoted 11 lines · Namhyung Kim
Quoted 10 lines · Peter Zijlstra
Quoted 9 lines · Namhyung Kim
Quoted 4 lines
When perf stat runs multiple times via -r option, it's sometimes useful for a workload to know which run it executing. So pass new
PERF_STAT_RUNenvironment variable to the workload for each run (starting from 1).This seems counter intuitive, runs should be _identical_ otherwise there's no point. That means the workload should very much _not_ know these things.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
But I think it can be useful if a workload wants to save logfiles based on the iteration number for example. If it doesn't want, it can just ignore. :)
That's the wrong way around. Also, there's --pre and --post hooks to preserve logfiles if you really have to do that kind of thing.
Agreed, one can script this using --pre or --post if needed.
Hmm... okay, I'll drop this then.
Thanks,
Namhyung