Skip to contentSkip to conversation

rcu: Fix build failure

PATCH In review Pranith Kumar 2 participants 2 messages Jul 18, 2014 – Jul 19, 2014 RCU

lore
Share & tools
lore

Pranith Kumar

author
#0 lore raw

PATCH 1/1 rcu: Fix build failure

Hi Paul,

While running the kvm rcutorture test scripts, I encountered a build failure caused by

Commit 918179699e4a ("rcu: Don't keep timekeeping CPU tick running for non-nohz_full= CPUs")

This commit fixes the failure. This is on top of paul/rcu/dev.

Signed-off-by Pranith Kumar <[email protected]>
---
 kernel/rcu/tree_plugin.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tree_plugin.h +1 -1
index 5591276..eaa32e4 100644
@@ -2795,7 +2795,7 @@ static void rcu_sysidle_exit(struct rcu_dynticks *rdtp, int irq)
 	 * CPU to keep a tick on our behalf.  We assume that the timekeeping
 	 * CPU is also a nohz_full= CPU.
 	 */
-	if (!tick_nohz_full_cpu(cpu))
+	if (!tick_nohz_full_cpu(smp_processor_id()))
 		return;
 
 	/* Update system-idle state: We are clearly no longer fully idle! */
Signature · 1 line
1.9.1
#1 lore raw
Quoted 18 lines · Pranith Kumar

Hi Paul,

While running the kvm rcutorture test scripts, I encountered a build failure caused by

Commit 918179699e4a ("rcu: Don't keep timekeeping CPU tick running for non-nohz_full= CPUs")

This commit fixes the failure. This is on top of paul/rcu/dev.

Signed-off-by Pranith Kumar <[email protected]>
---
 kernel/rcu/tree_plugin.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tree_plugin.h +0 -0
index 5591276..eaa32e4 100644

kernel/rcu/tree_plugin.h static void rcu_sysidle_exit(struct rcu_dynticks *rdtp, int irq) · line 2798

Quoted 5 lines
kernel/rcu/tree_plugin.h +1 -1
@@ -2795,7 +2795,7 @@ static void rcu_sysidle_exit(struct rcu_dynticks *rdtp, int irq)
 	 * CPU to keep a tick on our behalf.  We assume that the timekeeping
 	 * CPU is also a nohz_full= CPU.
 	 */
-	if (!tick_nohz_full_cpu(cpu))
+	if (!tick_nohz_full_cpu(smp_processor_id()))

Good catch, but please see 770d957e (rcu: Don't keep timekeeping CPU tick running for non-nohz_full= CPUs). ;-)

Thanx, Paul

Quoted 10 lines
kernel/rcu/tree_plugin.h +0 -0
 		return;
 
 	/* Update system-idle state: We are clearly no longer fully idle! */
Signature · 6 lines
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/