Skip to contentSkip to conversation

mm/m68k: Eliminate memset after alloc_bootmem_pages

PATCH Applied Himangi Saraogi 2 participants 3 messages Jul 19, 2014 – Nov 10, 2014 m68k architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/m68k: Eliminate memset after alloc_bootmem_pages

alloc_bootmem and related functions always return a zeroed region of memory. Thus a memset after calls to these functions is unnecessary.

The following Coccinelle semantic patch was used for making the change:

@@
expression E,E1;
@@

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...) ... when != E
- memset(E,0,E1);

---
To send to: Geert Uytterhoeven <[email protected]>,[email protected],[email protected]

 arch/m68k/mm/init.c | 1 -
 1 file changed, 1 deletion(-)
arch/m68k/mm/init.c +0 -1
index acaff6a..b09a3cb 100644
@@ -94,7 +94,6 @@ void __init paging_init(void)
 	high_memory = (void *) end_mem;
 
 	empty_zero_page = alloc_bootmem_pages(PAGE_SIZE);
-	memset(empty_zero_page, 0, PAGE_SIZE);
 
 	/*
 	 * Set up SFC/DFC registers (user data space).
Signature · 1 line
1.9.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Himangi Saraogi

alloc_bootmem and related functions always return a zeroed region of memory. Thus a memset after calls to these functions is unnecessary.

The following Coccinelle semantic patch was used for making the change:

@@
expression E,E1;
@@

Quoted 6 lines

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...) ... when != E
- memset(E,0,E1);

Thanks, applied and queued for v3.19.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

maintainer Applied
#2 lore raw
In reply to Himangi Saraogi
Quoted 9 lines · Himangi Saraogi

alloc_bootmem and related functions always return a zeroed region of memory. Thus a memset after calls to these functions is unnecessary.

The following Coccinelle semantic patch was used for making the change:

@@
expression E,E1;
@@

Quoted 6 lines

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...) ... when != E
- memset(E,0,E1);

Thanks, applied and queued for v3.19.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds