Skip to contentSkip to conversation

libuv: new package

PATCH New Gustavo Zacarias 3 participants 3 messages Jul 18, 2014 – Jul 19, 2014

lore
Share & tools
lore

Gustavo Zacarias

author
#0 lore raw

PATCH 1/1 libuv: new package

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/Config.in       |  1 +
 package/libuv/Config.in | 14 ++++++++++++++
 package/libuv/libuv.mk  | 22 ++++++++++++++++++++++
 3 files changed, 37 insertions(+)
 create mode 100644 package/libuv/Config.in
 create mode 100644 package/libuv/libuv.mk
package/Config.in +1 -0
index 0828172..ae3dd0f 100644
@@ -849,6 +849,7 @@ menu "Other"
 	source "package/libuci/Config.in"
 	source "package/libunwind/Config.in"
 	source "package/liburcu/Config.in"
+	source "package/libuv/Config.in"
 	source "package/linux-pam/Config.in"
 	source "package/lttng-libust/Config.in"
 	source "package/mpc/Config.in"
package/libuv/Config.in new file +14 -0
new file mode 100644
index 0000000..6083837
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_LIBUV
+	bool "libuv"
+	depends on BR2_INET_IPV6
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_USE_MMU # fork()
+	help
+	  libuv is a multi-platform support library with a focus
+	  on asynchronous I/O.
+
+	  https://github.com/joyent/libuv
+
+comment "libuv needs a toolchain w/ IPv6, threads"
+	depends on !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_USE_MMU
package/libuv/libuv.mk new file +22 -0
new file mode 100644
index 0000000..6074e9c
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libuv
+#
+################################################################################
+
+LIBUV_VERSION = v0.11.26
+LIBUV_SITE = $(call github,joyent,libuv,$(LIBUV_VERSION))
+LIBUV_DEPENDENCIES = host-pkgconf
+LIBUV_INSTALL_STAGING = YES
+LIBUV_AUTORECONF = YES
+LIBUV_LICENSE = BSD-2c, BSD-3c, ISC, MIT
+LIBUV_LICENSE_FILES = LICENSE
+
+# Tweaked autogen.sh
+define LIBUV_FIXUP_AUTOGEN
+	echo "m4_define([UV_EXTRA_AUTOMAKE_FLAGS], [serial-tests])" \
+	        >$(@D)/m4/libuv-extra-automake-flags.m4
+endef
+LIBUV_POST_PATCH_HOOKS += LIBUV_FIXUP_AUTOGEN
+
+$(eval $(autotools-package))
Signature · 1 line
1.8.5.5
#1 lore raw

PATCH 1/1 libuv: new package

Gustavo, All,

On 2014-07-18 17:24 -0300, Gustavo Zacarias spake thusly:

Quoted 1 line
Signed-off-by Gustavo Zacarias <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

However, I have a small comment...

[--SNIP--]

Quoted 11 lines
package/libuv/libuv.mk new file +5 -0
new file mode 100644
index 0000000..6074e9c
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libuv
+#
+################################################################################

package/libuv/libuv.mk line 15

Quoted 10 lines
package/libuv/libuv.mk new file +10 -0
+
+LIBUV_VERSION = v0.11.26
+LIBUV_SITE = $(call github,joyent,libuv,$(LIBUV_VERSION))
+LIBUV_DEPENDENCIES = host-pkgconf
+LIBUV_INSTALL_STAGING = YES
+LIBUV_AUTORECONF = YES
+LIBUV_LICENSE = BSD-2c, BSD-3c, ISC, MIT
+LIBUV_LICENSE_FILES = LICENSE
+
+# Tweaked autogen.sh

This is pretty terse, and slightly recondite. What about:

# Upstream needs tests to be run sequentially. This is the default # in automake 1.11 and before, but not starting in 1.12. To maintain # sequentiality in 1.12 and later, the automake option 'serial-tests' # must be used, Unfortunately, it is not recognised by 1.11 and # before. So upstream only adds it conditionally. We use automake # 1.14, so we need it.

Alternatively, I'm OK with adding that in the commit log instead of in a comment.

Regards,
Yann E. MORIN.

Quoted 14 lines
package/libuv/libuv.mk new file +7 -0
+define LIBUV_FIXUP_AUTOGEN
+	echo "m4_define([UV_EXTRA_AUTOMAKE_FLAGS], [serial-tests])" \
+	        >$(@D)/m4/libuv-extra-automake-flags.m4
+endef
+LIBUV_POST_PATCH_HOOKS += LIBUV_FIXUP_AUTOGEN
+
+$(eval $(autotools-package))
Signature · 6 lines
1.8.5.5

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 libuv: new package

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 8 lines · Gustavo Zacarias
Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/Config.in       |  1 +
 package/libuv/Config.in | 14 ++++++++++++++
 package/libuv/libuv.mk  | 22 ++++++++++++++++++++++
 3 files changed, 37 insertions(+)
 create mode 100644 package/libuv/Config.in
 create mode 100644 package/libuv/libuv.mk

Thanks, applied, after taking into account Yann's suggestion.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com