xlib_libFS: Add missing host-pkgconf dependency

PATCH New Bernd Kuhls 3 participants 6 messages Jul 19, 2014 – Jul 20, 2014

lore

Share & tools

lore

Bernd Kuhls

author

2014-07-19 22:41 UTC #0 lore raw

PATCH 1/2 xlib_libFS: Add missing host-pkgconf dependency

Fixes compile error:

checking for FS... configure: error: in `/home/br/br/output/build/xlib_libFS-1.0.6':
configure: error: The pkg-config script could not be found or is too old. Make sure it is in your PATH or set the PKG_CONFIG environment variable to the full path to pkg-config.

Alternatively, you may set the environment variables FS_CFLAGS and FS_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.

To get pkg-config, see <http://pkg-config.freedesktop.org/>.
See `config.log' for more details

using this minimal defconfig

BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XAPP_XFS=y

Signed-off-by Bernd Kuhls <[email protected]>

---
 package/x11r7/xlib_libFS/xlib_libFS.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/x11r7/xlib_libFS/xlib_libFS.mk +1 -1

index 19d2800..d7dcb74 100644
@@ -10,7 +10,7 @@ XLIB_LIBFS_SITE = http://xorg.freedesktop.org/releases/individual/lib
 XLIB_LIBFS_LICENSE = MIT
 XLIB_LIBFS_LICENSE_FILES = COPYING
 XLIB_LIBFS_INSTALL_STAGING = YES
-XLIB_LIBFS_DEPENDENCIES = xlib_xtrans xproto_xproto xproto_fontsproto
+XLIB_LIBFS_DEPENDENCIES = xlib_xtrans xproto_xproto xproto_fontsproto host-pkgconf
 XLIB_LIBFS_CONF_OPT = --disable-malloc0returnsnull
 
 $(eval $(autotools-package))

Signature · 1 line

1.7.10.4

Bernd Kuhls

author

2014-07-19 22:41 UTC #1 lore raw

PATCH 2/2 xapp_xfs: Fix compile errors after libXfont 1.5.0 update

Fixes
http://autobuild.buildroot.net/results/385/385cffbab4261337afa449998aa7457a8142db92/

Signed-off-by Bernd Kuhls <[email protected]>

---
 package/x11r7/xapp_xfs/xapp_xfs.mk |   13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

package/x11r7/xapp_xfs/xapp_xfs.mk +10 -3

index 0907fc3..bd5ac55 100644
@@ -4,11 +4,18 @@
 #
 ################################################################################
 
-XAPP_XFS_VERSION = 1.1.3
-XAPP_XFS_SOURCE = xfs-$(XAPP_XFS_VERSION).tar.bz2
-XAPP_XFS_SITE = http://xorg.freedesktop.org/releases/individual/app
+#XAPP_XFS_VERSION = 1.1.3
+#XAPP_XFS_SOURCE = xfs-$(XAPP_XFS_VERSION).tar.bz2
+#XAPP_XFS_SITE = http://xorg.freedesktop.org/releases/individual/app
 XAPP_XFS_LICENSE = MIT
 XAPP_XFS_LICENSE_FILES = COPYING
 XAPP_XFS_DEPENDENCIES = xlib_libFS xlib_libXfont xproto_fontsproto
 
+# this section is needed to fix compile errors after libXfont 1.5.0 update
+# it can be removed after the release of the next version of xapp_xfs
+XAPP_XFS_VERSION = 1c8459eafc04997751ae3d200d0ec91e43e19b5b
+XAPP_XFS_SITE = git://anongit.freedesktop.org/xorg/app/xfs
+XAPP_XFS_AUTORECONF = YES
+XAPP_XFS_DEPENDENCIES += xfont_font-util
+
 $(eval $(autotools-package))

Signature · 1 line

1.7.10.4

Bernd Kuhls

author

2014-07-19 22:46 UTC #2 lore raw

PATCH 2/2 xapp_xfs: Fix compile errors after libXfont 1.5.0 update

Bernd Kuhls <[email protected]> wrote in news:1405809671-4609-2-git-send-email-bernd.kuhls at t-online.de:

package/x11r7/xapp_xfs/xapp_xfs.mk line 9

Quoted 6 lines

package/x11r7/xapp_xfs/xapp_xfs.mk +3 -3

-XAPP_XFS_VERSION = 1.1.3
-XAPP_XFS_SOURCE = xfs-$(XAPP_XFS_VERSION).tar.bz2
-XAPP_XFS_SITE = http://xorg.freedesktop.org/releases/individual/app
+#XAPP_XFS_VERSION = 1.1.3
+#XAPP_XFS_SOURCE = xfs-$(XAPP_XFS_VERSION).tar.bz2
+#XAPP_XFS_SITE = http://xorg.freedesktop.org/releases/individual/app

Hi,

I had to cherry-pick four upstream patches to make 1.1.3 compile so I chose to use their git repo, that?s the reason I left the old lines commented out so we can easily revert the git code added by this patch. I hope this is ok.

Regards, Bernd

Yann E. MORIN

2014-07-19 22:49 UTC #3 lore raw

PATCH 2/2 xapp_xfs: Fix compile errors after libXfont 1.5.0 update

In reply to Bernd Kuhls

Bernd, All,

On 2014-07-20 00:41 +0200, Bernd Kuhls spake thusly:

Quoted 22 lines

Fixes
http://autobuild.buildroot.net/results/385/385cffbab4261337afa449998aa7457a8142db92/

Signed-off-by Bernd Kuhls <[email protected]>

---
 package/x11r7/xapp_xfs/xapp_xfs.mk |   13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

package/x11r7/xapp_xfs/xapp_xfs.mk +3 -3

index 0907fc3..bd5ac55 100644
@@ -4,11 +4,18 @@
 #
 ################################################################################
 
-XAPP_XFS_VERSION = 1.1.3
-XAPP_XFS_SOURCE = xfs-$(XAPP_XFS_VERSION).tar.bz2
-XAPP_XFS_SITE = http://xorg.freedesktop.org/releases/individual/app
+#XAPP_XFS_VERSION = 1.1.3
+#XAPP_XFS_SOURCE = xfs-$(XAPP_XFS_VERSION).tar.bz2
+#XAPP_XFS_SITE = http://xorg.freedesktop.org/releases/individual/app

package/x11r7/xapp_xfs/xapp_xfs.mk line 19

Quoted 10 lines

package/x11r7/xapp_xfs/xapp_xfs.mk +6 -0

 XAPP_XFS_LICENSE = MIT
 XAPP_XFS_LICENSE_FILES = COPYING
 XAPP_XFS_DEPENDENCIES = xlib_libFS xlib_libXfont xproto_fontsproto
 
+# this section is needed to fix compile errors after libXfont 1.5.0 update
+# it can be removed after the release of the next version of xapp_xfs
+XAPP_XFS_VERSION = 1c8459eafc04997751ae3d200d0ec91e43e19b5b
+XAPP_XFS_SITE = git://anongit.freedesktop.org/xorg/app/xfs
+XAPP_XFS_AUTORECONF = YES
+XAPP_XFS_DEPENDENCIES += xfont_font-util

Do not comment removed lines, just replace them with the new values.

When we want to revert to using a release, it is still easy enough.

Otherwise, looks good.

Regards,
Yann E. MORIN.

Quoted 9 lines

package/x11r7/xapp_xfs/xapp_xfs.mk +1 -0

+
 $(eval $(autotools-package))

Signature · 6 lines

1.7.10.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Yann E. MORIN

2014-07-19 22:47 UTC #4 lore raw

PATCH 1/2 xlib_libFS: Add missing host-pkgconf dependency

In reply to Bernd Kuhls

Bernd, All,

On 2014-07-20 00:41 +0200, Bernd Kuhls spake thusly:

Quoted 14 lines

Fixes compile error:
checking for FS... configure: error: in `/home/br/br/output/build/xlib_libFS-1.0.6':
configure: error: The pkg-config script could not be found or is too old. Make sure it is in your PATH or set the PKG_CONFIG environment variable to the full path to pkg-config.
Alternatively, you may set the environment variables FS_CFLAGS and FS_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.
To get pkg-config, see <http://pkg-config.freedesktop.org/>.
See `config.log' for more details

Quoted 7 lines

using this minimal defconfig
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XAPP_XFS=y
Signed-off-by Bernd Kuhls <[email protected]>

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 24 lines

---
 package/x11r7/xlib_libFS/xlib_libFS.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/x11r7/xlib_libFS/xlib_libFS.mk +1 -1

index 19d2800..d7dcb74 100644
@@ -10,7 +10,7 @@ XLIB_LIBFS_SITE = http://xorg.freedesktop.org/releases/individual/lib
 XLIB_LIBFS_LICENSE = MIT
 XLIB_LIBFS_LICENSE_FILES = COPYING
 XLIB_LIBFS_INSTALL_STAGING = YES
-XLIB_LIBFS_DEPENDENCIES = xlib_xtrans xproto_xproto xproto_fontsproto
+XLIB_LIBFS_DEPENDENCIES = xlib_xtrans xproto_xproto xproto_fontsproto host-pkgconf
 XLIB_LIBFS_CONF_OPT = --disable-malloc0returnsnull
 
 $(eval $(autotools-package))

Signature · 6 lines

1.7.10.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Thomas Petazzoni

Applied

2014-07-20 09:43 UTC #5 lore raw

PATCH 1/2 xlib_libFS: Add missing host-pkgconf dependency

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 14 lines · Bernd Kuhls

Fixes compile error:
checking for FS... configure: error: in `/home/br/br/output/build/xlib_libFS-1.0.6':
configure: error: The pkg-config script could not be found or is too old. Make sure it is in your PATH or set the PKG_CONFIG environment variable to the full path to pkg-config.
Alternatively, you may set the environment variables FS_CFLAGS and FS_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.
To get pkg-config, see <http://pkg-config.freedesktop.org/>.
See `config.log' for more details

Quoted 7 lines

using this minimal defconfig
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XAPP_XFS=y
Signed-off-by Bernd Kuhls <[email protected]>

Applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com