Skip to contentSkip to conversation

staging: input: sunkbd.c: Fix coding style

PATCH In review Bivolaru Catalin 3 participants 3 messages Jul 20, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: input: sunkbd.c: Fix coding style

Fix coding style with regard to missing spaces after , and the column limit that was violated after the first change.

---

The change was tested only by compilation.

drivers/input/keyboard/sunkbd.c +9 -8
index dc6bb9d..25ba6b6 100644
@@ -42,14 +42,15 @@ MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL");
 
 static unsigned char sunkbd_keycode[128] = {
-	  0,128,114,129,115, 59, 60, 68, 61, 87, 62, 88, 63,100, 64,112,
-	 65, 66, 67, 56,103,119, 99, 70,105,130,131,108,106,  1,  2,  3,
-	  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 41, 14,110,113, 98, 55,
-	116,132, 83,133,102, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
-	 26, 27,111,127, 71, 72, 73, 74,134,135,107,  0, 29, 30, 31, 32,
-	 33, 34, 35, 36, 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82,136,
-	104,137, 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,101,
-	 79, 80, 81,  0,  0,  0,138, 58,125, 57,126,109, 86, 78
+	  0, 128, 114, 129, 115,  59,  60,  68,  61,  87,  62,  88,  63, 100,
+	 64, 112,  65,  66,  67,  56, 103, 119,  99,  70, 105, 130, 131, 108,
+	106,   1,   2,   3,   4,   5,   6,   7,   8,   9,  10,  11,  12,  13,
+	 41,  14, 110, 113,  98,  55, 116, 132,  83, 133, 102,  15,  16,  17,
+	 18,  19,  20,  21,  22,  23,  24,  25,  26,  27, 111, 127,  71,  72,
+	 73,  74, 134, 135, 107,   0,  29,  30,  31,  32,  33,  34,  35,  36,
+	 37,  38,  39,  40,  43,  28,  96,  75,  76,  77,  82, 136, 104, 137,
+	 69,  42,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54, 101,
+	 79,  80,  81,   0,   0,   0, 138,  58, 125,  57, 126, 109,  86,  78
 };
 
 #define SUNKBD_CMD_RESET	0x1
#1 lore raw
Quoted 2 lines · Bivolaru Catalin

Fix coding style with regard to missing spaces after , and the column limit that was violated after the first change.

Some checkpatch errors should be ignored.

These are some of them.

This change doesn't make it easier to read or to find any array entry.

It's currently in groups of 16 (0x10).

This change would make it very difficult to find any particular entry.

It might make some sense to change the last line to add a trailing " 0, 0" entry as the compiler does to make it a bit clearer the table has 128 entries.

drivers/input/keyboard/sunkbd.c

Quoted 1 line
drivers/input/keyboard/sunkbd.c +0 -0

[]

Quoted 22 lines
drivers/input/keyboard/sunkbd.c +9 -8
@@ -42,14 +42,15 @@ MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL");
 
 static unsigned char sunkbd_keycode[128] = {
-	  0,128,114,129,115, 59, 60, 68, 61, 87, 62, 88, 63,100, 64,112,
-	 65, 66, 67, 56,103,119, 99, 70,105,130,131,108,106,  1,  2,  3,
-	  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 41, 14,110,113, 98, 55,
-	116,132, 83,133,102, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
-	 26, 27,111,127, 71, 72, 73, 74,134,135,107,  0, 29, 30, 31, 32,
-	 33, 34, 35, 36, 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82,136,
-	104,137, 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,101,
-	 79, 80, 81,  0,  0,  0,138, 58,125, 57,126,109, 86, 78
+	  0, 128, 114, 129, 115,  59,  60,  68,  61,  87,  62,  88,  63, 100,
+	 64, 112,  65,  66,  67,  56, 103, 119,  99,  70, 105, 130, 131, 108,
+	106,   1,   2,   3,   4,   5,   6,   7,   8,   9,  10,  11,  12,  13,
+	 41,  14, 110, 113,  98,  55, 116, 132,  83, 133, 102,  15,  16,  17,
+	 18,  19,  20,  21,  22,  23,  24,  25,  26,  27, 111, 127,  71,  72,
+	 73,  74, 134, 135, 107,   0,  29,  30,  31,  32,  33,  34,  35,  36,
+	 37,  38,  39,  40,  43,  28,  96,  75,  76,  77,  82, 136, 104, 137,
+	 69,  42,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54, 101,
+	 79,  80,  81,   0,   0,   0, 138,  58, 125,  57, 126, 109,  86,  78
 };
maintainer
#2 lore raw
Quoted 13 lines · Joe Perches
Quoted 2 lines · Bivolaru Catalin

Fix coding style with regard to missing spaces after , and the column limit that was violated after the first change.

Some checkpatch errors should be ignored.

These are some of them.

This change doesn't make it easier to read or to find any array entry.

It's currently in groups of 16 (0x10).

Quoted 7 lines

This change would make it very difficult to find any particular entry.

It might make some sense to change the last line to add a trailing " 0, 0" entry as the compiler does to make it a bit clearer the table has 128 entries.

I'd rather not change a thing in this table - it has been working as is for many years.

Thanks.

Signature · 1 line
Dmitry