Skip to contentSkip to conversation

iommu: Remove OMAP IOVMM driver

PATCH Superseded Laurent Pinchart 4 participants 14 messages Jul 18, 2014 – Jul 29, 2014

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

Hello,

The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager.

The removal is split in three patches to ease upstream merge. The first patch removes the omap-iovmm driver, the second patch removes setting of now unused platform data fields from arch code, and the last patch cleans up the platform data structure.

I'd like to get at least the first patch merged in v3.17. To avoid splitting the series across three kernel versions, it would be nice to also merge at least the second patch for v3.17. If there's no risk of conflict everything could be merged in one go through the ARM SoC tree. Otherwise a stable branch with patch 1/3 will be needed to base the arch change on.

Joerg, Tony, how would you like to proceed ?

Changes compared to v1:

- Fix OMAP_IOMMU_DEBUG dependency on OMAP_IOMMU
- Remove omap_iommu da_start and da_end fields
- Added patches 2/3 and 3/3

Laurent Pinchart (3):
iommu/omap: Remove virtual memory manager
ARM: omap: Don't set iommu pdata da_start and da_end fields iommu/omap: Remove platform data da_start and da_end fields

 arch/arm/mach-omap2/omap-iommu.c           |   2 -
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |   4 -
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |   4 -
 drivers/iommu/Kconfig                      |  10 +-
 drivers/iommu/Makefile                     |   1 -
 drivers/iommu/omap-iommu-debug.c           | 114 -----
 drivers/iommu/omap-iommu.c                 |  13 -
 drivers/iommu/omap-iommu.h                 |   8 +-
 drivers/iommu/omap-iovmm.c                 | 791 -----------------------------
 include/linux/omap-iommu.h                 |  37 +-
 include/linux/platform_data/iommu-omap.h   |   6 -
 11 files changed, 8 insertions(+), 982 deletions(-)
 delete mode 100644 drivers/iommu/omap-iovmm.c
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

PATCH v2 1/3 iommu/omap: Remove virtual memory manager

The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager.

---
 drivers/iommu/Kconfig            |  10 +-
 drivers/iommu/Makefile           |   1 -
 drivers/iommu/omap-iommu-debug.c | 114 ------
 drivers/iommu/omap-iommu.c       |  13 -
 drivers/iommu/omap-iommu.h       |   8 +-
 drivers/iommu/omap-iovmm.c       | 791 ---------------------------------------
 include/linux/omap-iommu.h       |  37 +-
 7 files changed, 8 insertions(+), 966 deletions(-)
 delete mode 100644 drivers/iommu/omap-iovmm.c
drivers/iommu/Kconfig +3 -7
index d260605..154e5a8 100644
@@ -143,16 +143,12 @@ config OMAP_IOMMU
 	depends on ARCH_OMAP2PLUS
 	select IOMMU_API
 
-config OMAP_IOVMM
-	tristate "OMAP IO Virtual Memory Manager Support"
-	depends on OMAP_IOMMU
-
 config OMAP_IOMMU_DEBUG
-       tristate "Export OMAP IOMMU/IOVMM internals in DebugFS"
-       depends on OMAP_IOVMM && DEBUG_FS
+       tristate "Export OMAP IOMMU internals in DebugFS"
+       depends on OMAP_IOMMU && DEBUG_FS
        help
          Select this to see extensive information about
-         the internal state of OMAP IOMMU/IOVMM in debugfs.
+         the internal state of OMAP IOMMU in debugfs.
 
          Say N unless you know you need this.
 
drivers/iommu/Makefile +0 -1
index 8893bad..6a4a00e 100644
@@ -11,7 +11,6 @@ obj-$(CONFIG_IPMMU_VMSA) += ipmmu-vmsa.o
 obj-$(CONFIG_IRQ_REMAP) += intel_irq_remapping.o irq_remapping.o
 obj-$(CONFIG_OMAP_IOMMU) += omap-iommu.o
 obj-$(CONFIG_OMAP_IOMMU) += omap-iommu2.o
-obj-$(CONFIG_OMAP_IOVMM) += omap-iovmm.o
 obj-$(CONFIG_OMAP_IOMMU_DEBUG) += omap-iommu-debug.o
 obj-$(CONFIG_TEGRA_IOMMU_GART) += tegra-gart.o
 obj-$(CONFIG_TEGRA_IOMMU_SMMU) += tegra-smmu.o
drivers/iommu/omap-iommu-debug.c +0 -114

132 lines not on this page · raw message

drivers/iommu/omap-iommu.c +0 -13
index 895af06..61599e2 100644
@@ -959,31 +959,18 @@ static int omap_iommu_probe(struct platform_device *pdev)
 			return err;
 		if (obj->nr_tlb_entries != 32 && obj->nr_tlb_entries != 8)
 			return -EINVAL;
-		/*
-		 * da_start and da_end are needed for omap-iovmm, so hardcode
-		 * these values as used by OMAP3 ISP - the only user for
-		 * omap-iovmm
-		 */
-		obj->da_start = 0;
-		obj->da_end = 0xfffff000;
 		if (of_find_property(of, "ti,iommu-bus-err-back", NULL))
 			obj->has_bus_err_back = MMU_GP_REG_BUS_ERR_BACK_EN;
 	} else {
 		obj->nr_tlb_entries = pdata->nr_tlb_entries;
 		obj->name = pdata->name;
-		obj->da_start = pdata->da_start;
-		obj->da_end = pdata->da_end;
 	}
-	if (obj->da_end <= obj->da_start)
-		return -EINVAL;
 
 	obj->dev = &pdev->dev;
 	obj->ctx = (void *)obj + sizeof(*obj);
 
 	spin_lock_init(&obj->iommu_lock);
-	mutex_init(&obj->mmap_lock);
 	spin_lock_init(&obj->page_table_lock);
-	INIT_LIST_HEAD(&obj->mmap);
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	obj->regbase = devm_ioremap_resource(obj->dev, res);
drivers/iommu/omap-iommu.h +3 -5
index ea920c3..1275a82 100644
@@ -46,12 +46,7 @@ struct omap_iommu {
 
 	int		nr_tlb_entries;
 
-	struct list_head	mmap;
-	struct mutex		mmap_lock; /* protect mmap */
-
 	void *ctx; /* iommu context: registres saved area */
-	u32 da_start;
-	u32 da_end;
 
 	int has_bus_err_back;
 };
@@ -154,9 +149,12 @@ static inline struct omap_iommu *dev_to_omap_iommu(struct device *dev)
 #define MMU_RAM_PADDR_MASK \
 	((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT)
 
+#define MMU_RAM_ENDIAN_SHIFT	9
 #define MMU_RAM_ENDIAN_MASK	(1 << MMU_RAM_ENDIAN_SHIFT)
+#define MMU_RAM_ENDIAN_LITTLE	(0 << MMU_RAM_ENDIAN_SHIFT)
 #define MMU_RAM_ENDIAN_BIG	(1 << MMU_RAM_ENDIAN_SHIFT)
 
+#define MMU_RAM_ELSZ_SHIFT	7
 #define MMU_RAM_ELSZ_MASK	(3 << MMU_RAM_ELSZ_SHIFT)
 #define MMU_RAM_ELSZ_8		(0 << MMU_RAM_ELSZ_SHIFT)
 #define MMU_RAM_ELSZ_16		(1 << MMU_RAM_ELSZ_SHIFT)
drivers/iommu/omap-iovmm.c deleted +0 -791

791 lines not on this page · raw message

include/linux/omap-iommu.h +2 -35
index cac78de..c1aede4 100644
@@ -10,41 +10,8 @@
  * published by the Free Software Foundation.
  */
 
-#ifndef _INTEL_IOMMU_H_
-#define _INTEL_IOMMU_H_
-
-struct iovm_struct {
-	struct omap_iommu	*iommu;	/* iommu object which this belongs to */
-	u32			da_start; /* area definition */
-	u32			da_end;
-	u32			flags; /* IOVMF_: see below */
-	struct list_head	list; /* linked in ascending order */
-	const struct sg_table	*sgt; /* keep 'page' <-> 'da' mapping */
-	void			*va; /* mpu side mapped address */
-};
-
-#define MMU_RAM_ENDIAN_SHIFT	9
-#define MMU_RAM_ENDIAN_LITTLE	(0 << MMU_RAM_ENDIAN_SHIFT)
-#define MMU_RAM_ELSZ_8		(0 << MMU_RAM_ELSZ_SHIFT)
-#define IOVMF_ENDIAN_LITTLE	MMU_RAM_ENDIAN_LITTLE
-#define MMU_RAM_ELSZ_SHIFT	7
-#define IOVMF_ELSZ_8		MMU_RAM_ELSZ_8
-
-struct iommu_domain;
-
-extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da);
-extern u32
-omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da,
-			const struct sg_table *sgt, u32 flags);
-extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain,
-				struct device *dev, u32 da);
-extern u32
-omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev,
-				u32 da, size_t bytes, u32 flags);
-extern void
-omap_iommu_vfree(struct iommu_domain *domain, struct device *dev,
-				const u32 da);
-extern void *omap_da_to_va(struct device *dev, u32 da);
+#ifndef _OMAP_IOMMU_H_
+#define _OMAP_IOMMU_H_
 
 extern void omap_iommu_save_ctx(struct device *dev);
 extern void omap_iommu_restore_ctx(struct device *dev);
Signature · 1 line
1.8.5.5
#2 lore raw

PATCH v2 2/3 ARM: omap: Don't set iommu pdata da_start and da_end fields

In reply to Laurent Pinchart

The fields are not used by the driver and will be removed from platform data. Don't set them.

---
 arch/arm/mach-omap2/omap-iommu.c           | 2 --
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ----
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 4 ----
 3 files changed, 10 deletions(-)
arch/arm/mach-omap2/omap-iommu.c +0 -2
index f1fab56..4068350 100644
@@ -34,8 +34,6 @@ static int __init omap_iommu_dev_init(struct omap_hwmod *oh, void *unused)
 
 	pdata->name = oh->name;
 	pdata->nr_tlb_entries = a->nr_tlb_entries;
-	pdata->da_start = a->da_start;
-	pdata->da_end = a->da_end;
 
 	if (oh->rst_lines_cnt == 1) {
 		pdata->reset_name = oh->rst_lines->name;
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +0 -4
index 1cd0cfd..e9516b4 100644
@@ -2986,8 +2986,6 @@ static struct omap_hwmod_class omap3xxx_mmu_hwmod_class = {
 /* mmu isp */
 
 static struct omap_mmu_dev_attr mmu_isp_dev_attr = {
-	.da_start	= 0x0,
-	.da_end		= 0xfffff000,
 	.nr_tlb_entries = 8,
 };
 
@@ -3026,8 +3024,6 @@ static struct omap_hwmod omap3xxx_mmu_isp_hwmod = {
 /* mmu iva */
 
 static struct omap_mmu_dev_attr mmu_iva_dev_attr = {
-	.da_start	= 0x11000000,
-	.da_end		= 0xfffff000,
 	.nr_tlb_entries = 32,
 };
 
arch/arm/mach-omap2/omap_hwmod_44xx_data.c +0 -4
index 41e54f7..b4acc0a 100644
@@ -2084,8 +2084,6 @@ static struct omap_hwmod_class omap44xx_mmu_hwmod_class = {
 /* mmu ipu */
 
 static struct omap_mmu_dev_attr mmu_ipu_dev_attr = {
-	.da_start	= 0x0,
-	.da_end		= 0xfffff000,
 	.nr_tlb_entries = 32,
 };
 
@@ -2133,8 +2131,6 @@ static struct omap_hwmod omap44xx_mmu_ipu_hwmod = {
 /* mmu dsp */
 
 static struct omap_mmu_dev_attr mmu_dsp_dev_attr = {
-	.da_start	= 0x0,
-	.da_end		= 0xfffff000,
 	.nr_tlb_entries = 32,
 };
 
Signature · 1 line
1.8.5.5
#3 lore raw

PATCH v2 3/3 iommu/omap: Remove platform data da_start and da_end fields

In reply to Laurent Pinchart

The fields were used by the now gone omap-iovmm driver. They're not used anymore, remove them.

---
 include/linux/platform_data/iommu-omap.h | 6 ------
 1 file changed, 6 deletions(-)
include/linux/platform_data/iommu-omap.h +0 -6
index 5b429c4..54a0a95 100644
@@ -31,14 +31,10 @@ struct omap_iommu_arch_data {
 
 /**
  * struct omap_mmu_dev_attr - OMAP mmu device attributes for omap_hwmod
- * @da_start:		device address where the va space starts.
- * @da_end:		device address where the va space ends.
  * @nr_tlb_entries:	number of entries supported by the translation
  *			look-aside buffer (TLB).
  */
 struct omap_mmu_dev_attr {
-	u32 da_start;
-	u32 da_end;
 	int nr_tlb_entries;
 };
 
@@ -46,8 +42,6 @@ struct iommu_platform_data {
 	const char *name;
 	const char *reset_name;
 	int nr_tlb_entries;
-	u32 da_start;
-	u32 da_end;
 
 	int (*assert_reset)(struct platform_device *pdev, const char *name);
 	int (*deassert_reset)(struct platform_device *pdev, const char *name);
Signature · 1 line
1.8.5.5
#4 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

In reply to Laurent Pinchart

Hi Laurent,

Quoted 9 lines · Laurent Pinchart

Hello,

The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager.

The removal is split in three patches to ease upstream merge. The first patch removes the omap-iovmm driver, the second patch removes setting of now unused platform data fields from arch code, and the last patch cleans up the platform data structure.

Thanks for the revised series, it looks good. I have also tested the series on OMAP3, OMAP4 and OMAP5.

For the changes in the entire series,

regards
Suman

Quoted 34 lines

I'd like to get at least the first patch merged in v3.17. To avoid splitting the series across three kernel versions, it would be nice to also merge at least the second patch for v3.17. If there's no risk of conflict everything could be merged in one go through the ARM SoC tree. Otherwise a stable branch with patch 1/3 will be needed to base the arch change on.

Joerg, Tony, how would you like to proceed ?

Changes compared to v1:

- Fix OMAP_IOMMU_DEBUG dependency on OMAP_IOMMU
- Remove omap_iommu da_start and da_end fields
- Added patches 2/3 and 3/3

Laurent Pinchart (3):
iommu/omap: Remove virtual memory manager
ARM: omap: Don't set iommu pdata da_start and da_end fields iommu/omap: Remove platform data da_start and da_end fields

 arch/arm/mach-omap2/omap-iommu.c           |   2 -
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |   4 -
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |   4 -
 drivers/iommu/Kconfig                      |  10 +-
 drivers/iommu/Makefile                     |   1 -
 drivers/iommu/omap-iommu-debug.c           | 114 -----
 drivers/iommu/omap-iommu.c                 |  13 -
 drivers/iommu/omap-iommu.h                 |   8 +-
 drivers/iommu/omap-iovmm.c                 | 791 -----------------------------
 include/linux/omap-iommu.h                 |  37 +-
 include/linux/platform_data/iommu-omap.h   |   6 -
 11 files changed, 8 insertions(+), 982 deletions(-)
 delete mode 100644 drivers/iommu/omap-iovmm.c
#5 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

Hi Suman, Joerg and Tony,

Quoted 11 lines · On Friday 18 July 2014 11:53:56 Suman Anna wrote:
Quoted 9 lines · Laurent Pinchart

Hello,

The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager.

The removal is split in three patches to ease upstream merge. The first patch removes the omap-iovmm driver, the second patch removes setting of now unused platform data fields from arch code, and the last patch cleans up the platform data structure.

Quoted 5 lines

Thanks for the revised series, it looks good. I have also tested the series on OMAP3, OMAP4 and OMAP5.

For the changes in the entire series,

Thank you.

Quoted 8 lines
Quoted 8 lines

I'd like to get at least the first patch merged in v3.17. To avoid splitting the series across three kernel versions, it would be nice to also merge at least the second patch for v3.17. If there's no risk of conflict everything could be merged in one go through the ARM SoC tree. Otherwise a stable branch with patch 1/3 will be needed to base the arch change on.

Joerg, Tony, how would you like to proceed ?

The v3.17 merge window is getting close, it's probably too late to merge patch 2/3. Joerg, could you please take 1/3 in your tree for v3.17 ? 2/3 and 3/3 would then get in v3.18. Tony, how would you like to proceed for those ?

Quoted 24 lines
Quoted 24 lines

Changes compared to v1:

- Fix OMAP_IOMMU_DEBUG dependency on OMAP_IOMMU
- Remove omap_iommu da_start and da_end fields
- Added patches 2/3 and 3/3

Laurent Pinchart (3):
iommu/omap: Remove virtual memory manager
ARM: omap: Don't set iommu pdata da_start and da_end fields iommu/omap: Remove platform data da_start and da_end fields

 arch/arm/mach-omap2/omap-iommu.c           |   2 -
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |   4 -
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |   4 -
 drivers/iommu/Kconfig                      |  10 +-
 drivers/iommu/Makefile                     |   1 -
 drivers/iommu/omap-iommu-debug.c           | 114 -----
 drivers/iommu/omap-iommu.c                 |  13 -
 drivers/iommu/omap-iommu.h                 |   8 +-
 drivers/iommu/omap-iovmm.c                 | 791 ------------------------
 include/linux/omap-iommu.h                 |  37 +-
 include/linux/platform_data/iommu-omap.h   |   6 -
 11 files changed, 8 insertions(+), 982 deletions(-)
 delete mode 100644 drivers/iommu/omap-iovmm.c
Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#6 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

Quoted 29 lines · Laurent Pinchart

Hi Suman, Joerg and Tony,

Quoted 11 lines · On Friday 18 July 2014 11:53:56 Suman Anna wrote:
Quoted 9 lines · Laurent Pinchart

Hello,

The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager.

The removal is split in three patches to ease upstream merge. The first patch removes the omap-iovmm driver, the second patch removes setting of now unused platform data fields from arch code, and the last patch cleans up the platform data structure.

Quoted 5 lines

Thanks for the revised series, it looks good. I have also tested the series on OMAP3, OMAP4 and OMAP5.

For the changes in the entire series,

Thank you.

Quoted 7 lines
Quoted 7 lines

I'd like to get at least the first patch merged in v3.17. To avoid splitting the series across three kernel versions, it would be nice to also merge at least the second patch for v3.17. If there's no risk of conflict everything could be merged in one go through the ARM SoC tree. Otherwise a stable branch with patch 1/3 will be needed to base the arch change on.

Quoted 5 lines
Quoted 1 line
Quoted 1 line

Joerg, Tony, how would you like to proceed ?

The v3.17 merge window is getting close, it's probably too late to merge patch 2/3. Joerg, could you please take 1/3 in your tree for v3.17 ? 2/3 and 3/3 would then get in v3.18. Tony, how would you like to proceed for those ?

How about Joerg maybe do an immutable branch against v3.16-rc1 with just these three patches and merge it into your tree?

That way I too can merge the minimal branch in if there are conflics. If that works for Joerg, then for arch/arm/*omap* changes:

If the above is too complicated, then how about Laurent resend patches 2 - 3 once the dependencies have cleared so I can pick them up. This is assuming nothing breaks with patchs 2 - 3 missing naturally :)

Regards,

Tony

#7 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

Hi Tony and Joerg,

Quoted 38 lines · On Monday 21 July 2014 02:33:36 Tony Lindgren wrote:
Quoted 30 lines · Laurent Pinchart

Hi Suman, Joerg and Tony,

Quoted 12 lines · On Friday 18 July 2014 11:53:56 Suman Anna wrote:
Quoted 10 lines · Laurent Pinchart

Hello,

The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager.

The removal is split in three patches to ease upstream merge. The first patch removes the omap-iovmm driver, the second patch removes setting of now unused platform data fields from arch code, and the last patch cleans up the platform data structure.

Quoted 5 lines

Thanks for the revised series, it looks good. I have also tested the series on OMAP3, OMAP4 and OMAP5.

For the changes in the entire series,

Thank you.

Quoted 7 lines
Quoted 7 lines

I'd like to get at least the first patch merged in v3.17. To avoid splitting the series across three kernel versions, it would be nice to also merge at least the second patch for v3.17. If there's no risk of conflict everything could be merged in one go through the ARM SoC tree. Otherwise a stable branch with patch 1/3 will be needed to base the arch change on.

Quoted 6 lines
Quoted 1 line
Quoted 1 line

Joerg, Tony, how would you like to proceed ?

The v3.17 merge window is getting close, it's probably too late to merge patch 2/3. Joerg, could you please take 1/3 in your tree for v3.17 ? 2/3 and 3/3 would then get in v3.18. Tony, how would you like to proceed for those ?

Quoted 7 lines

How about Joerg maybe do an immutable branch against v3.16-rc1 with just these three patches and merge it into your tree?

That way I too can merge the minimal branch in if there are conflics. If that works for Joerg, then for arch/arm/*omap* changes:

I've created an immutable branch (or, rather, immutable until the changes reach mainline, at which point I will remove the branch) on top of v3.16-rc1 with just the three patches from this series. You can find it at.

git://linuxtv.org/pinchartl/media.git omap/iommu

Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ?

Quoted 3 lines

If the above is too complicated, then how about Laurent resend patches 2 - 3 once the dependencies have cleared so I can pick them up. This is assuming nothing breaks with patchs 2 - 3 missing naturally :)

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#8 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

Quoted 49 lines · Laurent Pinchart

Hi Tony and Joerg,

Quoted 38 lines · On Monday 21 July 2014 02:33:36 Tony Lindgren wrote:
Quoted 30 lines · Laurent Pinchart

Hi Suman, Joerg and Tony,

Quoted 12 lines · On Friday 18 July 2014 11:53:56 Suman Anna wrote:
Quoted 10 lines · Laurent Pinchart

Hello,

The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager.

The removal is split in three patches to ease upstream merge. The first patch removes the omap-iovmm driver, the second patch removes setting of now unused platform data fields from arch code, and the last patch cleans up the platform data structure.

Quoted 5 lines

Thanks for the revised series, it looks good. I have also tested the series on OMAP3, OMAP4 and OMAP5.

For the changes in the entire series,

Thank you.

Quoted 7 lines
Quoted 7 lines

I'd like to get at least the first patch merged in v3.17. To avoid splitting the series across three kernel versions, it would be nice to also merge at least the second patch for v3.17. If there's no risk of conflict everything could be merged in one go through the ARM SoC tree. Otherwise a stable branch with patch 1/3 will be needed to base the arch change on.

Quoted 6 lines
Quoted 1 line
Quoted 1 line

Joerg, Tony, how would you like to proceed ?

The v3.17 merge window is getting close, it's probably too late to merge patch 2/3. Joerg, could you please take 1/3 in your tree for v3.17 ? 2/3 and 3/3 would then get in v3.18. Tony, how would you like to proceed for those ?

Quoted 7 lines

How about Joerg maybe do an immutable branch against v3.16-rc1 with just these three patches and merge it into your tree?

That way I too can merge the minimal branch in if there are conflics. If that works for Joerg, then for arch/arm/*omap* changes:

Quoted 8 lines

I've created an immutable branch (or, rather, immutable until the changes reach mainline, at which point I will remove the branch) on top of v3.16-rc1 with just the three patches from this series. You can find it at.

git://linuxtv.org/pinchartl/media.git omap/iommu

Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ?

Yes as long as Joerg is OK to merge that branch in :)

Regards,

Tony

#9 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

Hi Joerg,

(Your attention is kindly requested in time for v3.17, please see below)

Quoted 51 lines · On Monday 21 July 2014 23:19:29 Tony Lindgren wrote:
Quoted 50 lines · Laurent Pinchart
Quoted 36 lines · On Monday 21 July 2014 02:33:36 Tony Lindgren wrote:
Quoted 28 lines · Laurent Pinchart
Quoted 12 lines · On Friday 18 July 2014 11:53:56 Suman Anna wrote:
Quoted 10 lines · Laurent Pinchart

Hello,

The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager.

The removal is split in three patches to ease upstream merge. The first patch removes the omap-iovmm driver, the second patch removes setting of now unused platform data fields from arch code, and the last patch cleans up the platform data structure.

Quoted 5 lines

Thanks for the revised series, it looks good. I have also tested the series on OMAP3, OMAP4 and OMAP5.

For the changes in the entire series,

Thank you.

Quoted 7 lines
Quoted 7 lines

I'd like to get at least the first patch merged in v3.17. To avoid splitting the series across three kernel versions, it would be nice to also merge at least the second patch for v3.17. If there's no risk of conflict everything could be merged in one go through the ARM SoC tree. Otherwise a stable branch with patch 1/3 will be needed to base the arch change on.

Quoted 6 lines
Quoted 1 line
Quoted 1 line

Joerg, Tony, how would you like to proceed ?

The v3.17 merge window is getting close, it's probably too late to merge patch 2/3. Joerg, could you please take 1/3 in your tree for v3.17 ? 2/3 and 3/3 would then get in v3.18. Tony, how would you like to proceed for those ?

Quoted 7 lines

How about Joerg maybe do an immutable branch against v3.16-rc1 with just these three patches and merge it into your tree?

That way I too can merge the minimal branch in if there are conflics. If that works for Joerg, then for arch/arm/*omap* changes:

I've created an immutable branch (or, rather, immutable until the changes reach mainline, at which point I will remove the branch) on top of v3.16-rc1 with just the three patches from this series. You can find it at.

Quoted 6 lines
Quoted 4 lines

git://linuxtv.org/pinchartl/media.git omap/iommu

Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ?

Yes as long as Joerg is OK to merge that branch in :)

Are you ? :-)

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#10 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

In reply to Tony Lindgren
Quoted 4 lines · Tony Lindgren
Quoted 2 lines

Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ?

Yes as long as Joerg is OK to merge that branch in :)

Fine with me, I can take only patch 1 or all 3 into my arm/omap branch, given Tony's Acked-by.

Then you guys can merge in this branch wherever you want :)

Cheers,

Joerg

#11 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

Hi Joerg,

Quoted 10 lines · On Wednesday 23 July 2014 15:52:17 Joerg Roedel wrote:
Quoted 4 lines · Tony Lindgren
Quoted 2 lines

Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ?

Yes as long as Joerg is OK to merge that branch in :)

Fine with me, I can take only patch 1 or all 3 into my arm/omap branch, given Tony's Acked-by.

Then you guys can merge in this branch wherever you want :)

Thank you. Assuming there's currently no conflict to be resolved, I believe the easiest would be for both you and Tony to merge my branch in your trees.

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#12 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

Quoted 9 lines · Laurent Pinchart

Hi Joerg,

Quoted 6 lines · On Wednesday 23 July 2014 15:52:17 Joerg Roedel wrote:
Quoted 4 lines · Tony Lindgren
Quoted 2 lines

Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ?

Yes as long as Joerg is OK to merge that branch in :)

Quoted 7 lines
Quoted 4 lines

Fine with me, I can take only patch 1 or all 3 into my arm/omap branch, given Tony's Acked-by.

Then you guys can merge in this branch wherever you want :)

Thank you. Assuming there's currently no conflict to be resolved, I believe the easiest would be for both you and Tony to merge my branch in your trees.

Yes please merge that branch via the IOMMU tree, I only need to merge it if I see merge conflicts with it.

Regards,

Tony

maintainer
#13 lore raw

v2 cover iommu: Remove OMAP IOVMM driver

In reply to Laurent Pinchart
Quoted 2 lines · Laurent Pinchart

Thank you. Assuming there's currently no conflict to be resolved, I believe the easiest would be for both you and Tony to merge my branch in your trees.

Okay, I applied the patches to my arm/omap branch. I will push them out today.

Joerg