Skip to contentSkip to conversation

Richard Tollerton : bootlogd: ensure /var/log/boot is created in volatiles

oe-commits Martin Jansa 3 participants 3 messages Jul 22, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Martin Jansa

author
#1 lore raw
Quoted 9 lines · On Mon, Jul 21, 2014 at 06:25:15PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master-next
Commit: 6f963d761fa2916711b0d7808351515383bd5298
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=6f963d761fa2916711b0d7808351515383bd5298
Author: Richard Tollerton <[email protected]>
Date:   Mon Jul 21 10:50:56 2014 -0500

bootlogd: ensure /var/log/boot is created in volatiles

subject usually starts with recipe/bbclass name, so it should be sysvinit not bootlogd.

Quoted 26 lines

bootlogd does not write to /var/log/boot if it does not exist, so if using the volatiles facility (presumed to mount /var/log under a tmpfs), ensure that /var/log/boot gets created.

Signed-off-by Richard Tollerton <[email protected]>
Signed-off-by Ben Shelton <[email protected]>
Signed-off-by Richard Purdie <[email protected]>

---

 meta/recipes-core/sysvinit/sysvinit/01_bootlogd | 1 +
 meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb  | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)
meta/recipes-core/sysvinit/sysvinit/01_bootlogd new file +1 -0
new file mode 100644
index 0000000..a689d92
@@ -0,0 +1 @@
+f root root 0644 /var/log/boot none
meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb +0 -0
index 448d021..a8c10f2 100644

meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb SRC_URI = "${SAVANNAH_GNU_MIRROR}/sysvinit/sysvinit-${PV}.tar.bz2 \ · line 20

Quoted 6 lines
meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb +2 -1
@@ -16,7 +16,9 @@ SRC_URI = "${SAVANNAH_GNU_MIRROR}/sysvinit/sysvinit-${PV}.tar.bz2 \
            file://rcS-default \
            file://rc \
            file://rcS \
-           file://bootlogd.init"
+	   file://bootlogd.init \
+           file://01_bootlogd \

Please don't mix tabs and spaces for indentation, only spaces should be used in multi-line variables.

Quoted 20 lines
meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb +4 -0
+"
 
 SRC_URI[md5sum] = "6eda8a97b86e0a6f59dabbf25202aa6f"
 SRC_URI[sha256sum] = "60bbc8c1e1792056e23761d22960b30bb13eccc2cabff8c7310a01f4d5df1519"

@@ -92,6 +94,9 @@ do_install () {
 	update-rc.d -r ${D} bootlogd start 07 S .
 	update-rc.d -r ${D} stop-bootlogd start 99 2 3 4 5 .
 
+	install -d ${D}${sysconfdir}/default/volatiles
+	install -m 0644 ${WORKDIR}/01_bootlogd ${D}${sysconfdir}/default/volatiles
+
 	chown root.shutdown ${D}${base_sbindir}/halt ${D}${base_sbindir}/shutdown
 	chmod o-x,u+s ${D}${base_sbindir}/halt ${D}${base_sbindir}/shutdown
 }
Signature · 5 lines
-- 
_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 9 lines · Martin Jansa
Quoted 8 lines · On Mon, Jul 21, 2014 at 06:25:15PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master-next
Commit: 6f963d761fa2916711b0d7808351515383bd5298
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=6f963d761fa2916711b0d7808351515383bd5298
Author: Richard Tollerton <[email protected]>
Date:   Mon Jul 21 10:50:56 2014 -0500
Quoted 9 lines
Quoted 1 line

bootlogd: ensure /var/log/boot is created in volatiles

subject usually starts with recipe/bbclass name, so it should be sysvinit not bootlogd.

Please don't mix tabs and spaces for indentation, only spaces should be used in multi-line variables.

Sorry about that -- do we need to resubmit the patch, or has it already been merged?

Thanks,
Ben

Quoted 3 lines
Signature · 2 lines
-- 
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
Quoted 16 lines · Ben Shelton
Quoted 15 lines · Martin Jansa
Quoted 9 lines · On Mon, Jul 21, 2014 at 06:25:15PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master-next
Commit: 6f963d761fa2916711b0d7808351515383bd5298
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=6f963d761fa2916711b0d7808351515383bd5298
Author: Richard Tollerton <[email protected]>
Date:   Mon Jul 21 10:50:56 2014 -0500

bootlogd: ensure /var/log/boot is created in volatiles

subject usually starts with recipe/bbclass name, so it should be sysvinit not bootlogd.

Quoted 7 lines
Quoted 3 lines

Please don't mix tabs and spaces for indentation, only spaces should be used in multi-line variables.

Sorry about that -- do we need to resubmit the patch, or has it already been merged?

It has not been merged yet, so please resubmit a v2 with fixed white space.

Sau!

Quoted 8 lines

Thanks,
Ben

Quoted 3 lines

--
Martin 'JaMa' Jansa jabber: [email protected]