package/webkit: Broken on rpi?

Hi,

after fixing a configure problem (see patch 1/2) the build failed at the linking stage, so the real fix, afaics, is to disable webkit for rpi (patch 2/2). Patch 1/2 therefore is not really needed at all, but the rpi experts should have a closer look whether webkit could work on rpi despite the current problem.

Regards, Bernd

Bernd Kuhls (2):
package/webkit: Fix detection of egl headers provided by rpi-userland package/webkit: Broken on raspberry pi

 package/webkit/Config.in |    1 +
 package/webkit/webkit.mk |    6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

1.7.10.4

quote from webkit/config.log:
/home/br2/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/interface/vcos/vcos_types.h:38:33:
fatal error: vcos_platform_types.h: No such file or directory

Package rpi-userland provides this header file, but in a non-default directory, therefore use pkg-config to add the appropriate flags.

Fixes
http://autobuild.buildroot.net/results/bc0/bc0f9114f9dacf68a510f1e01f2dc3661c34f536/

---
 package/webkit/webkit.mk |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

index 6b04ccd..1f40736 100644
@@ -35,8 +35,9 @@ WEBKIT_PRE_CONFIGURE_HOOKS += DISABLE_INDEXED_DATABASE
 # Give explicit path to icu-config, and silence gazillions of warnings
 # with recent gcc versions.
 WEBKIT_CONF_ENV = ac_cv_path_icu_config=$(STAGING_DIR)/usr/bin/icu-config \
-	CFLAGS="$(TARGET_CFLAGS) -Wno-cast-align -Wno-sign-compare" \
-	CXXFLAGS="$(TARGET_CXXFLAGS) -Wno-cast-align -Wno-sign-compare" \
+	CFLAGS="$(TARGET_CFLAGS) $(WEBKIT_EGLFLAGS) -Wno-cast-align -Wno-sign-compare" \
+	CPPFLAGS="$(TARGET_CPPFLAGS) $(WEBKIT_EGLFLAGS)" \
+	CXXFLAGS="$(TARGET_CXXFLAGS) $(WEBKIT_EGLFLAGS) -Wno-cast-align -Wno-sign-compare" \
 	AR_FLAGS="cru"
 
 WEBKIT_CONF_OPT += \

@@ -55,6 +56,7 @@ WEBKIT_DEPENDENCIES += xlib_libXt
 ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yy)
 WEBKIT_CONF_OPT += --enable-gles2
 WEBKIT_DEPENDENCIES += libegl libgles
+WEBKIT_EGLFLAGS = $(shell $(PKG_CONFIG_HOST_BINARY) --cflags egl)
 else
 WEBKIT_CONF_OPT += --disable-gles2
 endif

1.7.10.4

Dear Bernd Kuhls,

Could you update on whether this patch and patch 2/2 in this series are still needed? There were also unanswered questions in your patch 2/2.

Thanks,

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 @public.gmane.org> wrote in news:20140723235453.5ebea556 at free-electrons.com:

Hi Thomas,

the autobuild error I was trying to fix occured on May 29th:
http://autobuild.buildroot.net/results/bc0/bc0f9114f9dacf68a510f1e01f2dc3661c
34f536/

The same error was still present on July, 21th:
http://autobuild.buildroot.net/results/1e8/1e8cab75025316b22205be7fb08a93148a
256b9c/

As I wrote in my cover letter[1] for this patch series

I asked for this help because I have basically no knowledge about the rpi- specific binary blobs provided by rpi-userland.

Maybe Hadrien?s patch series[2] to bump webkit to 2.4.3 will solve the problem in a better way than with my patches.

@Hadrien: Could you please test your patch using the defconfig used by the autobuilder where webkit-1 failed to compile for rpi?

Regards, Bernd

[1] http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/85281
[2] http://thread.gmane.org/gmane.comp.lib.uclibc.buildroot/89775

Hi Bernd,

Actually, I had forgotten this problem but yes, when I initially tested the bump of WebKit with rpi-userland the EGL check failed too. So it's not solved in my series or with version 2.4.3 and this seems to be related to rpi-userland (no problem with ti-gfx and imx-lib, with which I test now).

I will test my patch with the defconfig used by the autobuilder and test your patch if the problem occurs again.

Regards,

Hadrien

Linking libwebkitgtk-1.0.so fails

./.libs/libwebkitgtk-1.0.so: undefined reference to WebCore::GLContext::GLContext()' ./.libs/libwebkitgtk-1.0.so: undefined reference to WebCore::GLContext::sharedX11Display()' ./.libs/libwebkitgtk-1.0.so: undefined reference to WebCore::GLContext::~GLContext()' ./.libs/libwebkitgtk-1.0.so: undefined reference to WebCore::GLContext::makeContextCurrent()'

This link error occurred after fixing the configure problem
http://autobuild.buildroot.net/results/bc0/bc0f9114f9dacf68a510f1e01f2dc3661c34f536/

webkit-1.x apparently is missing support for raspberry pi.

---
 package/webkit/Config.in |    1 +
 1 file changed, 1 insertion(+)

index c86eb94..95c621d 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
 	default y if BR2_i386 || BR2_mips || BR2_mipsel || \
 		BR2_sh || BR2_sparc || BR2_x86_64
 	depends on BR2_USE_MMU # libgail -> pango -> libglib2
+	depends on !BR2_PACKAGE_RPI_USERLAND
 
 # disabled on powerpc due to bug https://bugs.webkit.org/show_bug.cgi?id=113638
 

1.7.10.4

Dear Bernd Kuhls,

What makes you think this is RasberryPi specific? It looks more like the OpenGL support in libwebkitgtk assumes it's OpenGL under X.org, and not OpenGL with EGL, no?

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com