Skip to contentSkip to conversation

ARM: dts: imx: Add alias for ethernet controller

PATCH New Marek Vasut 3 participants 6 messages Jul 24, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.

Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

---
 arch/arm/boot/dts/imx25.dtsi | 1 +
 arch/arm/boot/dts/imx27.dtsi | 1 +
 arch/arm/boot/dts/imx51.dtsi | 1 +
 arch/arm/boot/dts/imx53.dtsi | 1 +
 4 files changed, 4 insertions(+)

NOTE: Without this backport, the ethernet adapter on most of the boards
with the i.MX CPUs does not know it's MAC address (the controller does not have an EEPROM). Without MAC address, the ethernet cannot be brought up and this makes such board unusable when booting from NFS. This patch lets the bootloader pass the MAC address via DT to the kernel properly, thus letting me boot from NFS again.

arch/arm/boot/dts/imx25.dtsi +1 -0
index 737ed5d..de16119 100644
@@ -30,6 +30,7 @@
 		spi2 = &spi3;
 		usb0 = &usbotg;
 		usb1 = &usbhost1;
+		ethernet0 = &fec;
 	};
 
 	cpus {
arch/arm/boot/dts/imx27.dtsi +1 -0
index 826231e..da2eb7f 100644
@@ -30,6 +30,7 @@
 		spi0 = &cspi1;
 		spi1 = &cspi2;
 		spi2 = &cspi3;
+		ethernet0 = &fec;
 	};
 
 	aitc: aitc-interrupt-controller at e0000000 {
arch/arm/boot/dts/imx51.dtsi +1 -0
index 4bcdd3a..e1b6015 100644
@@ -27,6 +27,7 @@
 		spi0 = &ecspi1;
 		spi1 = &ecspi2;
 		spi2 = &cspi;
+		ethernet0 = &fec;
 	};
 
 	tzic: tz-interrupt-controller at e0000000 {
arch/arm/boot/dts/imx53.dtsi +1 -0
index 7abe6c4..86df3f5 100644
@@ -34,6 +34,7 @@
 		spi0 = &ecspi1;
 		spi1 = &ecspi2;
 		spi2 = &cspi;
+		ethernet0 = &fec;
 	};
 
 	cpus {
Signature · 1 line
2.0.1
#1 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 9 lines · Marek Vasut

commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.

Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Since the patch is already on mainline, and the submitting target is 3.14.x stable kernel, you should really send it to Greg.

Shawn

Quoted 65 lines
---
 arch/arm/boot/dts/imx25.dtsi | 1 +
 arch/arm/boot/dts/imx27.dtsi | 1 +
 arch/arm/boot/dts/imx51.dtsi | 1 +
 arch/arm/boot/dts/imx53.dtsi | 1 +
 4 files changed, 4 insertions(+)

NOTE: Without this backport, the ethernet adapter on most of the boards
with the i.MX CPUs does not know it's MAC address (the controller does not have an EEPROM). Without MAC address, the ethernet cannot be brought up and this makes such board unusable when booting from NFS. This patch lets the bootloader pass the MAC address via DT to the kernel properly, thus letting me boot from NFS again.

arch/arm/boot/dts/imx25.dtsi +1 -0
index 737ed5d..de16119 100644
@@ -30,6 +30,7 @@
 		spi2 = &spi3;
 		usb0 = &usbotg;
 		usb1 = &usbhost1;
+		ethernet0 = &fec;
 	};
 
 	cpus {
arch/arm/boot/dts/imx27.dtsi +1 -0
index 826231e..da2eb7f 100644
@@ -30,6 +30,7 @@
 		spi0 = &cspi1;
 		spi1 = &cspi2;
 		spi2 = &cspi3;
+		ethernet0 = &fec;
 	};
 
 	aitc: aitc-interrupt-controller at e0000000 {
arch/arm/boot/dts/imx51.dtsi +1 -0
index 4bcdd3a..e1b6015 100644
@@ -27,6 +27,7 @@
 		spi0 = &ecspi1;
 		spi1 = &ecspi2;
 		spi2 = &cspi;
+		ethernet0 = &fec;
 	};
 
 	tzic: tz-interrupt-controller at e0000000 {
arch/arm/boot/dts/imx53.dtsi +1 -0
index 7abe6c4..86df3f5 100644
@@ -34,6 +34,7 @@
 		spi0 = &ecspi1;
 		spi1 = &ecspi2;
 		spi2 = &cspi;
+		ethernet0 = &fec;
 	};
 
 	cpus {
Signature · 1 line
2.0.1
#2 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 7 lines · Shawn Guo
Quoted 6 lines · Marek Vasut

commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.

Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Quoted 6 lines
Quoted 3 lines

Since the patch is already on mainline, and the submitting target is 3.14.x stable kernel, you should really send it to Greg.

No, Marek did the right thing here by sending it to the stable at vger mailing list, never send stable patches only to me.

greg k-h

#3 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 12 lines · Greg KH
Quoted 11 lines · Shawn Guo
Quoted 9 lines · Marek Vasut

commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.

Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Quoted 5 lines
Quoted 2 lines

Since the patch is already on mainline, and the submitting target is 3.14.x stable kernel, you should really send it to Greg.

No, Marek did the right thing here by sending it to the stable at vger mailing list, never send stable patches only to me.

Whew, I was really worried I messed the submission up. Thank you for confirming this is the right way to do it.

Best regards,
Marek Vasut

#4 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

In reply to Greg KH
Quoted 12 lines · Greg KH
Quoted 11 lines · Shawn Guo
Quoted 9 lines · Marek Vasut

commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.

Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Quoted 5 lines
Quoted 2 lines

Since the patch is already on mainline, and the submitting target is 3.14.x stable kernel, you should really send it to Greg.

No, Marek did the right thing here by sending it to the stable at vger mailing list, never send stable patches only to me.

Oh, I did not mean sending the patch only to you, but have you on copy.

Shawn

#5 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

In reply to Shawn Guo
Quoted 7 lines · Shawn Guo
Quoted 6 lines · Marek Vasut

commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.

Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Quoted 6 lines
Quoted 3 lines

Since the patch is already on mainline, and the submitting target is 3.14.x stable kernel, you should really send it to Greg.

So this is not enough to add this "# 3.14.x" ? I followed the stable submissing guidelines, but I probably missed something then ?

Best regards,
Marek Vasut