Skip to contentSkip to conversation

arm64/crypto: fix makefile rule for aes-glue-%.o

PATCH New Ard Biesheuvel 2 participants 2 messages Jul 24, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64/crypto: fix makefile rule for aes-glue-%.o

From: Andreas Schwab <[email protected]>

This fixes the following build failure when building with CONFIG_MODVERSIONS enabled:

CC [M] arch/arm64/crypto/aes-glue-ce.o
ld: cannot find arch/arm64/crypto/aes-glue-ce.o: No such file or directory make[1]: *** [arch/arm64/crypto/aes-ce-blk.o] Error 1
make: *** [arch/arm64/crypto] Error 2

The $(obj)/aes-glue-%.o rule only creates $(obj)/.tmp_aes-glue-ce.o, it should use if_changed_rule instead of if_changed_dep.

[ardb: mention CONFIG_MODVERSIONS in commit log]

---

Catalin,

Could you take this for 3.17 please? It fixes a build error when building aes-ce-blk and/or aes-neon-blk as modules with CONFIG_MODVERSIONS enabled.

Cheers,
Ard.

 arch/arm64/crypto/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/Makefile +1 -1
index 2070a56ecc46..a3f935fde975 100644
@@ -35,4 +35,4 @@ AFLAGS_aes-neon.o	:= -DINTERLEAVE=4
 CFLAGS_aes-glue-ce.o	:= -DUSE_V8_CRYPTO_EXTENSIONS
 
 $(obj)/aes-glue-%.o: $(src)/aes-glue.c FORCE
-	$(call if_changed_dep,cc_o_c)
+	$(call if_changed_rule,cc_o_c)
Signature · 1 line
1.8.3.2
maintainer Applied
#1 lore raw

PATCH 1/1 arm64/crypto: fix makefile rule for aes-glue-%.o

Quoted 16 lines · Ard Biesheuvel

From: Andreas Schwab <[email protected]>

This fixes the following build failure when building with CONFIG_MODVERSIONS enabled:

CC [M] arch/arm64/crypto/aes-glue-ce.o
ld: cannot find arch/arm64/crypto/aes-glue-ce.o: No such file or directory make[1]: *** [arch/arm64/crypto/aes-ce-blk.o] Error 1
make: *** [arch/arm64/crypto] Error 2

The $(obj)/aes-glue-%.o rule only creates $(obj)/.tmp_aes-glue-ce.o, it should use if_changed_rule instead of if_changed_dep.

[ardb: mention CONFIG_MODVERSIONS in commit log]
Quoted 6 lines

---

Catalin,

Could you take this for 3.17 please? It fixes a build error when building aes-ce-blk and/or aes-neon-blk as modules with CONFIG_MODVERSIONS enabled.

Queued for 3.17. Thanks.

Signature · 1 line
Catalin