Skip to contentSkip to conversation

usb: ehci: rmobile: Add support R8A7794

PATCH New Nobuhiro Iwamatsu 2 participants 4 messages Jul 24, 2014 – Jul 28, 2014

Subsystems (2)
USB USB ehci driver
lore
Share & tools
lore

Nobuhiro Iwamatsu

author
#0 lore raw

PATCH 1/1 usb: ehci: rmobile: Add support R8A7794

R8A7794 has same IP of USB controller as R8A7790 and R8A7791. This addes support for R8A7794.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/usb/host/ehci-rmobile.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/usb/host/ehci-rmobile.c +6 -0
index 049e4c4..29b4a93 100644
@@ -29,6 +29,12 @@ static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
 	0xEE0C0000,	/* USB1 */
 	0xEE000000	/* USB3 (USB3.0 Host)*/
 };
+#elif defined(CONFIG_R8A7794)
+static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
+	0xEE080000,	/* USB0 (EHCI) */
+	0xEE0C0000,	/* USB1 */
+	/* R8A7794 does not have USB 3.0. */
+};
 #else
 #error rmobile EHCI USB driver not supported on this platform
 #endif
Signature · 1 line
2.0.0
Applied
#1 lore raw

PATCH 1/1 usb: ehci: rmobile: Add support R8A7794

Quoted 13 lines · Nobuhiro Iwamatsu

R8A7794 has same IP of USB controller as R8A7790 and R8A7791. This addes support for R8A7794.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/usb/host/ehci-rmobile.c | 6 ++++++
 1 file changed, 6 insertions(+)
(quoted diff) +0 -0

b/drivers/usb/host/ehci-rmobile.c index 049e4c4..29b4a93 100644

drivers/usb/host/ehci-rmobile.c +0 -0
@@ -29,6 +29,12 @@ static u32
Quoted 3 lines

usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { 0xEE0C0000, /* USB1
*/
0xEE000000 /* USB3 (USB3.0 Host)*/

Just a side-note ... Will this one USB3 controller above really work with the EHCI driver ? I know there is a compat mode for xHCI, but I'm not quite sure it's this easy to make it operational.

drivers/usb/host/ehci-rmobile.c static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { · line 40

Quoted 10 lines

};

drivers/usb/host/ehci-rmobile.c +6 -0
+#elif defined(CONFIG_R8A7794)
+static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
+	0xEE080000,	/* USB0 (EHCI) */
+	0xEE0C0000,	/* USB1 */
+	/* R8A7794 does not have USB 3.0. */
+};
 #else
 #error rmobile EHCI USB driver not supported on this platform
 #endif

Applied, thanks.

Best regards,
Marek Vasut

author
#2 lore raw

PATCH 1/1 usb: ehci: rmobile: Add support R8A7794

Hi, Marek.

Thanks for your review.

2014-07-25 6:38 GMT+09:00 Marek Vasut <[email protected]>:

Quoted 9 lines · Nobuhiro Iwamatsu
Quoted 8 lines

R8A7794 has same IP of USB controller as R8A7790 and R8A7791. This addes support for R8A7794.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/usb/host/ehci-rmobile.c | 6 ++++++
 1 file changed, 6 insertions(+)
Quoted 12 lines
Quoted 8 lines
(quoted diff) +0 -0

b/drivers/usb/host/ehci-rmobile.c index 049e4c4..29b4a93 100644

drivers/usb/host/ehci-rmobile.c +0 -0
@@ -29,6 +29,12 @@ static u32

usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { 0xEE0C0000, /* USB1
*/

      0xEE000000      /* USB3 (USB3.0 Host)*/

Just a side-note ... Will this one USB3 controller above really work with the EHCI driver ? I know there is a compat mode for xHCI, but I'm not quite sure it's this easy to make it operational.

You are right.
ehci-rmobile.c cannot handle USB 3.0.
I send a patch for corrections immediately.

Quoted 13 lines

drivers/usb/host/ehci-rmobile.c static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { · line 40

Quoted 11 lines

};

drivers/usb/host/ehci-rmobile.c +6 -0
+#elif defined(CONFIG_R8A7794)
+static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
+     0xEE080000,     /* USB0 (EHCI) */
+     0xEE0C0000,     /* USB1 */
+     /* R8A7794 does not have USB 3.0. */
+};
 #else
 #error rmobile EHCI USB driver not supported on this platform
 #endif

Applied, thanks.

Thank you.

Quoted 3 lines

Best regards,
Marek Vasut

Best regards,
Nobuhiro

Signature · 1 line
Nobuhiro Iwamatsu
#3 lore raw

PATCH 1/1 usb: ehci: rmobile: Add support R8A7794

Quoted 29 lines · Nobuhiro Iwamatsu

Hi, Marek.

Thanks for your review.

2014-07-25 6:38 GMT+09:00 Marek Vasut <[email protected]>:

Quoted 18 lines · Nobuhiro Iwamatsu
Quoted 17 lines

R8A7794 has same IP of USB controller as R8A7790 and R8A7791. This addes support for R8A7794.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>

---

 drivers/usb/host/ehci-rmobile.c | 6 ++++++
 1 file changed, 6 insertions(+)
(quoted diff) +0 -0

b/drivers/usb/host/ehci-rmobile.c index 049e4c4..29b4a93 100644

drivers/usb/host/ehci-rmobile.c +0 -0
@@ -29,6 +29,12 @@ static u32

usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { 0xEE0C0000, /*
USB1 */

Quoted 5 lines
Quoted 1 line
      0xEE000000      /* USB3 (USB3.0 Host)*/

Just a side-note ... Will this one USB3 controller above really work with the EHCI driver ? I know there is a compat mode for xHCI, but I'm not quite sure it's this easy to make it operational.

Quoted 3 lines

You are right.
ehci-rmobile.c cannot handle USB 3.0.
I send a patch for corrections immediately.

Cool, thanks :) I'll pick it later today.

[...]

Best regards,
Marek Vasut