Skip to contentSkip to conversation

toolchain: include C libraries in legal-info

PATCH New Yann E. MORIN 2 participants 2 messages Jul 25, 2014 – Jul 26, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 toolchain: include C libraries in legal-info

So far, the legal-info infrastructure was not exporting the legal info for the C libraries. This is because the legal-info only acts on packages defined in $(TARGETS).

But the C libraries are never added to $(TARGETS), since there is no corresponding BR2_PACKAGE_<C-LIBRARY>.

This patch adds such symbols for the 4 C libraries we support in our internal backend: uClibc, glibc, eglibc and musl.

Cc Thomas Petazzoni <[email protected]>
Cc Luca Ceresoli <[email protected]>

---
Tested by building the toolchain of the defconfig, which is uClibc-based. Tests not replicated to other C libraries.

---
Changes v1 -> v2:
- remove debug code (Thomas)
- add explanations missing for musl

---
 package/glibc/Config.in  | 10 ++++++++++
 package/musl/Config.in   |  5 +++++
 package/uclibc/Config.in |  5 +++++
 3 files changed, 20 insertions(+)
 create mode 100644 package/musl/Config.in
package/glibc/Config.in +10 -0
index c2d6231..df1e273 100644
@@ -1,5 +1,10 @@
 if BR2_TOOLCHAIN_BUILDROOT_EGLIBC
 
+# For legal-info
+config BR2_PACKAGE_EGLIBC
+	bool
+	default y
+
 choice
 	prompt "eglibc version"
 	default BR2_EGLIBC_VERSION_2_18
@@ -18,6 +23,11 @@ endif
 
 if BR2_TOOLCHAIN_BUILDROOT_GLIBC
 
+# For legal-info
+config BR2_PACKAGE_GLIBC
+	bool
+	default y
+
 choice
 	prompt "glibc version"
 	default BR2_GLIBC_VERSION_2_18
package/musl/Config.in new file +5 -0
new file mode 100644
index 0000000..0aa3537
@@ -0,0 +1,5 @@
+# For legal-info
+config BR2_PACKAGE_MUSL
+	bool
+	depends on BR2_TOOLCHAIN_USES_MUSL
+	default y
package/uclibc/Config.in +5 -0
index 0838b6c..851ad1e 100644
@@ -1,5 +1,10 @@
 if BR2_TOOLCHAIN_BUILDROOT_UCLIBC
 
+# For legal-info
+config BR2_PACKAGE_UCLIBC
+	bool
+	default y
+
 comment "uClibc Options"
 
 choice
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 toolchain: include C libraries in legal-info

Dear Yann E. MORIN,

Quoted 7 lines · Yann E. MORIN

So far, the legal-info infrastructure was not exporting the legal info for the C libraries. This is because the legal-info only acts on packages defined in $(TARGETS).

But the C libraries are never added to $(TARGETS), since there is no corresponding BR2_PACKAGE_<C-LIBRARY>.

Quoted 6 lines

This patch adds such symbols for the 4 C libraries we support in our internal backend: uClibc, glibc, eglibc and musl.

Cc Thomas Petazzoni <[email protected]>
Cc Luca Ceresoli <[email protected]>

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com