Skip to contentSkip to conversation

libpcap: fix build for uclinux target

PATCH New Baruch Siach 2 participants 3 messages Jul 25, 2014 – Jul 29, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libpcap: fix build for uclinux target

As usual, uclinux is also linux. Also, -lpthread is needed to link the canusb test.

Fixes:
http://autobuild.buildroot.net/results/3af/3af796bc0eaa8563f0fd1dfce090083482fa57b9/

---
 ...p-0002-configure.in-uclinux-is-also-linux.patch | 39 ++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 package/libpcap/libpcap-0002-configure.in-uclinux-is-also-linux.patch
package/libpcap/libpcap-0002-configure.in-uclinux-is-also-linux.patch new file +39 -0
new file mode 100644
index 000000000000..605edf59b527
@@ -0,0 +1,39 @@
+From a904d1e35be72d0821a6680a75060815bce86642 Mon Sep 17 00:00:00 2001
+Message-Id: <a904d1e35be72d0821a6680a75060815bce86642.1406266983.git.baruch@tkos.co.il>
+From: Baruch Siach <[email protected]>
+Date: Fri, 25 Jul 2014 07:28:47 +0300
+Subject: [PATCH] configure.in: uclinux is also linux
+
+Also we need -lpthread for the test to build for noMMU targets.
+
+Signend-off-by: Baruch Siach <[email protected]>
+---
+ configure.in | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/configure.in b/configure.in
+index 4530aed3a7d0..63f708b9b855 100644
+--- a/configure.in
++++ b/configure.in
+@@ -1539,7 +1539,7 @@ AC_ARG_ENABLE([canusb],
+ if test "x$enable_canusb" != "xno" ; then
+ 	dnl check for canusb support
+ 	case "$host_os" in
+-	linux*)
++	linux*|uclinux*)
+ 		AC_CHECK_HEADER(libusb-1.0/libusb.h,
+ 		[
+ 		    AC_CHECK_LIB(usb-1.0, libusb_init,
+@@ -1549,7 +1549,8 @@ if test "x$enable_canusb" != "xno" ; then
+ 			LIBS="-lusb-1.0 -lpthread $LIBS"
+ 			ac_lbl_has_libusb=yes
+ 		    ],
+-		    ac_lbl_has_libusb=no
++		    ac_lbl_has_libusb=no,
++		    -lpthread
+ 		    )
+ 		],
+ 		ac_lbl_has_libusb=no
+-- 
+2.0.1
+
Signature · 1 line
2.0.1
#1 lore raw

PATCH 1/1 libpcap: fix build for uclinux target

Dear Baruch Siach,

Quoted 7 lines · Baruch Siach

As usual, uclinux is also linux. Also, -lpthread is needed to link the canusb test.

Fixes:
http://autobuild.buildroot.net/results/3af/3af796bc0eaa8563f0fd1dfce090083482fa57b9/

I've applied your patch, after making one minor change:

package/libpcap/libpcap-0002-configure.in-uclinux-is-also-linux.patch line 9

Quoted 3 lines
package/libpcap/libpcap-0002-configure.in-uclinux-is-also-linux.patch new file +3 -0
+Also we need -lpthread for the test to build for noMMU targets.
+
+Signend-off-by: Baruch Siach <[email protected]>

Typo: Signend -> Signed.

Also, do you think you could send your new patch, as well as the existing 0001 patch on libpcap to the upstream project? It'd be great to be able to drop them at some point, and remove LIBPCAP_AUTORECONF = YES.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 libpcap: fix build for uclinux target

Hi Thomas,

Quoted 9 lines · Thomas Petazzoni
Quoted 7 lines · Baruch Siach

As usual, uclinux is also linux. Also, -lpthread is needed to link the canusb test.

Fixes:
http://autobuild.buildroot.net/results/3af/3af796bc0eaa8563f0fd1dfce090083482fa57b9/

Quoted 7 lines

I've applied your patch, after making one minor change:

package/libpcap/libpcap-0002-configure.in-uclinux-is-also-linux.patch line 9

Quoted 3 lines
package/libpcap/libpcap-0002-configure.in-uclinux-is-also-linux.patch new file +3 -0
+Also we need -lpthread for the test to build for noMMU targets.
+
+Signend-off-by: Baruch Siach <[email protected]>

Typo: Signend -> Signed.

Thanks for fixing and applying.

Quoted 4 lines

Also, do you think you could send your new patch, as well as the existing 0001 patch on libpcap to the upstream project? It'd be great to be able to drop them at some point, and remove LIBPCAP_AUTORECONF = YES.

Done: https://github.com/the-tcpdump-group/libpcap/pull/372.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -