Skip to contentSkip to conversation

ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes

PATCH New Chen-Yu Tsai 3 participants 4 messages Jul 21, 2014 – Jul 28, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes

dtc was giving warnings for missing #address-cells and #size-cells for the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device.

This patch adds the properties for all i2c controller nodes for sun6i.

---

Hi Maxime,

This is a fix to get rid of warnings from dtc when building sun6i dts. Sorry for now catching it earlier.

Cheers
ChenYu

---
 arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/sun6i-a31.dtsi +8 -0
index 44b07e5..e06fbfc 100644
@@ -660,6 +660,8 @@
 			clock-frequency = <100000>;
 			resets = <&apb2_rst 0>;
 			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
 		};
 
 		i2c1: i2c at 01c2b000 {
@@ -670,6 +672,8 @@
 			clock-frequency = <100000>;
 			resets = <&apb2_rst 1>;
 			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
 		};
 
 		i2c2: i2c at 01c2b400 {
@@ -680,6 +684,8 @@
 			clock-frequency = <100000>;
 			resets = <&apb2_rst 2>;
 			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
 		};
 
 		i2c3: i2c at 01c2b800 {
@@ -690,6 +696,8 @@
 			clock-frequency = <100000>;
 			resets = <&apb2_rst 3>;
 			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
 		};
 
 		gmac: ethernet at 01c30000 {
Signature · 1 line
2.0.1
#1 lore raw

PATCH 1/1 ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes

Quoted 6 lines · Chen-Yu Tsai

dtc was giving warnings for missing #address-cells and #size-cells for the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device.

This patch adds the properties for all i2c controller nodes for sun6i.

Applied, thanks.

I don't plan on sending more DT pull-request unless something big shows up, so it's probably queued for 3.18.

It's not like it's urgent anyway...

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140728/92cced1f/attachment.sig>
#2 lore raw

PATCH 1/1 ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes

Quoted 6 lines · On Monday 28 July 2014 11:35:32 Maxime Ripard wrote:
Quoted 5 lines · Chen-Yu Tsai

dtc was giving warnings for missing #address-cells and #size-cells for the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device.

This patch adds the properties for all i2c controller nodes for sun6i.

Quoted 9 lines
Quoted 1 line

Applied, thanks.

I don't plan on sending more DT pull-request unless something big shows up, so it's probably queued for 3.18.

It's not like it's urgent anyway...

No, please send this one, I don't want to introduce new warnings in 3.17.

Arnd

#3 lore raw

PATCH 1/1 ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes

Quoted 11 lines · Arnd Bergmann
Quoted 10 lines · On Monday 28 July 2014 11:35:32 Maxime Ripard wrote:
Quoted 6 lines · Chen-Yu Tsai

dtc was giving warnings for missing #address-cells and #size-cells for the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device.

This patch adds the properties for all i2c controller nodes for sun6i.

Applied, thanks.

Quoted 8 lines
Quoted 5 lines

I don't plan on sending more DT pull-request unless something big shows up, so it's probably queued for 3.18.

It's not like it's urgent anyway...

No, please send this one, I don't want to introduce new warnings in 3.17.

I didn't think we had a user for i2c yet, but yeah, we just got one. I'll send it for 3.17 then.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140728/4790726f/attachment.sig>