Skip to contentSkip to conversation

dma/sh: fix rcar-dma.c printk format warnings

PATCH In review Randy Dunlap 4 participants 5 messages Jul 25, 2014 – Jul 28, 2014

Subsystems (2)
Arm/RISC-V/Renesas architecture dmaengine
lore
Share & tools
lore

Randy Dunlap

author
#0 lore raw

PATCH 1/1 dma/sh: fix rcar-dma.c printk format warnings

From: Randy Dunlap <[email protected]>

Fix printk format warnings by using size_t modifiers ('z'):

../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 9 has type 'size_t' [-Wformat=] ../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 10 has type 'size_t' [-Wformat=]

Signed-off-by Randy Dunlap <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Dan Williams <[email protected]>
Cc [email protected]
---
 drivers/dma/sh/rcar-dmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/sh/rcar-dmac.c +1 -1
Index: linux-next-20140725/drivers/dma/sh/rcar-dmac.c
===================================================================
@@ -757,7 +757,7 @@ rcar_dmac_chan_prep_sg(struct rcar_dmac_
 			hwdesc->size = size;
 
 			dev_dbg(chan->chan.device->dev,
-				"chan%u: hwdesc %p/%p sgl %u@%p, %u/%u %pad -> %pad\n",
+				"chan%u: hwdesc %p/%p sgl %u@%p, %zu/%zu %pad -> %pad\n",
 				chan->index, hwdesc, desc, i, sg, size, len,
 				&hwdesc->src_addr, &hwdesc->dst_addr);
#1 lore raw
Quoted 7 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix printk format warnings by using size_t modifiers ('z'):

../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 9 has type 'size_t' [-Wformat=] ../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 10 has type 'size_t' [-Wformat=]

This is not present in dmaengine trees. Simon is this in your tree?

Signature · 1 line
~Vinod
Quoted 25 lines
Signed-off-by Randy Dunlap <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Dan Williams <[email protected]>
Cc [email protected]
---
 drivers/dma/sh/rcar-dmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-next-20140725/drivers/dma/sh/rcar-dmac.c
===================================================================

drivers/dma/sh/rcar-dmac.c +1 -2
@@ -757,7 +757,7 @@ rcar_dmac_chan_prep_sg(struct rcar_dmac_
 			hwdesc->size = size;
 
 			dev_dbg(chan->chan.device->dev,
-				"chan%u: hwdesc %p/%p sgl %u@%p, %u/%u %pad -> %pad\n",
+				"chan%u: hwdesc %p/%p sgl %u@%p, %zu/%zu %pad -> %pad\n",
 				chan->index, hwdesc, desc, i, sg, size, len,
 				&hwdesc->src_addr, &hwdesc->dst_addr);
 
--

To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by
#2 lore raw
Quoted 5 lines · On Saturday 26 July 2014 21:19:30 Vinod Koul wrote:
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix printk format warnings by using size_t modifiers ('z'):

Quoted 7 lines
Quoted 5 lines

../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 9 has type 'size_t' [-Wformat=] ../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 10 has type 'size_t' [-Wformat=]

This is not present in dmaengine trees. Simon is this in your tree?

The patch applies to a new driver under development that Simon took in his tree. From what he told me he plans to send a pull request soon.

Quoted 4 lines
Quoted 4 lines
Signed-off-by Randy Dunlap <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Dan Williams <[email protected]>
Cc [email protected]
Acked-by Laurent Pinchart <[email protected]>

Simon, should I submit a new version that incorporates this change, or do you want to include it in your pull request directly (possibly squashing it in the original commit) ?

Quoted 17 lines
Quoted 17 lines

---

 drivers/dma/sh/rcar-dmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-next-20140725/drivers/dma/sh/rcar-dmac.c
===================================================================

drivers/dma/sh/rcar-dmac.c +1 -1
@@ -757,7 +757,7 @@ rcar_dmac_chan_prep_sg(struct rcar_dmac_
 			hwdesc->size = size;
 
 			dev_dbg(chan->chan.device->dev,
-				"chan%u: hwdesc %p/%p sgl %u@%p, %u/%u %pad -> %pad\n",
+				"chan%u: hwdesc %p/%p sgl %u@%p, %zu/%zu %pad -> %pad\n",
 				chan->index, hwdesc, desc, i, sg, size, len,
 				&hwdesc->src_addr, &hwdesc->dst_addr);
Signature · 3 lines
Regards,

Laurent Pinchart
#3 lore raw

[Replying again using an HTML-free mail client]

Quoted 22 lines · Laurent Pinchart
Quoted 5 lines · On Saturday 26 July 2014 21:19:30 Vinod Koul wrote:
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix printk format warnings by using size_t modifiers ('z'):

Quoted 7 lines
Quoted 5 lines

../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 9 has type 'size_t' [-Wformat=] ../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 10 has type 'size_t' [-Wformat=]

This is not present in dmaengine trees. Simon is this in your tree?

The patch applies to a new driver under development that Simon took in his tree. From what he told me he plans to send a pull request soon.

Quoted 4 lines
Quoted 4 lines
Signed-off-by Randy Dunlap <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Dan Williams <[email protected]>
Cc [email protected]
Quoted 5 lines
Acked-by Laurent Pinchart <[email protected]>

Simon, should I submit a new version that incorporates this change, or do you want to include it in your pull request directly (possibly squashing it in the original commit) ?

Hi Laurent,

sorry for any confusion that I may have caused.
I will see about squashing this change into the original commit.

Quoted 23 lines
Quoted 17 lines
Quoted 17 lines

---

 drivers/dma/sh/rcar-dmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-next-20140725/drivers/dma/sh/rcar-dmac.c
===================================================================

drivers/dma/sh/rcar-dmac.c +1 -1
@@ -757,7 +757,7 @@ rcar_dmac_chan_prep_sg(struct rcar_dmac_
 			hwdesc->size = size;
 
 			dev_dbg(chan->chan.device->dev,
-				"chan%u: hwdesc %p/%p sgl %u@%p, %u/%u %pad -> %pad\n",
+				"chan%u: hwdesc %p/%p sgl %u@%p, %zu/%zu %pad -> %pad\n",
 				chan->index, hwdesc, desc, i, sg, size, len,
 				&hwdesc->src_addr, &hwdesc->dst_addr);
Signature · 3 lines
Regards,

Laurent Pinchart
#4 lore raw
Quoted 27 lines · Simon Horman

[Replying again using an HTML-free mail client]

Quoted 24 lines · Laurent Pinchart
Quoted 5 lines · On Saturday 26 July 2014 21:19:30 Vinod Koul wrote:
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix printk format warnings by using size_t modifiers ('z'):

Quoted 7 lines
Quoted 5 lines

../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 9 has type 'size_t' [-Wformat=] ../drivers/dma/sh/rcar-dmac.c:759:4: warning: format '%u' expects argument of type 'unsigned int', but argument 10 has type 'size_t' [-Wformat=]

This is not present in dmaengine trees. Simon is this in your tree?

The patch applies to a new driver under development that Simon took in his tree. From what he told me he plans to send a pull request soon.

Quoted 4 lines
Quoted 4 lines
Signed-off-by Randy Dunlap <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Dan Williams <[email protected]>
Cc [email protected]
Acked-by Laurent Pinchart <[email protected]>
Quoted 8 lines
Quoted 3 lines

Simon, should I submit a new version that incorporates this change, or do you want to include it in your pull request directly (possibly squashing it in the original commit) ?

Hi Laurent,

sorry for any confusion that I may have caused.
I will see about squashing this change into the original commit.

On second thoughts I decided to commit this patch on top of my branch in order to correctly credit Randy.

Quoted 23 lines
Quoted 23 lines
Quoted 17 lines
Quoted 17 lines

---

 drivers/dma/sh/rcar-dmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-next-20140725/drivers/dma/sh/rcar-dmac.c
===================================================================

drivers/dma/sh/rcar-dmac.c +1 -1
@@ -757,7 +757,7 @@ rcar_dmac_chan_prep_sg(struct rcar_dmac_
 			hwdesc->size = size;
 
 			dev_dbg(chan->chan.device->dev,
-				"chan%u: hwdesc %p/%p sgl %u@%p, %u/%u %pad -> %pad\n",
+				"chan%u: hwdesc %p/%p sgl %u@%p, %zu/%zu %pad -> %pad\n",
 				chan->index, hwdesc, desc, i, sg, size, len,
 				&hwdesc->src_addr, &hwdesc->dst_addr);
Signature · 3 lines
Regards,

Laurent Pinchart