ARM: dts: nitrogen6x: add i2c2

PATCH New Lucas Stach 3 participants 8 messages Jul 25, 2014 – Jul 29, 2014

Subsystems (2)

Device tree bindings Arm i.MX and Layerscape

lore

Share & tools

lore

Lucas Stach

author

2014-07-25 10:49 UTC #0 lore raw

PATCH 1/3 ARM: dts: nitrogen6x: add i2c2

From: Michael Olbrich <[email protected]>

Signed-off-by Michael Olbrich <[email protected]>

Signed-off-by Lucas Stach <[email protected]>

---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +14 -0

index 4c4b17596c8b..3362d2600d85 100644
@@ -189,6 +189,13 @@
 	};
 };
 
+&i2c2 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+};
+
 &iomuxc {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_hog>;

@@ -266,6 +273,13 @@
 			>;
 		};
 
+		pinctrl_i2c2: i2c2grp {
+			fsl,pins = <
+				MX6QDL_PAD_KEY_COL3__I2C2_SCL		0x4001b8b1
+				MX6QDL_PAD_KEY_ROW3__I2C2_SDA		0x4001b8b1
+			>;
+		};
+
 		pinctrl_pwm1: pwm1grp {
 			fsl,pins = <
 				MX6QDL_PAD_SD1_DAT3__PWM1_OUT 0x1b0b1

Signature · 1 line

2.0.1

Lucas Stach

author

2014-07-25 10:49 UTC #1 lore raw

PATCH 2/3 ARM: dts: nitrogen6x: add hdmi

From: Michael Olbrich <[email protected]>

Signed-off-by Michael Olbrich <[email protected]>

Signed-off-by Lucas Stach <[email protected]>

---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +6 -0

index 3362d2600d85..4e27cf9f3d2e 100644
@@ -174,6 +174,12 @@
 	status = "okay";
 };
 
+&hdmi {
+	ddc-i2c-bus = <&i2c2>;
+	hpd-unreliable;
+	status = "okay";
+};
+
 &i2c1 {
 	clock-frequency = <100000>;
 	pinctrl-names = "default";

Signature · 1 line

2.0.1

Fabio Estevam

reviewer

2014-07-25 13:48 UTC #2 lore raw

PATCH 2/3 ARM: dts: nitrogen6x: add hdmi

Hi Lucas,

Quoted 13 lines · Lucas Stach

From: Michael Olbrich <[email protected]>
Signed-off-by Michael Olbrich <[email protected]>
Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +0 -0
index 3362d2600d85..4e27cf9f3d2e 100644

arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi line 179

Quoted 6 lines

arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +3 -0

@@ -174,6 +174,12 @@
        status = "okay";
 };
 
+&hdmi {
+       ddc-i2c-bus = <&i2c2>;
+       hpd-unreliable;

I don't see this property available in linux-next yet. Are we missing the patch that adds it?

Lucas Stach

author

2014-07-25 13:55 UTC #3 lore raw

PATCH 2/3 ARM: dts: nitrogen6x: add hdmi

Am Freitag, den 25.07.2014, 10:48 -0300 schrieb Fabio Estevam:

Quoted 19 lines

Hi Lucas,
Quoted 16 lines · Lucas Stach
From: Michael Olbrich <[email protected]>
Signed-off-by Michael Olbrich <[email protected]>
Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +0 -0
index 3362d2600d85..4e27cf9f3d2e 100644
@@ -174,6 +174,12 @@
        status = "okay";
 };
 

Quoted 7 lines

arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi line 179
Quoted 3 lines
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +3 -0
+&hdmi {
+       ddc-i2c-bus = <&i2c2>;
+       hpd-unreliable;
I don't see this property available in linux-next yet. Are we missing the patch that adds it?

Right, we are missing a patch here. It already has been posted to the list long time ago, but obviously fell through the cracks. Thanks for spotting.

Regards,
Lucas

Signature · 2 lines

Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

Shawn Guo

2014-07-29 07:48 UTC #4 lore raw

PATCH 2/3 ARM: dts: nitrogen6x: add hdmi

Quoted 27 lines · Lucas Stach

Am Freitag, den 25.07.2014, 10:48 -0300 schrieb Fabio Estevam:
Quoted 19 lines
Hi Lucas,
Quoted 16 lines · Lucas Stach
From: Michael Olbrich <[email protected]>
Signed-off-by Michael Olbrich <[email protected]>
Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +0 -0
index 3362d2600d85..4e27cf9f3d2e 100644
@@ -174,6 +174,12 @@
        status = "okay";
 };
 
Quoted 7 lines
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi line 179
Quoted 3 lines
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +3 -0
+&hdmi {
+       ddc-i2c-bus = <&i2c2>;
+       hpd-unreliable;
I don't see this property available in linux-next yet. Are we missing the patch that adds it?

Quoted 3 lines

Right, we are missing a patch here. It already has been posted to the list long time ago, but obviously fell through the cracks. Thanks for spotting.

So should I drop the property and apply the patches or just ignore the series?

Shawn

Lucas Stach

author

2014-07-29 08:14 UTC #5 lore raw

PATCH 2/3 ARM: dts: nitrogen6x: add hdmi

Am Dienstag, den 29.07.2014, 15:48 +0800 schrieb Shawn Guo:

Quoted 28 lines · Lucas Stach

Quoted 27 lines
Am Freitag, den 25.07.2014, 10:48 -0300 schrieb Fabio Estevam:
Quoted 26 lines
Hi Lucas,
Quoted 13 lines · Lucas Stach
From: Michael Olbrich <[email protected]>
Signed-off-by Michael Olbrich <[email protected]>
Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +0 -0
index 3362d2600d85..4e27cf9f3d2e 100644
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi line 179
Quoted 6 lines
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +3 -0
@@ -174,6 +174,12 @@
        status = "okay";
 };
 
+&hdmi {
+       ddc-i2c-bus = <&i2c2>;
+       hpd-unreliable;
I don't see this property available in linux-next yet. Are we missing the patch that adds it?

Quoted 7 lines

Quoted 3 lines
Right, we are missing a patch here. It already has been posted to the list long time ago, but obviously fell through the cracks. Thanks for spotting.
So should I drop the property and apply the patches or just ignore the series?

Please drop the property and apply. I'll take care of re-adding this when the relevant imx-drm patches are in.

Regards,
Lucas

Signature · 2 lines

Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

Shawn Guo

2014-07-29 08:59 UTC #6 lore raw

PATCH 2/3 ARM: dts: nitrogen6x: add hdmi

Quoted 2 lines · Lucas Stach

Please drop the property and apply. I'll take care of re-adding this when the relevant imx-drm patches are in.

Done.

Shawn

Lucas Stach

author

2014-07-25 10:49 UTC #7 lore raw

PATCH 3/3 ARM: dts: nitrogen6x: add i2c3

In reply to Lucas Stach

From: Philipp Zabel <[email protected]>

Signed-off-by Philipp Zabel <[email protected]>

Signed-off-by Lucas Stach <[email protected]>

---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +14 -0

index 4e27cf9f3d2e..3e09f260f5a1 100644
@@ -202,6 +202,13 @@
 	status = "okay";
 };
 
+&i2c3 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c3>;
+	status = "okay";
+};
+
 &iomuxc {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_hog>;

@@ -286,6 +293,13 @@
 			>;
 		};
 
+		pinctrl_i2c3: i2c3grp {
+			fsl,pins = <
+				MX6QDL_PAD_GPIO_5__I2C3_SCL		0x4001b8b1
+				MX6QDL_PAD_GPIO_16__I2C3_SDA		0x4001b8b1
+			>;
+		};
+
 		pinctrl_pwm1: pwm1grp {
 			fsl,pins = <
 				MX6QDL_PAD_SD1_DAT3__PWM1_OUT 0x1b0b1

Signature · 1 line

2.0.1