ARM: shmobile: Consistent use of shmobile_init_late()

ARM: shmobile: Consistent use of shmobile_init_late()

[PATCH 01/09] ARM: shmobile: Add shmobile_init_late() to sh73a0 [PATCH 02/09] ARM: shmobile: Add shmobile_init_late() to KZM9G [PATCH 03/09] ARM: shmobile: Fix shmobile_init_late() on r8a7779 [PATCH 04/09] ARM: shmobile: Add shmobile_init_late() to Marzen [PATCH 05/09] ARM: shmobile: Fix shmobile_init_late() on r8a7778 [PATCH 06/09] ARM: shmobile: Add shmobile_init_late() to Bock-W [PATCH 07/09] ARM: shmobile: Add shmobile_init_late() to r8a73a4 [PATCH 08/09] ARM: shmobile: Add shmobile_init_late() to APE6EVM [PATCH 09/09] ARM: shmobile: Add shmobile_init_late() to r7s72100

Make sure all mach-shmobile SoCs and DT Reference board support code call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup in a consistent way. The SoC DT case for r8a7778 and r8a7779 are also adjusted to not add any platform devices. DT shall be used instead.

Signed-off-by Magnus Damm <[email protected]>

---

Written on top of renesas-devel-v3.16-rc7-20140729

 arch/arm/mach-shmobile/board-ape6evm-reference.c |    1 +
 arch/arm/mach-shmobile/board-ape6evm.c           |    1 +
 arch/arm/mach-shmobile/board-bockw-reference.c   |    1 +
 arch/arm/mach-shmobile/board-kzm9g-reference.c   |    1 +
 arch/arm/mach-shmobile/board-marzen-reference.c  |    1 +
 arch/arm/mach-shmobile/setup-r7s72100.c          |    1 +
 arch/arm/mach-shmobile/setup-r8a73a4.c           |    1 +
 arch/arm/mach-shmobile/setup-r8a7778.c           |    2 +-
 arch/arm/mach-shmobile/setup-r8a7779.c           |    2 +-
 arch/arm/mach-shmobile/setup-sh73a0.c            |    1 +

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 12 lines · Magnus Damm

ARM: shmobile: Consistent use of shmobile_init_late()

[PATCH 01/09] ARM: shmobile: Add shmobile_init_late() to sh73a0 [PATCH 02/09] ARM: shmobile: Add shmobile_init_late() to KZM9G [PATCH 03/09] ARM: shmobile: Fix shmobile_init_late() on r8a7779 [PATCH 04/09] ARM: shmobile: Add shmobile_init_late() to Marzen [PATCH 05/09] ARM: shmobile: Fix shmobile_init_late() on r8a7778 [PATCH 06/09] ARM: shmobile: Add shmobile_init_late() to Bock-W [PATCH 07/09] ARM: shmobile: Add shmobile_init_late() to r8a73a4 [PATCH 08/09] ARM: shmobile: Add shmobile_init_late() to APE6EVM [PATCH 09/09] ARM: shmobile: Add shmobile_init_late() to r7s72100

Quoted 4 lines

Make sure all mach-shmobile SoCs and DT Reference board support code call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup in a consistent way. The SoC DT case for r8a7778 and r8a7779 are also adjusted to not add any platform devices. DT shall be used instead.

Hi Magnus,

these patches seem fine for me but I wonder if you could follow the convention that has emerged as being dominant for subjects for shmobile patches.

* Using lowercase for SOC names
* Omitting hyphens from boards names (i.e. bockw)
* Putting the board or soc after "shmobile: " and followed by a ':'.

I have taken the liberty of updating the patch names to the following and queued up the result:

ARM: shmobile: sh73a0: Add shmobile_init_late()
ARM: shmobile: kzm9g: Add shmobile_init_late()
ARM: shmobile: r8a7779: Fix shmobile_init_late()
ARM: shmobile: marzen: Add shmobile_init_late()
ARM: shmobile: r8a7778: Fix shmobile_init_late()
ARM: shmobile: bockw: Add shmobile_init_late()
ARM: shmobile: r8a73a4: Add shmobile_init_late()
ARM: shmobile: ape6evm: Add shmobile_init_late()
ARM: shmobile: r7s72100: Add shmobile_init_late()

The reason for requesting this is that from time to time I in turn receive requests to make subjects consistent.

Quoted 41 lines · Simon Horman

Quoted 12 lines · Magnus Damm

ARM: shmobile: Consistent use of shmobile_init_late()

[PATCH 01/09] ARM: shmobile: Add shmobile_init_late() to sh73a0 [PATCH 02/09] ARM: shmobile: Add shmobile_init_late() to KZM9G [PATCH 03/09] ARM: shmobile: Fix shmobile_init_late() on r8a7779 [PATCH 04/09] ARM: shmobile: Add shmobile_init_late() to Marzen [PATCH 05/09] ARM: shmobile: Fix shmobile_init_late() on r8a7778 [PATCH 06/09] ARM: shmobile: Add shmobile_init_late() to Bock-W [PATCH 07/09] ARM: shmobile: Add shmobile_init_late() to r8a73a4 [PATCH 08/09] ARM: shmobile: Add shmobile_init_late() to APE6EVM [PATCH 09/09] ARM: shmobile: Add shmobile_init_late() to r7s72100

Quoted 4 lines

Make sure all mach-shmobile SoCs and DT Reference board support code call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup in a consistent way. The SoC DT case for r8a7778 and r8a7779 are also adjusted to not add any platform devices. DT shall be used instead.

Hi Magnus,

these patches seem fine for me but I wonder if you could follow the convention that has emerged as being dominant for subjects for shmobile patches.

* Using lowercase for SOC names
* Omitting hyphens from boards names (i.e. bockw)
* Putting the board or soc after "shmobile: " and followed by a ':'.

I have taken the liberty of updating the patch names to the following and queued up the result:

ARM: shmobile: sh73a0: Add shmobile_init_late()
ARM: shmobile: kzm9g: Add shmobile_init_late()
ARM: shmobile: r8a7779: Fix shmobile_init_late()
ARM: shmobile: marzen: Add shmobile_init_late()
ARM: shmobile: r8a7778: Fix shmobile_init_late()
ARM: shmobile: bockw: Add shmobile_init_late()
ARM: shmobile: r8a73a4: Add shmobile_init_late()
ARM: shmobile: ape6evm: Add shmobile_init_late()
ARM: shmobile: r7s72100: Add shmobile_init_late()

Quoted 2 lines

The reason for requesting this is that from time to time I in turn receive requests to make subjects consistent.

Hi Simon,

Thanks for fixing up inconsistencies and picking up patches. I agree with the hyphen removal - why on earth would anyone want a hyphen in their board name anyway? Lower case SoC name makes sense - with the exception on EMEV2, but I'm fine adjusting that to lower case too. =)

The upper case board name is something that i've used over many years, but I will do my best to try to adjust my default mode of operation and stick to lower case from now on.

Make sure all mach-shmobile SoCs and DT Reference board support code call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup in a consistent way. The SoC DT case for r8a7778 and r8a7779 are also adjusted to not add any platform devices. DT shall be used instead.

Hi Magnus,

Quoted 4 lines · Magnus Damm

Make sure all mach-shmobile SoCs and DT Reference board support code call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup in a consistent way. The SoC DT case for r8a7778 and r8a7779 are also adjusted to not add any platform devices. DT shall be used instead.

Aha, that last part was missing from the individual descriptions for r8a7778 and r8a7779 ;-)
r8a7779_init_late() already called shmobile_init_late() internally.

However, r8a7778_init_late() doesn't call shmobile_init_late(). Shouldn't that be added, too, to fix bockw?

Quoted 9 lines · Geert Uytterhoeven

Quoted 4 lines · Magnus Damm

Make sure all mach-shmobile SoCs and DT Reference board support code call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup in a consistent way. The SoC DT case for r8a7778 and r8a7779 are also adjusted to not add any platform devices. DT shall be used instead.

Aha, that last part was missing from the individual descriptions for r8a7778 and r8a7779 ;-)
r8a7779_init_late() already called shmobile_init_late() internally.

Right, next time I'll put more contents in the each patch!

Quoted 2 lines

However, r8a7778_init_late() doesn't call shmobile_init_late(). Shouldn't that be added, too, to fix bockw?

Maybe so, but I deem the legacy code as a lost cause. I also don't have any hardware access myself, so I can't test it.

If you feel like it, please cook up a patch then I think Simon or Morimoto-san can test!